This is an archive of the discontinued LLVM Phabricator instance.

[InferAddressSpaces][NFC] Small code improvements for the InferAddressSpaces pass

Authored by psamolysov-intel on Mar 15 2022, 12:16 AM.



There is a bunch of code improvements in the patch: marking as const everything what can be
const and fixing some typos in comments.

Also the patch removes the shadowing parameter TTI from the rewriteWithNewAddressSpaces
method, the TTI parameter is not required because the same field is in the class.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2022, 12:16 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
psamolysov-intel requested review of this revision.Mar 15 2022, 12:16 AM
psamolysov-intel edited the summary of this revision. (Show Details)Mar 15 2022, 12:17 AM

The linter warnings have been fixed.

arsenm accepted this revision.Mar 15 2022, 6:48 AM
This revision is now accepted and ready to land.Mar 15 2022, 6:48 AM

All the failed tests on Windows are in the LLVM :: CodeGen/VE/Vector folder, I believe the tests aren't related to the changes introduces by the patch.

@arsenm Thank you for the approve. If no one has any objections, could you help me with landing because I have no committer rights to the LLVM repository? Thank you.

If there are no objections for this small patch, could someone with committer rights land it, please? Thank you.

psamolysov-intel added a subscriber: cchen.EditedMar 22 2022, 1:39 AM

Thank you very much for landing!