Includes two test fixes (since chained mappings are no longer allowed)
and adds a new test for multiple overlays.
Uses other than CompilerInvocation.cpp are simple 1:1 mappings, but
without the need to read into a buffer first.
Depends on D121425
Paths
| Differential D121426
[VFS] Update uses of getVFSFromYAML to use the new getVFSFromYAMLs API AbandonedPublic Authored by bnbarham on Mar 10 2022, 3:38 PM.
Details
Summary Includes two test fixes (since chained mappings are no longer allowed) Uses other than CompilerInvocation.cpp are simple 1:1 mappings, but Depends on D121425
Diff Detail
Event TimelineHerald added projects: Restricted Project, Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptMar 10 2022, 3:38 PM
Comment Actions
Are we sure no one needs to support chained mappings? Has there been a
Comment Actions
I'm not *positive*, no, but I would be fairly surprised. You could just add the A -> C mapping if you really do want it. But I can start up that conversation if you think it needs having. I actually didn't initially realise that there was a test for this case - vfsroot-with-overlay.c did test "indirection", but I completely missed it when I was looking through. I *thought* the only case was the one Nathan added in directory.c (and in that case what we really wanted was was what's now fallback). @vsapsai do you know any clients of the chaining/nesting/indirection?
Revision Contents
Diff 414751 clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp
clang/lib/Frontend/CompilerInvocation.cpp
clang/test/VFS/Inputs/vfsroot.yaml
clang/test/VFS/directory.c
clang/test/VFS/multiple-overlays.c
clang/test/VFS/vfsroot-with-overlay.c
lldb/source/Commands/CommandObjectReproducer.cpp
llvm/include/llvm/Support/Error.h
llvm/tools/dsymutil/Reproducer.h
llvm/tools/dsymutil/Reproducer.cpp
|
Should this be in a change all by itself?