This is an archive of the discontinued LLVM Phabricator instance.

Differential D120986

[flang] Fix standalone builds
ClosedPublic

Authored by awarzynski on Mar 4 2022, 3:40 AM.

Details

Reviewers
DavidSpickett
Commits
rGbbcc0f6006a1: [flang] Fix standalone builds
Summary

In dd875dd88bf7f39ad56d8402bdc49ffeb51b4ab8 I added a missing MLIR
dependency in Flang. However, that particular CMake target is not
exported as something available to standalone builds. In this patch is
switch to MLIRIR instead, which depends on
MLIRBuiltinAttributeInterfacesIncGen - the missing dependency added
previously.

Diff Detail

Event Timeline

awarzynski created this revision.Mar 4 2022, 3:40 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 4 2022, 3:40 AM
Herald added subscribers: Chia-hungDuan, rriddle, mgorny. · View Herald Transcript
awarzynski requested review of this revision.Mar 4 2022, 3:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2022, 3:40 AM
Herald added subscribers: llvm-commits, stephenneuendorffer, jdoerfert. · View Herald Transcript
Harbormaster completed remote builds in B152568: Diff 412976.Mar 4 2022, 3:57 AM
DavidSpickett accepted this revision.Mar 4 2022, 4:00 AM

LGTM if the standalone build is working. Also tested with sharedlibs and is fine.

This revision is now accepted and ready to land.Mar 4 2022, 4:00 AM
awarzynski added a comment.Mar 4 2022, 5:06 AM
In D120986#3359634, @DavidSpickett wrote:

LGTM if the standalone build is working. Also tested with sharedlibs and is fine.

I tested standalone builds locally and that worked fine too. Thanks for reviewing and testing 👍🏻 !

Closed by commit rGbbcc0f6006a1: [flang] Fix standalone builds (authored by awarzynski). · Explain WhyMar 4 2022, 5:07 AM
This revision was automatically updated to reflect the committed changes.
awarzynski added a commit: rGbbcc0f6006a1: [flang] Fix standalone builds.

Revision Contents

PathSize
flang/
lib/
Frontend/
2 lines

Diff 412976

flang/lib/Frontend/CMakeLists.txt

Show All 9 Linesadd_flang_library(flangFrontend
TextDiagnosticBuffer.cpp TextDiagnosticBuffer.cpp
TextDiagnostic.cpp TextDiagnostic.cpp
DEPENDS DEPENDS
clangBasic clangBasic
FIRBuilder FIRBuilder
FIRDialect FIRDialect
FIRSupport FIRSupport
MLIRBuiltinAttributeInterfacesIncGen MLIRIR
${dialect_libs} ${dialect_libs}
LINK_LIBS LINK_LIBS
FortranParser FortranParser
FortranSemantics FortranSemantics
FortranEvaluate FortranEvaluate
FortranCommon FortranCommon
FortranLower FortranLower
Show All 18 Lines