Since LLVM MC now preserves redundant AdSize override prefix (0x67), remove it
in BOLT explicitly (-x86-strip-redundant-adsize, on by default).
Test Plan:
bin/llvm-lit -a bolt/test/X86/addr32.s
Paths
| Differential D120975
[BOLT] Strip redundant AdSize override prefix ClosedPublic Authored by Amir on Mar 3 2022, 10:07 PM.
Details
Summary Since LLVM MC now preserves redundant AdSize override prefix (0x67), remove it Test Plan:
Diff Detail
Event TimelineAmir added a parent revision: D120871: [X86] Emit REX prefix immediately before the opcode.Mar 3 2022, 10:07 PM Comment Actions @maksfb, @rafaelauler Comment Actions LGTM (nit below)
This revision is now accepted and ready to land.Mar 16 2022, 5:38 AM This revision was landed with ongoing or failed builds.Mar 16 2022, 9:38 AM Closed by commit rGdc1cf838a501: [BOLT] Strip redundant AdSize override prefix (authored by Amir). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 412933 bolt/include/bolt/Core/MCPlusBuilder.h
bolt/lib/Passes/BinaryPasses.cpp
bolt/lib/Target/AArch64/AArch64MCPlusBuilder.cpp
bolt/lib/Target/X86/X86MCPlusBuilder.cpp
bolt/test/X86/addr32.s
|
Can we call this (...)AddressSize and -address-size? I find adsize to be a bit confusing.