This is an archive of the discontinued LLVM Phabricator instance.

Differential D120655

WoA: Enable check-flang on clang-arm64-windows-msvc
ClosedPublic

Authored by rovka on Feb 28 2022, 3:23 AM.

Details

Reviewers
gkistanova
maxim-kuvyrkov
DavidSpickett
omjavaid
sscalpone
Commits
rZORG261aef6083c5: WoA: Enable check-flang on clang-arm64-windows-msvc

Diff Detail

Event Timeline

rovka created this revision.Feb 28 2022, 3:23 AM
Herald added a reviewer: sscalpone. · View Herald TranscriptFeb 28 2022, 3:23 AM
Herald added subscribers: mstorsjo, jdoerfert, kristof.beyls. · View Herald Transcript
rovka requested review of this revision.Feb 28 2022, 3:23 AM
rovka added parent revisions: D120654: WoA: Change target triple & try_compile config, D120653: ClangBuilder: Use list of checks instead of boolean. NFCI.
DavidSpickett added inline comments.Feb 28 2022, 3:29 AM
buildbot/osuosl/master/config/builders.py
239–240
# Only enabling checks we expect to work.
checks=['check-flang'],
rovka updated this revision to Diff 411779.Feb 28 2022, 3:47 AM

Fixed comment, thanks!

Harbormaster completed remote builds in B151732: Diff 411779.Feb 28 2022, 3:48 AM
DavidSpickett accepted this revision.Feb 28 2022, 4:06 AM

LGTM

This revision is now accepted and ready to land.Feb 28 2022, 4:06 AM
gkistanova accepted this revision.Feb 28 2022, 9:00 AM

LGTM

This revision was landed with ongoing or failed builds.Mar 2 2022, 1:40 AM
Closed by commit rZORG261aef6083c5: WoA: Enable check-flang on clang-arm64-windows-msvc (authored by rovka). · Explain Why
This revision was automatically updated to reflect the committed changes.
rovka added a commit: rZORG261aef6083c5: WoA: Enable check-flang on clang-arm64-windows-msvc.
Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2022, 1:40 AM

Revision Contents

PathSize
buildbot/
osuosl/
master/
config/
3 lines

Diff 412355

buildbot/osuosl/master/config/builders.py

Show First 20 Lines • Show All 230 Lines • ▼ Show 20 Lines# Clang builders.
{'name': "clang-arm64-windows-msvc", {'name': "clang-arm64-windows-msvc",
'tags' : ["clang"], 'tags' : ["clang"],
'workernames' : ["linaro-armv8-windows-msvc-01", "linaro-armv8-windows-msvc-02"], 'workernames' : ["linaro-armv8-windows-msvc-01", "linaro-armv8-windows-msvc-02"],
'builddir': "clang-arm64-windows-msvc", 'builddir': "clang-arm64-windows-msvc",
'factory' : ClangBuilder.getClangCMakeBuildFactory( 'factory' : ClangBuilder.getClangCMakeBuildFactory(
vs="manual", vs="manual",
checkout_flang=True, checkout_flang=True,
checks=[], # Disable testing until MCJIT failures are fixed # Only enabling checks we expect to work.
checks=['check-flang'],
DavidSpickettUnsubmitted
Not Done
ReplyInline Actions
# Only enabling checks we expect to work.
checks=['check-flang'],
DavidSpickett: ``` # Only enabling checks we expect to work. checks=['check-flang'], ```
extra_cmake_args=[ extra_cmake_args=[
"-DCMAKE_TRY_COMPILE_CONFIGURATION=Release", "-DCMAKE_TRY_COMPILE_CONFIGURATION=Release",
"-DLLVM_DEFAULT_TARGET_TRIPLE=aarch64-pc-windows-msvc", "-DLLVM_DEFAULT_TARGET_TRIPLE=aarch64-pc-windows-msvc",
"-DLLVM_HOST_TRIPLE=aarch64-pc-windows-msvc", "-DLLVM_HOST_TRIPLE=aarch64-pc-windows-msvc",
"-DLLVM_TARGET_ARCH=AArch64", "-DLLVM_TARGET_ARCH=AArch64",
# The BUILTINS environment variable is expected to already exist # The BUILTINS environment variable is expected to already exist
# on the worker when it is launched. # on the worker when it is launched.
"-DCMAKE_EXE_LINKER_FLAGS=%BUILTINS%", "-DCMAKE_EXE_LINKER_FLAGS=%BUILTINS%",
▲ Show 20 Lines • Show All 2,068 Lines • Show Last 20 Lines