Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D119912

Hoist getTotalNumVGPRs into AMDGPUBaseInfo for use in both codegen and MC
ClosedPublic
Actions

Authored by lamb-j on Feb 15 2022, 7:12 PM.

Details

Reviewers

kzhuravl
arsenm
rampitec

Commits

rG0bad7cb56526: Hoist getTotalNumVGPRs into AMDGPUBaseInfo for use in both codegen and MC

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

lamb-j created this revision.Feb 15 2022, 7:12 PM

Herald added subscribers: foad, kerbowa, hiraditya and 6 others. · View Herald TranscriptFeb 15 2022, 7:12 PM

lamb-j requested review of this revision.Feb 15 2022, 7:12 PM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2022, 7:12 PM

Herald added subscribers: llvm-commits, wdng. · View Herald Transcript

lamb-j added a parent revision: D116140: [AMDGPU] Add agpr_count to metadata and AsmParser.Feb 15 2022, 7:16 PM

Harbormaster completed remote builds in B149876: Diff 409121.Feb 15 2022, 7:51 PM

arsenm added inline comments.Feb 16 2022, 6:57 AM

llvm/lib/Target/AMDGPU/AMDGPUResourceUsageAnalysis.cpp
90	Don't need llvm::
llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
1527	Formatting

Please fix clang-format notes as well.

Removing llvm namespace from function call and addressing clang-format issues

Harbormaster completed remote builds in B149999: Diff 409303.Feb 16 2022, 9:48 AM

Fix small formatting error

lamb-j marked 2 inline comments as done.Feb 16 2022, 9:52 AM

Harbormaster completed remote builds in B150001: Diff 409306.Feb 16 2022, 9:52 AM

arsenm accepted this revision.Feb 16 2022, 9:55 AM

This revision is now accepted and ready to land.Feb 16 2022, 9:55 AM

Updating commit message

Harbormaster completed remote builds in B150012: Diff 409321.Feb 16 2022, 10:39 AM

This revision was landed with ongoing or failed builds.Feb 16 2022, 11:08 AM

Closed by commit rG0bad7cb56526: Hoist getTotalNumVGPRs into AMDGPUBaseInfo for use in both codegen and MC (authored by lamb-j). · Explain Why

This revision was automatically updated to reflect the committed changes.

lamb-j added a commit: rG0bad7cb56526: Hoist getTotalNumVGPRs into AMDGPUBaseInfo for use in both codegen and MC.

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Target/

AMDGPU/

AMDGPUResourceUsageAnalysis.cpp

4 lines

Utils/

AMDGPUBaseInfo.h

1 line

AMDGPUBaseInfo.cpp

7 lines

Diff 409339

llvm/lib/Target/AMDGPU/AMDGPUResourceUsageAnalysis.cpp

Loading...

llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h

Loading...

llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp

Loading...