Page MenuHomePhabricator

Hoist getTotalNumVGPRs into AMDGPUBaseInfo for use in both codegen and MC
ClosedPublic

Authored by lamb-j on Feb 15 2022, 7:12 PM.

Diff Detail

Event Timeline

lamb-j created this revision.Feb 15 2022, 7:12 PM
lamb-j requested review of this revision.Feb 15 2022, 7:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2022, 7:12 PM
arsenm added inline comments.Feb 16 2022, 6:57 AM
llvm/lib/Target/AMDGPU/AMDGPUResourceUsageAnalysis.cpp
90

Don't need llvm::

llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
1527

Formatting

Please fix clang-format notes as well.

lamb-j updated this revision to Diff 409303.Feb 16 2022, 9:47 AM

Removing llvm namespace from function call and addressing clang-format issues

lamb-j updated this revision to Diff 409306.Feb 16 2022, 9:51 AM

Fix small formatting error

lamb-j marked 2 inline comments as done.Feb 16 2022, 9:52 AM
arsenm accepted this revision.Feb 16 2022, 9:55 AM
This revision is now accepted and ready to land.Feb 16 2022, 9:55 AM
lamb-j updated this revision to Diff 409321.Feb 16 2022, 10:38 AM

Updating commit message

This revision was landed with ongoing or failed builds.Feb 16 2022, 11:08 AM
This revision was automatically updated to reflect the committed changes.