Page MenuHomePhabricator

lamb-j (Jacob Lambert)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 7 2021, 10:56 AM (65 w, 2 d)

Recent Activity

Wed, Dec 7

lamb-j added a comment to D137275: [Driver][test] Fix test by creating empty archive instead of empty file.

@thakis thanks for reverting that, sorry I didn't see your request sooner!

Wed, Dec 7, 11:53 AM · Restricted Project, Restricted Project
lamb-j committed rGf9de860ca4c4: [Driver][test] Fix test by creating empty archive instead of empty file (authored by lamb-j).
[Driver][test] Fix test by creating empty archive instead of empty file
Wed, Dec 7, 11:50 AM · Restricted Project, Restricted Project

Mon, Dec 5

lamb-j committed rG6b992bcce0c5: [Driver][test] Fix test by creating empty archive instead of empty file (authored by lamb-j).
[Driver][test] Fix test by creating empty archive instead of empty file
Mon, Dec 5, 3:43 PM · Restricted Project, Restricted Project
lamb-j closed D137275: [Driver][test] Fix test by creating empty archive instead of empty file.
Mon, Dec 5, 3:43 PM · Restricted Project, Restricted Project

Tue, Nov 29

lamb-j abandoned D137175: [Driver][test] Remove one more obselete REQUIRES: clang-driver.
Tue, Nov 29, 12:15 PM · Restricted Project, Restricted Project

Nov 2 2022

lamb-j requested review of D137275: [Driver][test] Fix test by creating empty archive instead of empty file.
Nov 2 2022, 11:14 AM · Restricted Project, Restricted Project

Nov 1 2022

lamb-j requested review of D137175: [Driver][test] Remove one more obselete REQUIRES: clang-driver.
Nov 1 2022, 10:16 AM · Restricted Project, Restricted Project

Aug 12 2022

Herald added a project to D78058: option to write files to memory instead of disk: Restricted Project.
Aug 12 2022, 2:13 PM · Restricted Project, Restricted Project

Jul 27 2022

lamb-j committed rG0f3f357e26cf: [clang-offload-bundler] Library-ize ClangOffloadBundler (authored by lamb-j).
[clang-offload-bundler] Library-ize ClangOffloadBundler
Jul 27 2022, 12:04 PM · Restricted Project, Restricted Project
lamb-j closed D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler.
Jul 27 2022, 12:03 PM · Restricted Project, Restricted Project

Jul 26 2022

lamb-j updated the diff for D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler.

Updating driver cmake to correctly build shared library

Jul 26 2022, 5:12 PM · Restricted Project, Restricted Project
lamb-j reopened D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler.
Jul 26 2022, 5:12 PM · Restricted Project, Restricted Project
lamb-j committed rG8348c4095600: [clang-offload-bundler] Library-ize ClangOffloadBundler (authored by lamb-j).
[clang-offload-bundler] Library-ize ClangOffloadBundler
Jul 26 2022, 10:07 AM · Restricted Project, Restricted Project
lamb-j closed D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler.
Jul 26 2022, 10:06 AM · Restricted Project, Restricted Project

Jul 25 2022

lamb-j updated the diff for D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler.

Removing trailing whitespace

Jul 25 2022, 5:59 PM · Restricted Project, Restricted Project

Jul 22 2022

lamb-j updated the diff for D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler.

Fixing header typo

Jul 22 2022, 12:36 PM · Restricted Project, Restricted Project
lamb-j updated the diff for D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler.

Switching pointers to references, adding namespace comment

Jul 22 2022, 12:34 PM · Restricted Project, Restricted Project

Jul 19 2022

lamb-j updated the diff for D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler.

Bug fix

Jul 19 2022, 10:23 AM · Restricted Project, Restricted Project
lamb-j updated the diff for D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler.

Moving classes into clang namespace, more specific name for config class

Jul 19 2022, 10:13 AM · Restricted Project, Restricted Project

Jul 15 2022

lamb-j added reviewers for D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler: yaxunl, kzhuravl.
Jul 15 2022, 9:14 AM · Restricted Project, Restricted Project
lamb-j abandoned D129305: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (4/4).

Abandoned in favor of combined patch: https://reviews.llvm.org/D129873

Jul 15 2022, 9:11 AM · Restricted Project, Restricted Project
lamb-j abandoned D129304: [clang-offload-bundler] Library-ize ClangOffloadBundler (3/4).

Abandoned in favor of combined patch: https://reviews.llvm.org/D129873

Jul 15 2022, 9:11 AM · Restricted Project, Restricted Project
lamb-j abandoned D129303: [clang-offload-bundler] Library-ize ClangOffloadBundler (2/4).

Abandoned in favor of combined patch: https://reviews.llvm.org/D129873

Jul 15 2022, 9:11 AM · Restricted Project, Restricted Project
lamb-j abandoned D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4).

Abandoned in favor of combined patch: https://reviews.llvm.org/D129873

Jul 15 2022, 9:10 AM · Restricted Project, Restricted Project
lamb-j requested review of D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler.
Jul 15 2022, 9:09 AM · Restricted Project, Restricted Project

Jul 7 2022

lamb-j added a comment to D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4).

@yaxunl Are you recommending I combine all 4 patches down into 1 patch? Or combine a subset of patches?

Jul 7 2022, 6:58 PM · Restricted Project, Restricted Project
lamb-j requested review of D129305: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (4/4).
Jul 7 2022, 9:24 AM · Restricted Project, Restricted Project
lamb-j requested review of D129304: [clang-offload-bundler] Library-ize ClangOffloadBundler (3/4).
Jul 7 2022, 9:22 AM · Restricted Project, Restricted Project
lamb-j requested review of D129303: [clang-offload-bundler] Library-ize ClangOffloadBundler (2/4).
Jul 7 2022, 9:19 AM · Restricted Project, Restricted Project
lamb-j updated the diff for D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4).

Adding clang-format

Jul 7 2022, 9:15 AM · Restricted Project, Restricted Project
lamb-j requested review of D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4).
Jul 7 2022, 9:12 AM · Restricted Project, Restricted Project
lamb-j abandoned D129300: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (4/4).
Jul 7 2022, 9:11 AM · Restricted Project, Restricted Project
lamb-j requested review of D129300: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (4/4).
Jul 7 2022, 9:10 AM · Restricted Project, Restricted Project
lamb-j abandoned D129258: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (4/4).
Jul 7 2022, 12:56 AM · Restricted Project, Restricted Project
lamb-j requested review of D129258: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (4/4).
Jul 7 2022, 12:53 AM · Restricted Project, Restricted Project

Jun 7 2022

Herald added a project to D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives: Restricted Project.
Jun 7 2022, 11:23 PM · Restricted Project, Restricted Project

Apr 21 2022

lamb-j committed rGafcc6baac52f: [clang][HIP] Updating driver to enable archive/bitcode to bitcode linking when… (authored by lamb-j).
[clang][HIP] Updating driver to enable archive/bitcode to bitcode linking when…
Apr 21 2022, 9:25 AM · Restricted Project, Restricted Project
lamb-j closed D124151: [clang][HIP] Updating driver to enable archive/bitcode to bitcode linking when targeting HIPAMD toolchain.
Apr 21 2022, 9:24 AM · Restricted Project, Restricted Project
lamb-j updated the diff for D124151: [clang][HIP] Updating driver to enable archive/bitcode to bitcode linking when targeting HIPAMD toolchain.

Adding clang-format

Apr 21 2022, 12:13 AM · Restricted Project, Restricted Project
lamb-j updated the diff for D124151: [clang][HIP] Updating driver to enable archive/bitcode to bitcode linking when targeting HIPAMD toolchain.

Adding clang-format

Apr 21 2022, 12:11 AM · Restricted Project, Restricted Project
lamb-j requested review of D124151: [clang][HIP] Updating driver to enable archive/bitcode to bitcode linking when targeting HIPAMD toolchain.
Apr 21 2022, 12:09 AM · Restricted Project, Restricted Project

Mar 23 2022

lamb-j committed rG71b162c4bdf7: [AMDGPU][LLD] Adding support for ABI version 5 option (authored by lamb-j).
[AMDGPU][LLD] Adding support for ABI version 5 option
Mar 23 2022, 1:23 AM · Restricted Project
lamb-j closed D122190: [AMDGPU][LLD] Adding support for ABI version 5 option.
Mar 23 2022, 1:22 AM · Restricted Project, Restricted Project

Mar 22 2022

lamb-j updated the diff for D122190: [AMDGPU][LLD] Adding support for ABI version 5 option.

Switching test

Mar 22 2022, 4:50 PM · Restricted Project, Restricted Project
lamb-j updated the diff for D122190: [AMDGPU][LLD] Adding support for ABI version 5 option.

Adding test

Mar 22 2022, 1:56 PM · Restricted Project, Restricted Project

Mar 21 2022

lamb-j updated the diff for D122190: [AMDGPU][LLD] Adding support for ABI version 5 option.

Updating commit message

Mar 21 2022, 2:58 PM · Restricted Project, Restricted Project
lamb-j requested review of D122190: [AMDGPU][LLD] Adding support for ABI version 5 option.
Mar 21 2022, 2:57 PM · Restricted Project, Restricted Project

Mar 7 2022

lamb-j committed rG5160447f5844: [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count (authored by lamb-j).
[AMDGPU] Add gfx10 assembler directive to specify shared VGPR count
Mar 7 2022, 2:35 PM · Restricted Project
lamb-j closed D105507: [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count.
Mar 7 2022, 2:35 PM · Restricted Project, Restricted Project

Feb 22 2022

lamb-j updated the diff for D105507: [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count.

Addressing clang-format comments

Feb 22 2022, 11:51 AM · Restricted Project, Restricted Project

Feb 16 2022

lamb-j committed rG7470244475f8: [AMDGPU] Add agpr_count to metadata and AsmParser (authored by lamb-j).
[AMDGPU] Add agpr_count to metadata and AsmParser
Feb 16 2022, 3:18 PM
lamb-j closed D116140: [AMDGPU] Add agpr_count to metadata and AsmParser.
Feb 16 2022, 3:17 PM · Restricted Project
lamb-j updated the diff for D105507: [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count.

Address clang-format comment

Feb 16 2022, 1:18 PM · Restricted Project, Restricted Project
lamb-j updated the diff for D116140: [AMDGPU] Add agpr_count to metadata and AsmParser.

Updating commit message

Feb 16 2022, 12:25 PM · Restricted Project
lamb-j updated the diff for D116140: [AMDGPU] Add agpr_count to metadata and AsmParser.

Switching to use new getTotalNumVGPRs from AMDGPUBaseInfo

Feb 16 2022, 12:23 PM · Restricted Project
lamb-j committed rG0bad7cb56526: Hoist getTotalNumVGPRs into AMDGPUBaseInfo for use in both codegen and MC (authored by lamb-j).
Hoist getTotalNumVGPRs into AMDGPUBaseInfo for use in both codegen and MC
Feb 16 2022, 11:08 AM
lamb-j closed D119912: Hoist getTotalNumVGPRs into AMDGPUBaseInfo for use in both codegen and MC.
Feb 16 2022, 11:08 AM · Restricted Project
lamb-j updated the diff for D119912: Hoist getTotalNumVGPRs into AMDGPUBaseInfo for use in both codegen and MC.

Updating commit message

Feb 16 2022, 10:38 AM · Restricted Project
lamb-j updated the diff for D119912: Hoist getTotalNumVGPRs into AMDGPUBaseInfo for use in both codegen and MC.

Fix small formatting error

Feb 16 2022, 9:51 AM · Restricted Project
lamb-j updated the diff for D119912: Hoist getTotalNumVGPRs into AMDGPUBaseInfo for use in both codegen and MC.

Removing llvm namespace from function call and addressing clang-format issues

Feb 16 2022, 9:47 AM · Restricted Project

Feb 15 2022

lamb-j requested review of D119912: Hoist getTotalNumVGPRs into AMDGPUBaseInfo for use in both codegen and MC.
Feb 15 2022, 7:12 PM · Restricted Project

Feb 8 2022

lamb-j updated the diff for D105507: [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count.

Adding revision info to commit message

Feb 8 2022, 2:17 PM · Restricted Project, Restricted Project
lamb-j updated the diff for D105507: [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count.

Clarifying description

Feb 8 2022, 2:16 PM · Restricted Project, Restricted Project

Feb 1 2022

lamb-j updated the diff for D116140: [AMDGPU] Add agpr_count to metadata and AsmParser.

Fixing MCSymbol const declaration formatting

Feb 1 2022, 7:43 PM · Restricted Project
lamb-j committed rGa24ff176a688: [AMDGPU][NFC] Fixing formatting (authored by lamb-j).
[AMDGPU][NFC] Fixing formatting
Feb 1 2022, 6:01 PM
lamb-j closed D117801: [AMDGPU] Move const qualifier placement in AsmParser.
Feb 1 2022, 6:01 PM · Restricted Project
lamb-j updated the diff for D117801: [AMDGPU] Move const qualifier placement in AsmParser.

Updating commit message

Feb 1 2022, 4:55 PM · Restricted Project
lamb-j updated the diff for D117801: [AMDGPU] Move const qualifier placement in AsmParser.

Reverting code changes but keeping updated formatting to fix build error (see previous comment)

Feb 1 2022, 2:13 PM · Restricted Project
lamb-j updated the diff for D117801: [AMDGPU] Move const qualifier placement in AsmParser.

Reformatting (clang-format suggestion)

Feb 1 2022, 11:43 AM · Restricted Project
lamb-j requested review of D105507: [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count.
Feb 1 2022, 9:26 AM · Restricted Project, Restricted Project
lamb-j requested review of D117801: [AMDGPU] Move const qualifier placement in AsmParser.
Feb 1 2022, 9:25 AM · Restricted Project

Jan 31 2022

lamb-j added inline comments to D105507: [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count.
Jan 31 2022, 7:08 PM · Restricted Project, Restricted Project
lamb-j updated the diff for D105507: [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count.

Removing accidental print statement and fixing formatting

Jan 31 2022, 7:06 PM · Restricted Project, Restricted Project
lamb-j updated the diff for D105507: [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count.

Removing extra newline

Jan 31 2022, 6:59 PM · Restricted Project, Restricted Project
lamb-j retitled D105507: [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count from AMDGPU: Add gfx10 assembler directive to specify shared VGPR count to [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count.
Jan 31 2022, 6:57 PM · Restricted Project, Restricted Project
lamb-j updated the diff for D105507: [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count.

Updating description to match hardware description, adding appropriate checks

Jan 31 2022, 6:56 PM · Restricted Project, Restricted Project

Jan 28 2022

lamb-j committed rGedf7e026a8b4: [clang][NFC] Fix Typo (authored by lamb-j).
[clang][NFC] Fix Typo
Jan 28 2022, 11:57 AM

Jan 25 2022

lamb-j updated the diff for D105507: [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count.

Adding checks for wavefront size and multiple of 8

Jan 25 2022, 12:52 PM · Restricted Project, Restricted Project

Jan 20 2022

lamb-j added a comment to D117801: [AMDGPU] Move const qualifier placement in AsmParser.

@rampitec @arsenm If I'm understanding correctly, moving const to the left of "MCSymbol *"' declares the object as const instead of the pointer. In this case, we get a compilation error on the following line:

Jan 20 2022, 3:28 PM · Restricted Project
lamb-j abandoned D117813: [AMDGPU] Move const qualifier placement in AsmParser.
Jan 20 2022, 11:05 AM · Restricted Project
lamb-j updated the diff for D117801: [AMDGPU] Move const qualifier placement in AsmParser.

Fixing whitespace

Jan 20 2022, 11:00 AM · Restricted Project
lamb-j requested review of D117813: [AMDGPU] Move const qualifier placement in AsmParser.
Jan 20 2022, 11:00 AM · Restricted Project
lamb-j retitled D117801: [AMDGPU] Move const qualifier placement in AsmParser from Remove unneeded const qualifiers from assembly parser to [AMDGPU] Move const qualifier placement in AsmParser.
Jan 20 2022, 10:28 AM · Restricted Project
lamb-j updated the diff for D117801: [AMDGPU] Move const qualifier placement in AsmParser.

Moved instead of removed const qualifiers

Jan 20 2022, 10:27 AM · Restricted Project
lamb-j requested review of D117801: [AMDGPU] Move const qualifier placement in AsmParser.
Jan 20 2022, 9:32 AM · Restricted Project
lamb-j added inline comments to D116140: [AMDGPU] Add agpr_count to metadata and AsmParser.
Jan 20 2022, 8:09 AM · Restricted Project

Jan 7 2022

lamb-j added inline comments to D105507: [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count.
Jan 7 2022, 1:39 PM · Restricted Project, Restricted Project
lamb-j updated the diff for D105507: [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count.

Add check for shared_vgpr_count exceeding next_free_vgpr

Jan 7 2022, 1:33 PM · Restricted Project, Restricted Project
lamb-j commandeered D105507: [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count.
Jan 7 2022, 1:32 PM · Restricted Project, Restricted Project

Dec 22 2021

lamb-j added inline comments to D116140: [AMDGPU] Add agpr_count to metadata and AsmParser.
Dec 22 2021, 10:27 AM · Restricted Project
lamb-j updated the diff for D116140: [AMDGPU] Add agpr_count to metadata and AsmParser.

Removing const from MCSymbol variable and creating fall through case for getTotalNumVgprs()

Dec 22 2021, 10:25 AM · Restricted Project

Dec 21 2021

lamb-j added reviewers for D116140: [AMDGPU] Add agpr_count to metadata and AsmParser: t-tye, kzhuravl, rampitec.
Dec 21 2021, 9:04 PM · Restricted Project
lamb-j requested review of D116140: [AMDGPU] Add agpr_count to metadata and AsmParser.
Dec 21 2021, 8:58 PM · Restricted Project

Sep 21 2021

lamb-j closed D109991: [AMDGPU] NFC to correct typos in lib/Target/AMDGPU/AMDGPU*.cpp files. Test commit for new contributor..
Sep 21 2021, 2:09 PM · Restricted Project

Sep 20 2021

lamb-j committed rGdc6e8dfdfe7e: [AMDGPU][NFC] Correct typos in lib/Target/AMDGPU/AMDGPU*.cpp files. Test commit… (authored by lamb-j).
[AMDGPU][NFC] Correct typos in lib/Target/AMDGPU/AMDGPU*.cpp files. Test commit…
Sep 20 2021, 2:49 PM
lamb-j updated the diff for D109991: [AMDGPU] NFC to correct typos in lib/Target/AMDGPU/AMDGPU*.cpp files. Test commit for new contributor..

Addressing comments from kerbowa and lint tool.

Sep 20 2021, 2:36 PM · Restricted Project

Sep 17 2021

lamb-j requested review of D109991: [AMDGPU] NFC to correct typos in lib/Target/AMDGPU/AMDGPU*.cpp files. Test commit for new contributor..
Sep 17 2021, 11:50 AM · Restricted Project

Sep 16 2021

lamb-j committed rG4c1023b4b790: [AMDGPU] NFC: Fixing small spelling errors in AMDGPU header files (authored by lamb-j).
[AMDGPU] NFC: Fixing small spelling errors in AMDGPU header files
Sep 16 2021, 1:03 PM
lamb-j closed D109733: [AMDGPU] NFC: Fixing small spelling errors in AMDGPU header files.
Sep 16 2021, 1:03 PM · Restricted Project

Sep 13 2021

lamb-j updated the diff for D109733: [AMDGPU] NFC: Fixing small spelling errors in AMDGPU header files.

Adding clang-format to path for linting

Sep 13 2021, 7:51 PM · Restricted Project