This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC
ClosedPublic

Authored by qiucf on Feb 9 2022, 9:28 PM.

Details

Summary

The asserts are not included for bringing issue on cross-compiling.

Diff Detail

Event Timeline

qiucf created this revision.Feb 9 2022, 9:28 PM
qiucf requested review of this revision.Feb 9 2022, 9:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2022, 9:28 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
qiucf updated this revision to Diff 407444.Feb 10 2022, 2:44 AM
qiucf planned changes to this revision.Feb 13 2022, 9:05 AM

This breaks existing smm/tmm tests, will update/clean-up them before this.

qiucf updated this revision to Diff 409167.Feb 16 2022, 1:02 AM
qiucf edited the summary of this revision. (Show Details)

Rebase the fix.

jsji added inline comments.Feb 28 2022, 10:28 AM
clang/lib/Headers/ppc_wrappers/xmmintrin.h
1332

Can we have some pwr10 tests to test all these P10 specific codegen?

qiucf updated this revision to Diff 413336.Mar 6 2022, 9:29 PM

Add P10 tests.

Herald added a project: Restricted Project. · View Herald TranscriptMar 6 2022, 9:29 PM
jsji accepted this revision as: jsji.Mar 7 2022, 6:43 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Mar 7 2022, 6:43 AM
This revision was landed with ongoing or failed builds.Mar 24 2022, 5:07 AM
This revision was automatically updated to reflect the committed changes.
chapuni added a subscriber: chapuni.Jul 1 2022, 7:12 AM
chapuni added inline comments.
clang/lib/Headers/CMakeLists.txt
170

It doesn't contain <nmmintrin.h>, forgot?

shchenz added inline comments.Jul 10 2022, 5:28 PM
clang/lib/Headers/CMakeLists.txt
170

@qiucf Looks like an error here?

qiucf marked 2 inline comments as done.Aug 16 2023, 3:17 AM

Thanks, fixed by rG2459ed67805c. nmmintrin.h just includes smmintrin.h so it's not critical.