This is an archive of the discontinued LLVM Phabricator instance.

ReleaseNotes: add lld/ELF notes
ClosedPublic

Authored by MaskRay on Feb 9 2022, 12:04 AM.

Details

Summary

For the release/14.x branch.

Diff Detail

Event Timeline

MaskRay requested review of this revision.Feb 9 2022, 12:04 AM
MaskRay created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2022, 12:04 AM
MaskRay added inline comments.Feb 9 2022, 12:06 AM
lld/docs/ReleaseNotes.rst
44

Note this archive thing to improve performance and simplify symbol resolution.

(Note: mold already did this)

48

Note this .symtab thing to facilitate parallelism.

102

The warning change has not been made yet.

MaskRay added inline comments.Feb 9 2022, 12:08 AM
lld/docs/ReleaseNotes.rst
82

Perhaps: .o files compiled with and without `-mtls-dialect=gnu2` can now be linked together.

Some wording comments. I haven't been following LLD closely enough to be able to identify whether anything should/should not be documented in the release notes that isn't/is here though.

lld/docs/ReleaseNotes.rst
39
44

Given that this is only a "may", I might recommend changing "in the next release" to "in a future release".

61

I would suggest "is now run in parallel" instead of "is now parallel".

67–68
82

I'd use "object" or "objects" instead of ".o", as I feel the ".o" shortening doesn't feel right given the rest of the sentence is full prose. Concrete suggestion:

"i.e. mixing objects compiled with and without -mtls-dialect=gnu2 is now supported."

102–103

Again, not locking into a specific release in case things change/get delayed.

MaskRay updated this revision to Diff 407233.Feb 9 2022, 11:55 AM
MaskRay marked 5 inline comments as done.

thanks for the suggestions! applied

Looks good from a grammar point of view. I'll leave it to someone else for the technical side of things.

lld/docs/ReleaseNotes.rst
102–103

Any particular reason this hasn't been addressed (if you are 100% confident this is going in the next release, then it's fine, although I guess there's no guarantee that 15.0.0 will be the next release, if there's a sudden change in how LLVM versions things :-)

MaskRay added inline comments.Feb 10 2022, 12:24 AM
lld/docs/ReleaseNotes.rst
102–103

Thanks. https://reviews.llvm.org/D119108 has been pushed, so --[no-]define-common and -dp are definitely gone for 15.0.0 I'll keep the wording.

102–103

Forgot to push a comment I made several hours ago...

MaskRay marked 2 inline comments as done.Feb 14 2022, 11:17 AM

Pushed to release/14.x as https://github.com/llvm/llvm-project/commit/2f23d4b0ac0aba4629fa484264b4e5b52bf774ca
We can make incremental changes if needed.

MaskRay accepted this revision.Feb 14 2022, 11:17 AM
This revision is now accepted and ready to land.Feb 14 2022, 11:17 AM
MaskRay closed this revision.Feb 14 2022, 11:17 AM