For the release/14.x branch.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
lld/docs/ReleaseNotes.rst | ||
---|---|---|
82 | Perhaps: .o files compiled with and without `-mtls-dialect=gnu2` can now be linked together. |
Some wording comments. I haven't been following LLD closely enough to be able to identify whether anything should/should not be documented in the release notes that isn't/is here though.
lld/docs/ReleaseNotes.rst | ||
---|---|---|
39 | ||
44 | Given that this is only a "may", I might recommend changing "in the next release" to "in a future release". | |
61 | I would suggest "is now run in parallel" instead of "is now parallel". | |
67–68 | ||
82 | I'd use "object" or "objects" instead of ".o", as I feel the ".o" shortening doesn't feel right given the rest of the sentence is full prose. Concrete suggestion: "i.e. mixing objects compiled with and without -mtls-dialect=gnu2 is now supported." | |
102–103 | Again, not locking into a specific release in case things change/get delayed. |
Looks good from a grammar point of view. I'll leave it to someone else for the technical side of things.
lld/docs/ReleaseNotes.rst | ||
---|---|---|
102–103 | Any particular reason this hasn't been addressed (if you are 100% confident this is going in the next release, then it's fine, although I guess there's no guarantee that 15.0.0 will be the next release, if there's a sudden change in how LLVM versions things :-) |
lld/docs/ReleaseNotes.rst | ||
---|---|---|
102–103 | Thanks. https://reviews.llvm.org/D119108 has been pushed, so --[no-]define-common and -dp are definitely gone for 15.0.0 I'll keep the wording. | |
102–103 | Forgot to push a comment I made several hours ago... |
Pushed to release/14.x as https://github.com/llvm/llvm-project/commit/2f23d4b0ac0aba4629fa484264b4e5b52bf774ca
We can make incremental changes if needed.