Fix some typos in the amdgpu backend.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| llvm/lib/Target/AMDGPU/MIMGInstructions.td | ||
|---|---|---|
| 229 ↗ | (On Diff #406778) | This ones seems like a legitimate use of "that that". |
| llvm/lib/Target/AMDGPU/R600ClauseMergePass.cpp | ||
| 10 | Should be "manner". | |
| llvm/lib/Target/AMDGPU/R600InstrInfo.cpp | ||
| 853 ↗ | (On Diff #406778) | No, we're talking about predication so "unpredicable" is correct. |
| llvm/lib/Target/AMDGPU/SIInstrInfo.cpp | ||
| 2958 | This one doesn't seem particularly wrong. | |
| llvm/lib/Target/AMDGPU/SIMachineScheduler.cpp | ||
| 94 | There is no typo fix here? | |
| llvm/lib/Target/AMDGPU/SIPeepholeSDWA.cpp | ||
| 1143 | No typo fixes here? | |
| llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp | ||
| 972 | Should probably be "inactive"? Or perhaps "deactivated"? | |
Thanks! Fixed your comments
| llvm/lib/Target/AMDGPU/R600InstrInfo.cpp | ||
|---|---|---|
| 853 ↗ | (On Diff #406778) | Ups, I didn’t predict that. |
| llvm/lib/Target/AMDGPU/SIMachineScheduler.cpp | ||
| 94 | True, I guess clang-format just formatted the whole comment, not only the changed line. (The lines were longer than 80 chars) | |
| llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp | ||
|---|---|---|
| 980 | I am not entirely sure what I meant by these comments, but protocol the first word is not meant to be a verb. // Demote - deactivate quads with only helper lanes // Kill - deactivate lanes no longer in live mask | |
Should be "manner".