This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][NFC] Fix typos
ClosedPublic

Authored by sebastian-ne on Feb 8 2022, 5:07 AM.

Details

Summary

Fix some typos in the amdgpu backend.

Diff Detail

Event Timeline

sebastian-ne created this revision.Feb 8 2022, 5:07 AM
sebastian-ne requested review of this revision.Feb 8 2022, 5:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2022, 5:08 AM

Two more typos

foad added inline comments.Feb 8 2022, 5:22 AM
llvm/lib/Target/AMDGPU/MIMGInstructions.td
229 ↗(On Diff #406778)

This ones seems like a legitimate use of "that that".

llvm/lib/Target/AMDGPU/R600ClauseMergePass.cpp
10

Should be "manner".

llvm/lib/Target/AMDGPU/R600InstrInfo.cpp
853 ↗(On Diff #406778)

No, we're talking about predication so "unpredicable" is correct.

llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
2958

This one doesn't seem particularly wrong.

llvm/lib/Target/AMDGPU/SIMachineScheduler.cpp
94

There is no typo fix here?

llvm/lib/Target/AMDGPU/SIPeepholeSDWA.cpp
1143

No typo fixes here?

llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp
972

Should probably be "inactive"? Or perhaps "deactivated"?

sebastian-ne marked 4 inline comments as done.

Thanks! Fixed your comments

llvm/lib/Target/AMDGPU/R600InstrInfo.cpp
853 ↗(On Diff #406778)

Ups, I didn’t predict that.

llvm/lib/Target/AMDGPU/SIMachineScheduler.cpp
94

True, I guess clang-format just formatted the whole comment, not only the changed line. (The lines were longer than 80 chars)
Is it fine to leave these changes in the patch?

foad added a subscriber: critson.Feb 8 2022, 5:49 AM
foad added inline comments.
llvm/lib/Target/AMDGPU/SIMachineScheduler.cpp
94

Yes, OK.

llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp
980

On second thoughts maybe "deactivated" was intended? And it needs to be fixed here too. @critson I think you wrote these comments.

critson added inline comments.Feb 10 2022, 12:56 AM
llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp
980

I am not entirely sure what I meant by these comments, but protocol the first word is not meant to be a verb.
The two comments are probably meant to read:

// Demote - deactivate quads with only helper lanes

// Kill - deactivate lanes no longer in live mask

sebastian-ne marked an inline comment as done.

Improve WQM comment

friendly ping for review

foad accepted this revision.Feb 18 2022, 5:53 AM

LGTM, thanks.

This revision is now accepted and ready to land.Feb 18 2022, 5:53 AM
This revision was landed with ongoing or failed builds.Feb 18 2022, 6:05 AM
This revision was automatically updated to reflect the committed changes.