This is an archive of the discontinued LLVM Phabricator instance.

Differential D119149

[test][llvm-objcopy/mac] Move test to new file
ClosedPublic

Authored by keith on Feb 7 2022, 9:01 AM.

Details

Reviewers
alexander-shaposhnikov
rupprecht
jhenderson
Commits
rGc4ac46b95d7c: [test][llvm-objcopy/mac] Move test to new file
Summary

Follow up from https://reviews.llvm.org/D118526

Diff Detail

Unit TestsFailed

TimeTest
60,140 msx64 debian > MLIR.Examples/standalone::test.toy
60,060 msx64 debian > libFuzzer.libFuzzer::large.test
60,170 msx64 debian > lld.COFF::incremental.test

Event Timeline

keith created this revision.Feb 7 2022, 9:01 AM
Herald added a reviewer: rupprecht. · View Herald TranscriptFeb 7 2022, 9:01 AM
Herald added a reviewer: jhenderson. · View Herald Transcript
Herald added a subscriber: abrachet. · View Herald Transcript
keith requested review of this revision.Feb 7 2022, 9:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2022, 9:01 AM
Herald added subscribers: llvm-commits, MaskRay. · View Herald Transcript
keith mentioned this in D118526: [llvm-objcopy][MachO] Ignore LC_LINKER_OPTION when redefining symbols.Feb 7 2022, 9:02 AM
smeenai added a subscriber: smeenai.Feb 7 2022, 10:08 AM

You'll wanna check that the input and output of llvm-objcopy is identical (I believe the other tests use cmp for this).

Harbormaster completed remote builds in B148007: Diff 406489.Feb 7 2022, 10:09 AM
keith updated this revision to Diff 406615.Feb 7 2022, 2:43 PM

Add cmp to test

keith updated this revision to Diff 406619.Feb 7 2022, 2:44 PM

Fix local state false positive

alexander-shaposhnikov accepted this revision.Feb 7 2022, 6:13 PM

LGTM, thanks!

This revision is now accepted and ready to land.Feb 7 2022, 6:13 PM
Harbormaster completed remote builds in B148105: Diff 406619.Feb 7 2022, 6:53 PM
Closed by commit rGc4ac46b95d7c: [test][llvm-objcopy/mac] Move test to new file (authored by keith). · Explain WhyFeb 7 2022, 8:01 PM
This revision was automatically updated to reflect the committed changes.
keith added a commit: rGc4ac46b95d7c: [test][llvm-objcopy/mac] Move test to new file.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-objcopy/
MachO/
18 lines
1 line

Diff 406489

llvm/test/tools/llvm-objcopy/MachO/load-commands.yaml

  • This file was added.
--- !mach-o
FileHeader:
magic: 0xFEEDFACE
cputype: 0x0000000C
cpusubtype: 0x00000009
filetype: 0x00000001
ncmds: 1
sizeofcmds: 16
flags: 0x00002000
LoadCommands:
- cmd: LC_LINKER_OPTION
cmdsize: 16
count: 1
PayloadBytes: [ 0x2D, 0x6C, 0x63, 0x0 ]
...
# RUN: yaml2obj %s > %t
# RUN: llvm-objcopy %t %t.copied

llvm/test/tools/llvm-objcopy/MachO/redefine-symbol.s

Show All 37 Lines
# RUN: llvm-readobj --symbols %t.notstripped | FileCheck %s --check-prefix=NOTSTRIPPED # RUN: llvm-readobj --symbols %t.notstripped | FileCheck %s --check-prefix=NOTSTRIPPED
# NOTSTRIPPED: Name: _ba # NOTSTRIPPED: Name: _ba
# NOTSTRIPPED: Name: _func # NOTSTRIPPED: Name: _func
## FIXME: _ba should be stripped after --strip-symbol is implemented. ## FIXME: _ba should be stripped after --strip-symbol is implemented.
# RUN: llvm-objcopy --strip-symbol _ba --redefine-sym _foo=_ba %t %t.noba # RUN: llvm-objcopy --strip-symbol _ba --redefine-sym _foo=_ba %t %t.noba
# RUN: llvm-readobj --symbols %t.noba | FileCheck %s --check-prefix=NOTSTRIPPED # RUN: llvm-readobj --symbols %t.noba | FileCheck %s --check-prefix=NOTSTRIPPED
.linker_option "-lc"
.globl _func .globl _func
_func: _func:
.section __TEXT,__const .section __TEXT,__const
.globl _foo .globl _foo
_foo: _foo: