This is an archive of the discontinued LLVM Phabricator instance.

Cleanup LLVMDebugInfoCodeView headers
ClosedPublic

Authored by serge-sans-paille on Feb 6 2022, 12:59 PM.

Details

Summary

Major user-facing changes:

Many headers in llvm/DebugInfo/CodeView no longer include
llvm/Support/BinaryStreamReader.h or llvm/Support/BinaryStreamWriter.h,
those headers may need to be included manually.

Several headers in llvm/DebugInfo/CodeView no longer include
llvm/DebugInfo/CodeView/EnumTables.h or llvm/DebugInfo/CodeView/CodeView.h,
those headers may need to be included manually.

Some statistics:
$ clang++ -E -Iinclude -I../llvm/include ../llvm/lib/DebugInfo/CodeView/*.cpp -std=c++14 -fno-rtti -fno-exceptions | wc -l
after: 2794466
before: 2832765

Discourse thread on the topic: https://discourse.llvm.org/t/include-what-you-use-include-cleanup/

Diff Detail

Event Timeline

serge-sans-paille requested review of this revision.Feb 6 2022, 12:59 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 6 2022, 12:59 PM
RKSimon added inline comments.Feb 6 2022, 1:27 PM
llvm/include/llvm/DebugInfo/CodeView/CVTypeVisitor.h
12

Forward declare ArrayRef<> ?

MaskRay accepted this revision.Feb 7 2022, 11:20 PM

LGTM.

This revision is now accepted and ready to land.Feb 7 2022, 11:20 PM
This revision was landed with ongoing or failed builds.Feb 8 2022, 7:01 AM
This revision was automatically updated to reflect the committed changes.