This is an archive of the discontinued LLVM Phabricator instance.

Differential D119068

[libunwind] Define _Unwind_Backtrace for powerpc, sparc
ClosedPublic

Authored by thesamesam on Feb 5 2022, 9:15 PM.

Details

Reviewers
koakuma
MaskRay
Arfrever
Group Reviewers
Restricted Project
Commits
rG022011078054: [libunwind] Define _Unwind_Backtrace for powerpc, sparc
Summary

Add SPARC to the list of platforms for which we provide a full
unwind implementation which leads to _Unwind_Backtrace being defined within
libunwind.so.

Likewise for PPC (see D118320 for background).

Diff Detail

Event Timeline

thesamesam created this revision.Feb 5 2022, 9:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2022, 9:15 PM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
Herald added subscribers: libcxx-commits, luke957, s.egerton and 3 others. · View Herald Transcript
thesamesam requested review of this revision.Feb 5 2022, 9:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2022, 9:15 PM
Herald added subscribers: llvm-commits, • pcwang-thead. · View Herald Transcript
Harbormaster completed remote builds in B147800: Diff 406226.Feb 5 2022, 10:09 PM
Arfrever added a comment.Feb 5 2022, 10:39 PM

During investigation for D118320, it was found that:

  • GCC on PPC32 defines __powerpc__, but not __ppc__ (Clang on PPC32 defines both)
  • GCC on PPC64 defines both __powerpc__ and __powerpc64__ (Clang on PPC64 defines both)

So problem with functions such as _Unwind_Backtrace not being available is probably also present in libunwind built by GCC on PPC32.
Then defined(__ppc__) || defined(__ppc64__) || defined(__powerpc64__) could be merged into simple defined(__powerpc__).

thesamesam updated this revision to Diff 406231.Feb 5 2022, 11:03 PM

Fix similar issue for PPC32.

thesamesam retitled this revision from [libunwind] [sparc] Define _Unwind_Backtrace to [libunwind] Define _Unwind_Backtrace for powerpc, sparc.Feb 5 2022, 11:04 PM
thesamesam edited the summary of this revision. (Show Details)
Herald added subscribers: shchenz, nemanjai. · View Herald TranscriptFeb 5 2022, 11:04 PM
Arfrever accepted this revision.Feb 5 2022, 11:14 PM
Harbormaster completed remote builds in B147804: Diff 406231.Feb 5 2022, 11:58 PM
MaskRay accepted this revision.Feb 7 2022, 1:01 AM

LGTM.

This revision is now accepted and ready to land.Feb 7 2022, 1:01 AM
koakuma added a comment.Feb 7 2022, 6:03 AM

Looks okay here too check-unwind tests passes and _Unwind_Backtrace seems to work on Gentoo/sparc64, at least.

[100%] Running libunwind tests
-- Testing: 11 tests, 11 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..

Testing Time: 1.82s
  Unsupported: 4
  Passed     : 7
[100%] Built target check-unwind
Closed by commit rG022011078054: [libunwind] Define _Unwind_Backtrace for powerpc, sparc (authored by thesamesam, committed by MaskRay). · Explain WhyFeb 7 2022, 9:37 AM
This revision was automatically updated to reflect the committed changes.
MaskRay added a commit: rG022011078054: [libunwind] Define _Unwind_Backtrace for powerpc, sparc.

Revision Contents

PathSize
libunwind/
src/
11 lines

Diff 406231

libunwind/src/config.h

Show First 20 Lines • Show All 103 Lines • ▼ Show 20 Lines
#if (defined(__APPLE__) && defined(__arm__)) || defined(__USING_SJLJ_EXCEPTIONS__) #if (defined(__APPLE__) && defined(__arm__)) || defined(__USING_SJLJ_EXCEPTIONS__)
#define _LIBUNWIND_BUILD_SJLJ_APIS #define _LIBUNWIND_BUILD_SJLJ_APIS
#endif #endif
#if defined(__i386__) || defined(__x86_64__) || defined(__powerpc__) #if defined(__i386__) || defined(__x86_64__) || defined(__powerpc__)
#define _LIBUNWIND_SUPPORT_FRAME_APIS #define _LIBUNWIND_SUPPORT_FRAME_APIS
#endif #endif
#if defined(__i386__) || defined(__x86_64__) || \ #if defined(__i386__) || defined(__x86_64__) || defined(__powerpc__) || \
defined(__ppc__) || defined(__ppc64__) || defined(__powerpc64__) || \ (!defined(__APPLE__) && defined(__arm__)) || defined(__aarch64__) || \
(!defined(__APPLE__) && defined(__arm__)) || \ defined(__mips__) || defined(__riscv) || defined(__hexagon__) || \
defined(__aarch64__) || \ defined(__sparc__)
defined(__mips__) || \
defined(__riscv) || \
defined(__hexagon__)
#if !defined(_LIBUNWIND_BUILD_SJLJ_APIS) #if !defined(_LIBUNWIND_BUILD_SJLJ_APIS)
#define _LIBUNWIND_BUILD_ZERO_COST_APIS #define _LIBUNWIND_BUILD_ZERO_COST_APIS
#endif #endif
#endif #endif
#ifndef _LIBUNWIND_REMEMBER_HEAP_ALLOC #ifndef _LIBUNWIND_REMEMBER_HEAP_ALLOC
#if defined(_LIBUNWIND_REMEMBER_STACK_ALLOC) || defined(__APPLE__) || \ #if defined(_LIBUNWIND_REMEMBER_STACK_ALLOC) || defined(__APPLE__) || \
defined(__linux__) || defined(__ANDROID__) || defined(__MINGW32__) || \ defined(__linux__) || defined(__ANDROID__) || defined(__MINGW32__) || \
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines