[PS4] Make __BIGGEST_ALIGNMENT__ 32bytes

[ychen]

Summary

So it matches __STDCPP_DEFAULT_NEW_ALIGNMENT__.

[aaron.ballman]

LGTM as far as the changes go (I can't speak to how appropriate the changes are for the PS4 target).

[ychen]

@aaron.ballman Thanks for taking a look.
@probinson Gentle ping..

[probinson]

LGTM, sorry I missed this!

[ychen]

@probinson Thanks. No worries. I should've pinged earlier.

clang/include/clang/Basic/TargetInfo.h

struct TransferrableTargetInfo {
   // For simplicity, the fractional bits in a _Fract type will be one less the
   // width of that _Fract type. This leaves all signed _Fract types having no
   // padding and unsigned _Fract types will only have 1 bit of padding after the
   // sign if PaddingOnUnsignedFixedPoint is set.
   unsigned char ShortAccumScale;
   unsigned char AccumScale;
   unsigned char LongAccumScale;
 
-  unsigned char SuitableAlign;
   unsigned char DefaultAlignForAttributeAligned;
   unsigned char MinGlobalAlign;
 
+  unsigned short SuitableAlign;
   unsigned short NewAlign;
   unsigned MaxVectorAlign;
   unsigned MaxTLSAlign;
 
   const llvm::fltSemantics *HalfFormat, *BFloat16Format, *FloatFormat,
       *DoubleFormat, *LongDoubleFormat, *Float128Format, *Ibm128Format;
 
   ///===---- Target Data Type Query Methods -------------------------------===//

clang/lib/Basic/Targets/OSTargets.h

PS4OSTargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
     // as in "__attribute__((aligned(2))) int b : 1;".
     this->UseExplicitBitFieldAlignment = false;
 
     switch (Triple.getArch()) {
     default:
     case llvm::Triple::x86_64:
       this->MCountName = ".mcount";
       this->NewAlign = 256;
+      this->SuitableAlign = 256;
       break;
     }
   }
   TargetInfo::CallingConvCheckResult
   checkCallingConvention(CallingConv CC) const override {
     return (CC == CC_C) ? TargetInfo::CCCR_OK : TargetInfo::CCCR_Error;
   }
 };

clang/test/Preprocessor/init.c

 // TCE:#define __WINT_WIDTH__ 32
 // TCE:#define __tce 1
 // TCE:#define __tce__ 1
 // TCE:#define tce 1
 //
 // RUN: %clang_cc1 -E -dM -ffreestanding -fgnuc-version=4.2.1 -triple=x86_64-scei-ps4 < /dev/null | FileCheck -match-full-lines -check-prefix PS4 %s
 //
 // PS4:#define _LP64 1
+// PS4:#define __BIGGEST_ALIGNMENT__ 32
 // PS4:#define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__
 // PS4:#define __CHAR16_TYPE__ unsigned short
 // PS4:#define __CHAR32_TYPE__ unsigned int
 // PS4:#define __CHAR_BIT__ 8
 // PS4:#define __DBL_DENORM_MIN__ 4.9406564584124654e-324
 // PS4:#define __DBL_DIG__ 15
 // PS4:#define __DBL_EPSILON__ 2.2204460492503131e-16
 // PS4:#define __DBL_HAS_DENORM__ 1