This started breaking in the CI because we bumped the Clang version to 15, which requires adjusting the markup in the test suite.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
libcxx/test/std/utilities/tuple/tuple.tuple/tuple.assign/convert_copy.pass.cpp | ||
---|---|---|
9 | Pre-existing: Please update the URL to llvm.org/PR45879 |
Oh, thanks, I was literally going to land the same change! I assume you noticed the Bootstrapping build was failing?
@haowei Just for the sake of the process, in the future, please try to follow the libc++ review guidelines and wait for the libc++ review group to be green before committing. You can always ping us on Discord if you're missing some approvals on a simple (and time critical) change like this, and we'll be happy to take a look quickly. Thanks for the patch!
Oh, sorry I will follow the guideline next time. I thought the review process were the same.
I saw breakages on Fuchsia's clang linux builders due this test after the version was bumped to 15. And I found it out this test was broken since clang-13. So I just added clang-15 since the underlying bug was not yet fixed.
I think the problem is that this test was banned in clang-13 already but the underlying bug was never fixed. So whenever you bump the clang version number, if this file was not updated, it will fail again. We might want to fix the underlying bug so we don't have to add another exception here each time the version was bumped.
Pre-existing: Please update the URL to llvm.org/PR45879