This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Add UNSUPPORTED for clang-15
ClosedPublic

Authored by haowei on Feb 2 2022, 12:20 PM.

Details

Summary

This started breaking in the CI because we bumped the Clang version to 15, which requires adjusting the markup in the test suite.

Diff Detail

Event Timeline

haowei requested review of this revision.Feb 2 2022, 12:20 PM
haowei created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2022, 12:20 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
haowei edited the summary of this revision. (Show Details)Feb 2 2022, 12:20 PM
abrachet accepted this revision.Feb 2 2022, 12:23 PM
philnik accepted this revision as: philnik.Feb 2 2022, 12:28 PM
philnik added a subscriber: philnik.
philnik added inline comments.
libcxx/test/std/utilities/tuple/tuple.tuple/tuple.assign/convert_copy.pass.cpp
8–9

Pre-existing: Please update the URL to llvm.org/PR45879

haowei updated this revision to Diff 405388.Feb 2 2022, 12:31 PM
haowei marked an inline comment as done.
This revision was not accepted when it landed; it landed in state Needs Review.Feb 2 2022, 12:34 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
ldionne added a subscriber: ldionne.Feb 2 2022, 2:40 PM

Oh, thanks, I was literally going to land the same change! I assume you noticed the Bootstrapping build was failing?

@haowei Just for the sake of the process, in the future, please try to follow the libc++ review guidelines and wait for the libc++ review group to be green before committing. You can always ping us on Discord if you're missing some approvals on a simple (and time critical) change like this, and we'll be happy to take a look quickly. Thanks for the patch!

Is this something I should be updating when I bump the version in trunk?

haowei added a comment.Feb 2 2022, 2:46 PM

Oh, thanks, I was literally going to land the same change! I assume you noticed the Bootstrapping build was failing?

@haowei Just for the sake of the process, in the future, please try to follow the libc++ review guidelines and wait for the libc++ review group to be green before committing. You can always ping us on Discord if you're missing some approvals on a simple (and time critical) change like this, and we'll be happy to take a look quickly. Thanks for the patch!

Oh, sorry I will follow the guideline next time. I thought the review process were the same.

I saw breakages on Fuchsia's clang linux builders due this test after the version was bumped to 15. And I found it out this test was broken since clang-13. So I just added clang-15 since the underlying bug was not yet fixed.

haowei added a comment.Feb 2 2022, 2:48 PM

Is this something I should be updating when I bump the version in trunk?

I think the problem is that this test was banned in clang-13 already but the underlying bug was never fixed. So whenever you bump the clang version number, if this file was not updated, it will fail again. We might want to fix the underlying bug so we don't have to add another exception here each time the version was bumped.

Is this something I should be updating when I bump the version in trunk?

No, I don't think so. As @haowei said, we want to fix the underlying bug instead. It's actually good that it breaks every time, because it reminds us that this hasn't been fixed yet (and in this case I pinged D103395).

Oh, sorry I will follow the guideline next time. I thought the review process were the same.

Yup, no worries at all!