This is an archive of the discontinued LLVM Phabricator instance.

[NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX
ClosedPublic

Authored by stevewan on Jan 31 2022, 5:29 PM.

Details

Summary

These tests emit unexpected diagnostics on AIX because the byval alignment warning is emitted too aggressively. https://reviews.llvm.org/D118350 is supposed to provide a proper fix, but for the time being use -Wno-aix-compat to suppress the warning while keeping the coverage.

Diff Detail

Event Timeline

stevewan requested review of this revision.Jan 31 2022, 5:29 PM
stevewan created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2022, 5:29 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
clang/test/SemaTemplate/instantiate-attr.cpp
1–4

Add -Wno-aix-compat instead?

6–9

See above suggestion. Please try applying to the other tests too.

ZarkoCA added inline comments.Feb 1 2022, 4:42 AM
clang/test/SemaTemplate/instantiate-attr.cpp
1–4

I agree with this, this way AIX still gets the test coverage.

stevewan updated this revision to Diff 404947.Feb 1 2022, 8:29 AM

Use "-Wno-aix-compat" so that we don't lose coverage on AIX

stevewan edited the summary of this revision. (Show Details)Feb 1 2022, 8:30 AM
stevewan marked 3 inline comments as done.
clang/test/Analysis/padding_c.c
7

Even if it works as-is, might be good to add -Wno-aix-compat here too since -verify is being used.

clang/test/CXX/drs/dr6xx.cpp
1

Same comment (although the part that is affected is guarded for the newer language levels).

stevewan updated this revision to Diff 404951.Feb 1 2022, 8:46 AM

Add the flag to all

LGTM with minor comments.

This revision is now accepted and ready to land.Feb 1 2022, 8:46 AM
stevewan marked 2 inline comments as done.Feb 1 2022, 8:47 AM
This revision was landed with ongoing or failed builds.Feb 1 2022, 8:50 AM
This revision was automatically updated to reflect the committed changes.