[NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

[stevewan]

Summary

These tests emit unexpected diagnostics on AIX because the byval alignment warning is emitted too aggressively. https://reviews.llvm.org/D118350 is supposed to provide a proper fix, but for the time being use -Wno-aix-compat to suppress the warning while keeping the coverage.

[hubert.reinterpretcast]

clang/test/SemaTemplate/instantiate-attr.cpp

1

Add -Wno-aix-compat instead?

3–6

See above suggestion. Please try applying to the other tests too.

[ZarkoCA]

clang/test/SemaTemplate/instantiate-attr.cpp

1

I agree with this, this way AIX still gets the test coverage.

[stevewan]

Use "-Wno-aix-compat" so that we don't lose coverage on AIX

[hubert.reinterpretcast]

clang/test/Analysis/padding_c.c

5

Even if it works as-is, might be good to add -Wno-aix-compat here too since -verify is being used.

clang/test/CXX/drs/dr6xx.cpp

1–4

Same comment (although the part that is affected is guarded for the newer language levels).

[stevewan]

Add the flag to all

[hubert.reinterpretcast]

LGTM with minor comments.

clang/test/Analysis/padding_c.c

 // RUN: %clang_analyze_cc1 -verify %s \
 // RUN:   -analyzer-checker=optin.performance \
 // RUN:   -analyzer-config optin.performance.Padding:AllowedPad=2
 
 // RUN: not %clang_analyze_cc1 -verify %s \
 // RUN:   -analyzer-checker=core \
 // RUN:   -analyzer-checker=optin.performance.Padding \
 // RUN:   -analyzer-config optin.performance.Padding:AllowedPad=-10 \
 // RUN:   2>&1 | FileCheck %s -check-prefix=CHECK-PAD-NEGATIVE-VALUE
 
 // CHECK-PAD-NEGATIVE-VALUE: (frontend): invalid input for checker option
 // CHECK-PAD-NEGATIVE-VALUE-SAME: 'optin.performance.Padding:AllowedPad', that
 // CHECK-PAD-NEGATIVE-VALUE-SAME: expects a non-negative value
 
+// Byval alignment warning is emitted too aggressively on AIX.
+// XFAIL: aix
+
 #if __has_include(<stdalign.h>)
 #include <stdalign.h>
 #endif
 
 #if __has_include(<stdalign.h>) || defined(__cplusplus)
 // expected-warning@+1{{Excessive padding in 'struct FieldAttrAlign' (6 padding}}
 struct FieldAttrAlign {
   char c1;

clang/test/Analysis/padding_cpp.cpp

 // RUN: %clang_analyze_cc1 -std=c++14 -analyzer-checker=optin.performance -analyzer-config optin.performance.Padding:AllowedPad=2 -verify %s
 
+// Byval alignment warning is emitted too aggressively on AIX.
+// XFAIL: aix
+
 // Make sure that the C cases still work fine, even when compiled as C++.
 #include "padding_c.c"
 
 struct BigCharArray2 { // no-warning
   char c[129];
 };
 
 // xxxexpected-warning@+1{{Excessive padding in 'struct LowAlignmentBase'}}

clang/test/CXX/drs/dr6xx.cpp

 // RUN: %clang_cc1 -std=c++98 %s -verify -fexceptions -fcxx-exceptions -pedantic-errors -fno-spell-checking
 // RUN: %clang_cc1 -std=c++11 %s -verify -fexceptions -fcxx-exceptions -pedantic-errors -fno-spell-checking
 // RUN: %clang_cc1 -std=c++14 %s -verify -fexceptions -fcxx-exceptions -pedantic-errors -fno-spell-checking
 // RUN: %clang_cc1 -std=c++17 %s -verify -fexceptions -fcxx-exceptions -pedantic-errors -fno-spell-checking
 // RUN: %clang_cc1 -std=c++20 %s -verify -fexceptions -fcxx-exceptions -pedantic-errors -fno-spell-checking
 
+// Byval alignment warning is emitted too aggressively on AIX.
+// XFAIL: aix
+
 namespace std {
   struct type_info {};
   __extension__ typedef __SIZE_TYPE__ size_t;
 } // namespace std
 
 namespace dr601 { // dr601: yes
 #if __cplusplus >= 201103L
 #define MAX __LLONG_MAX__

clang/test/SemaTemplate/instantiate-attr.cpp

 // RUN: %clang_cc1 -fsyntax-only -verify %s
 // expected-no-diagnostics
+
+// Byval alignment warning is emitted too aggressively on AIX.
+// XFAIL: aix
+
 template <typename T>
 struct A {
   char a __attribute__((aligned(16)));
 
   struct B {
     typedef T __attribute__((aligned(16))) i16;
     i16 x;
   };