Page MenuHomePhabricator

[mlir] Move ComposeSubView+ExpandOps from Standard to MemRef
ClosedPublic

Authored by rriddle on Jan 26 2022, 2:18 PM.

Details

Summary

These transformations already operate on memref operations (as part of
splitting up the standard dialect). Now that the operations have moved,
it's time for these transformations to move as well.

Depends on D118280

Diff Detail

Event Timeline

rriddle created this revision.Jan 26 2022, 2:18 PM
rriddle requested review of this revision.Jan 26 2022, 2:18 PM
mehdi_amini accepted this revision.Jan 26 2022, 4:52 PM
This revision is now accepted and ready to land.Jan 26 2022, 4:52 PM
This revision was landed with ongoing or failed builds.Jan 26 2022, 11:20 PM
This revision was automatically updated to reflect the committed changes.

@rriddle You've broken the integration tests. Please test with MLIR_INCLUDE_INTEGRATION_TESTS:BOOL=ON or wait for the phab CI.

@rriddle You've broken the integration tests. Please test with MLIR_INCLUDE_INTEGRATION_TESTS:BOOL=ON or wait for the phab CI.

Ooops, let me fix that.

@rriddle You've broken the integration tests. Please test with MLIR_INCLUDE_INTEGRATION_TESTS:BOOL=ON or wait for the phab CI.

Ooops, let me fix that.

I've fixed it.

@rriddle You've broken the integration tests. Please test with MLIR_INCLUDE_INTEGRATION_TESTS:BOOL=ON or wait for the phab CI.

Ooops, let me fix that.

I've fixed it.

Thanks! Sorry about that, added integrations to my local build (lost it during a recent move it seems).