Page MenuHomePhabricator

[mlir] Move std.generic_atomic_rmw to the memref dialect
ClosedPublic

Authored by rriddle on Jan 25 2022, 6:42 PM.

Details

Summary

This is part of splitting up the standard dialect. The move makes sense anyways,
given that the memref dialect already holds memref.atomic_rmw which is the non-region
sibling operation of std.generic_atomic_rmw (the relationship is even more clear given
they have nearly the same description % how they represent the inner computation).

Diff Detail

Event Timeline

rriddle created this revision.Jan 25 2022, 6:42 PM
rriddle requested review of this revision.Jan 25 2022, 6:42 PM

LGTM, note you have a typo in the description: "compuation"

rriddle edited the summary of this revision. (Show Details)Jan 25 2022, 6:44 PM
mehdi_amini accepted this revision.Jan 26 2022, 10:28 AM
This revision is now accepted and ready to land.Jan 26 2022, 10:28 AM
rriddle updated this revision to Diff 403359.Jan 26 2022, 11:43 AM
rriddle edited the summary of this revision. (Show Details)
This revision was landed with ongoing or failed builds.Jan 26 2022, 12:05 PM
This revision was automatically updated to reflect the committed changes.