This is an archive of the discontinued LLVM Phabricator instance.

[flang][tco] Remove unneeded dependencies
ClosedPublic

Authored by awarzynski on Jan 25 2022, 1:45 AM.

Details

Summary

tco does not generate machine code, so it does not require (machine)
code-gen related dependencies.

Diff Detail

Event Timeline

awarzynski created this revision.Jan 25 2022, 1:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2022, 1:45 AM
Herald added a subscriber: mgorny. · View Herald Transcript
awarzynski requested review of this revision.Jan 25 2022, 1:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2022, 1:45 AM
mehdi_amini accepted this revision.Jan 25 2022, 9:51 AM

Thanks for the cleanup!

This revision is now accepted and ready to land.Jan 25 2022, 9:51 AM
schweitz added inline comments.Jan 25 2022, 10:36 AM
flang/tools/tco/tco.cpp
139

Is this not needed for specifying target triples other than the host?

I believe Triple is entirely implemented in libSupport.

@schweitz ${LLVM_TARGETS_TO_BUILD} and InitializeAllTargets(); are for initializing LLVM backends (i.e. backends that generate machine code). IIUC, this is irrelevant in tco (it's not meant to generate machine code). Also, I've tested tco before and after this change and I see no difference in behavior.

schweitz accepted this revision.Jan 25 2022, 1:03 PM

@schweitz ${LLVM_TARGETS_TO_BUILD} and InitializeAllTargets(); are for initializing LLVM backends (i.e. backends that generate machine code). IIUC, this is irrelevant in tco (it's not meant to generate machine code). Also, I've tested tco before and after this change and I see no difference in behavior.

Thanks for checking, Andrzej.

This revision was landed with ongoing or failed builds.Jan 26 2022, 5:03 AM
This revision was automatically updated to reflect the committed changes.