This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Add more identifier to created shared globals
ClosedPublic

Authored by jhuber6 on Jan 24 2022, 12:50 PM.

Details

Summary

Currenly we push some variables to a global constant containing shared
memory as an optimization. This generated constant had internal linkage
and should not have collided with any known identifiers in the
translation unit. However, there have been observed cases of this
optimiztaion unintentionally colliding with undocumented PTX
identifiers. This patch adds a suffix to the created globals to
hopefully bypass this.

Depends on D118059

Diff Detail

Event Timeline

jhuber6 created this revision.Jan 24 2022, 12:50 PM
jhuber6 requested review of this revision.Jan 24 2022, 12:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2022, 12:50 PM
This revision is now accepted and ready to land.Jan 24 2022, 1:08 PM
This revision was landed with ongoing or failed builds.Jan 24 2022, 5:38 PM
This revision was automatically updated to reflect the committed changes.