Details
Details
- Reviewers
adalava nemanjai qiucf - Group Reviewers
Restricted Project - Commits
- rGf2f4080c10f4: [PowerPC] Fix SSE translation on FreeBSD
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Thanks for the fix!
clang/lib/Headers/ppc_wrappers/mm_malloc.h | ||
---|---|---|
22 | Actually I just realised we don't need this guard, Clang already has a hack for this: previous declaration in system header has throw () but later doesn't is okay. See x86's header https://github.com/llvm/llvm-project/blob/510710d0374908e3e2bd37f9a32065da423a7e4c/clang/lib/Headers/mm_malloc.h#L21-L25 . I tested on Linux. |
Actually I just realised we don't need this guard, Clang already has a hack for this: previous declaration in system header has throw () but later doesn't is okay.
See x86's header https://github.com/llvm/llvm-project/blob/510710d0374908e3e2bd37f9a32065da423a7e4c/clang/lib/Headers/mm_malloc.h#L21-L25 .
I tested on Linux.