This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Fix SSE translation on FreeBSD
ClosedPublic

Authored by pkubaj on Jan 22 2022, 3:44 PM.

Diff Detail

Event Timeline

pkubaj created this revision.Jan 22 2022, 3:44 PM
pkubaj requested review of this revision.Jan 22 2022, 3:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2022, 3:44 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
qiucf added a subscriber: qiucf.Jan 25 2022, 6:16 PM

Thanks for the fix!

clang/lib/Headers/ppc_wrappers/mm_malloc.h
22

Actually I just realised we don't need this guard, Clang already has a hack for this: previous declaration in system header has throw () but later doesn't is okay.

See x86's header https://github.com/llvm/llvm-project/blob/510710d0374908e3e2bd37f9a32065da423a7e4c/clang/lib/Headers/mm_malloc.h#L21-L25 .

I tested on Linux.

lkail added a reviewer: Restricted Project.Jan 25 2022, 6:21 PM
pkubaj updated this revision to Diff 403103.Jan 25 2022, 6:28 PM

Address review.

pkubaj marked an inline comment as done.Jan 25 2022, 6:49 PM
qiucf accepted this revision as: qiucf.Jan 25 2022, 9:08 PM

LGTM

This revision is now accepted and ready to land.Jan 25 2022, 9:08 PM
pkubaj added a comment.Feb 1 2022, 8:09 AM

Since I'm not a LLVM committer, can you commit it and merge to 14 branch?

qiucf added a comment.Feb 5 2022, 9:08 AM

Since I'm not a LLVM committer, can you commit it and merge to 14 branch?

Sure. Sorry for late response, I'm on vacation these days.

This revision was landed with ongoing or failed builds.Feb 5 2022, 9:21 AM
This revision was automatically updated to reflect the committed changes.