This is an archive of the discontinued LLVM Phabricator instance.

Revert "[amdgpu] Improve the from f32 to i64."
AbandonedPublic

Authored by kzhuravl on Jan 20 2022, 8:57 AM.

Details

Reviewers
arsenm
msearles
Summary

This reverts commit 940efa4f6981964c95a69ff412378722438607bf.

Reason for revert: it breaks TestOpenCLLocalEnergyMinimizer test of OpenMM.

Diff Detail

Event Timeline

kzhuravl created this revision.Jan 20 2022, 8:57 AM
kzhuravl requested review of this revision.Jan 20 2022, 8:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2022, 8:57 AM
Herald added a subscriber: wdng. · View Herald Transcript

Breaks how / on what values?

Breaks how / on what values?

Incorrect results being produced by the kernel, so the comparison with host results fail.

Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2022, 9:30 AM
foad added a comment.Mar 3 2022, 10:24 AM

Is anyone going to debug this? Or can you at least narrow it down to an input that produces the wrong result?

Breaks how / on what values?

Incorrect results being produced by the kernel, so the comparison with host results fail.

But on what specific input/output values are broken?

arsenm requested changes to this revision.Nov 16 2022, 3:15 PM

Is this still relevant?

This revision now requires changes to proceed.Nov 16 2022, 3:15 PM
kzhuravl abandoned this revision.May 5 2023, 12:33 PM

Issue was fixed by another change.