This is an archive of the discontinued LLVM Phabricator instance.

Differential D117784

[flang][NFC] Remove unused/duplicated kStridePosInDim
ClosedPublic

Authored by clementval on Jan 20 2022, 7:04 AM.

Details

Reviewers
jeanPerier
kiranchandramohan
awarzynski
PeteSteinfeld
schweitz
svedanayagam
Commits
rG81cbbe3e17a4: [flang][NFC] Remove unused/duplicated kStridePosInDim
Summary

kStridePosInDim is a duplicate of kDimStridePos and is not used. Just
remove it.

Diff Detail

Event Timeline

clementval created this revision.Jan 20 2022, 7:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2022, 7:04 AM
Herald added a subscriber: mehdi_amini. · View Herald Transcript
clementval requested review of this revision.Jan 20 2022, 7:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2022, 7:04 AM
Herald added subscribers: llvm-commits, jdoerfert. · View Herald Transcript
Harbormaster completed remote builds in B144574: Diff 401627.Jan 20 2022, 7:20 AM
kiranchandramohan accepted this revision.Jan 20 2022, 9:27 AM

LGTM.

This revision is now accepted and ready to land.Jan 20 2022, 9:27 AM
Closed by commit rG81cbbe3e17a4: [flang][NFC] Remove unused/duplicated kStridePosInDim (authored by clementval). · Explain WhyJan 20 2022, 9:30 AM
This revision was automatically updated to reflect the committed changes.
clementval added a commit: rG81cbbe3e17a4: [flang][NFC] Remove unused/duplicated kStridePosInDim.

Revision Contents

PathSize
flang/
lib/
Optimizer/
CodeGen/
2 lines

Diff 401668

flang/lib/Optimizer/CodeGen/TypeConverter.h

Show All 25 Lines
static constexpr unsigned kAddrPosInBox = 0; static constexpr unsigned kAddrPosInBox = 0;
static constexpr unsigned kElemLenPosInBox = 1; static constexpr unsigned kElemLenPosInBox = 1;
static constexpr unsigned kVersionPosInBox = 2; static constexpr unsigned kVersionPosInBox = 2;
static constexpr unsigned kRankPosInBox = 3; static constexpr unsigned kRankPosInBox = 3;
static constexpr unsigned kTypePosInBox = 4; static constexpr unsigned kTypePosInBox = 4;
static constexpr unsigned kAttributePosInBox = 5; static constexpr unsigned kAttributePosInBox = 5;
static constexpr unsigned kF18AddendumPosInBox = 6; static constexpr unsigned kF18AddendumPosInBox = 6;
static constexpr unsigned kDimsPosInBox = 7; static constexpr unsigned kDimsPosInBox = 7;
static constexpr unsigned kStridePosInDim = 2;
static constexpr unsigned kOptTypePtrPosInBox = 8; static constexpr unsigned kOptTypePtrPosInBox = 8;
static constexpr unsigned kOptRowTypePosInBox = 9; static constexpr unsigned kOptRowTypePosInBox = 9;
// Position of the different values in [dims] // Position of the different values in [dims]
static constexpr unsigned kDimLowerBoundPos = 0; static constexpr unsigned kDimLowerBoundPos = 0;
static constexpr unsigned kDimExtentPos = 1; static constexpr unsigned kDimExtentPos = 1;
static constexpr unsigned kDimStridePos = 2; static constexpr unsigned kDimStridePos = 2;
namespace fir { namespace fir {
/// FIR type converter /// FIR type converter
▲ Show 20 Lines • Show All 303 Lines • Show Last 20 Lines