This is an archive of the discontinued LLVM Phabricator instance.

Differential D117668

[mlir][LangRef] Add top-level production to the MLIR grammar
ClosedPublic

Authored by bollu on Jan 19 2022, 6:04 AM.

Details

Reviewers
rriddle
mehdi_amini
ftynse
Commits
rG357f2d9ccf20: [mlir][LangRef] Add top-level production to the MLIR grammar
Summary

The LangRef currently lacks a top-level production, leaving the productions attribute-alias-def and type-alias-defunused. Clarify the situation by declaring what is to be parsed by an MLIR parser at the toplevel.

Diff Detail

Event Timeline

bollu created this revision.Jan 19 2022, 6:04 AM
Herald added subscribers: arjunp, sdasgup3, wenzhicui and 19 others. · View Herald TranscriptJan 19 2022, 6:04 AM
bollu requested review of this revision.Jan 19 2022, 6:04 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptJan 19 2022, 6:04 AM
Harbormaster completed remote builds in B144266: Diff 401199.Jan 19 2022, 6:40 AM
mehdi_amini accepted this revision.Jan 20 2022, 11:00 PM
This revision is now accepted and ready to land.Jan 20 2022, 11:00 PM
Closed by commit rG357f2d9ccf20: [mlir][LangRef] Add top-level production to the MLIR grammar (authored by bollu, committed by Groverkss). · Explain WhyJan 21 2022, 3:40 AM
This revision was automatically updated to reflect the committed changes.
Groverkss added a commit: rG357f2d9ccf20: [mlir][LangRef] Add top-level production to the MLIR grammar.

Revision Contents

PathSize
mlir/
docs/
13 lines

Diff 401926

mlir/docs/LangRef.md

Show First 20 Lines • Show All 173 Lines • ▼ Show 20 Lines
hexadecimal-literal ::= `0x` hex_digit+ hexadecimal-literal ::= `0x` hex_digit+
float-literal ::= [-+]?[0-9]+[.][0-9]*([eE][-+]?[0-9]+)? float-literal ::= [-+]?[0-9]+[.][0-9]*([eE][-+]?[0-9]+)?
string-literal ::= `"` [^"\n\f\v\r]* `"` TODO: define escaping rules string-literal ::= `"` [^"\n\f\v\r]* `"` TODO: define escaping rules
``` ```
Not listed here, but MLIR does support comments. They use standard BCPL syntax, Not listed here, but MLIR does support comments. They use standard BCPL syntax,
starting with a `//` and going until the end of the line. starting with a `//` and going until the end of the line.
### Top level Productions
```
// Top level production
toplevel := (operation | attribute-alias-def | type-alias-def)*
```
The production `toplevel` is the top level production that is parsed by any parsing
consuming the MLIR syntax. [Operations](#operations),
[Attribute alises](#attribute-value-aliases), and [Type aliases](#type-aliases)
can be declared on the toplevel.
### Identifiers and keywords ### Identifiers and keywords
Syntax: Syntax:
``` ```
// Identifiers // Identifiers
bare-id ::= (letter|[_]) (letter|digit|[_$.])* bare-id ::= (letter|[_]) (letter|digit|[_$.])*
bare-id-list ::= bare-id (`,` bare-id)* bare-id-list ::= bare-id (`,` bare-id)*
▲ Show 20 Lines • Show All 643 Lines • Show Last 20 Lines