Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Paths

Table of Contentst

Differential D117507

[PowerPC] Add the Power10 LXVKQ instrution.
ClosedPublic
Actions

Authored by stefanp on Jan 17 2022, 11:57 AM.

Tags

Subscribers

Details

Reviewers

lei
nemanjai
Yi-Hong.Lyu

Group Reviewers

Restricted Project

Commits

rGeb1c5a9862b6: [PowerPC] Add the Power10 LXVKQ instrution.

Summary

Add the Power 10 instruction LXVKQ.

This patch was taken from an original patch by: Yi-Hong Lyu

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

stefanp created this revision.Jan 17 2022, 11:57 AM

Herald added subscribers: shchenz, kbarton, hiraditya. · View Herald TranscriptJan 17 2022, 11:57 AM

stefanp requested review of this revision.Jan 17 2022, 11:57 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2022, 11:57 AM

stefanp added reviewers: Yi-Hong.Lyu, Restricted Project.Jan 17 2022, 11:58 AM

Harbormaster completed remote builds in B143846: Diff 400614.Jan 17 2022, 12:36 PM

LGTM, just a minor comment.

llvm/lib/Target/PowerPC/PPCInstrPrefix.td
1697 ↗	(On Diff #400614)	Any reason why we don't want this in the existing `IsISA3_1` section on line 1898?

This revision is now accepted and ready to land.Jan 18 2022, 7:15 AM

stefanp added inline comments.Jan 24 2022, 12:29 PM

llvm/lib/Target/PowerPC/PPCInstrPrefix.td
1697 ↗	(On Diff #400614)	Any reason why we don't want this in the existing `IsISA3_1` section on line 1898? It was separate in the original patch so I just left it where the original patch put it. There is no reason not to move it so I'll move it down.

Rebased the patch.
Moved the def for LXVKQ lower down.

This revision was landed with ongoing or failed builds.Feb 23 2022, 6:49 AM

Closed by commit rGeb1c5a9862b6: [PowerPC] Add the Power10 LXVKQ instrution. (authored by stefanp). · Explain Why

This revision was automatically updated to reflect the committed changes.

stefanp added a commit: rGeb1c5a9862b6: [PowerPC] Add the Power10 LXVKQ instrution..

Harbormaster completed remote builds in B151044: Diff 410797.Feb 23 2022, 7:12 AM

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Target/

PowerPC/

P10InstrResources.td

1 line

18 lines

test/

MC/

Disassembler/

PowerPC/

ppc64-encoding-ISA31.txt

3 lines

PowerPC/

ppc64-encoding-ISA31.s

3 lines

Diff 410807

llvm/lib/Target/PowerPC/P10InstrResources.td

Loading...

llvm/lib/Target/PowerPC/PPCInstrP10.td

Loading...

llvm/test/MC/Disassembler/PowerPC/ppc64-encoding-ISA31.txt

Loading...

llvm/test/MC/PowerPC/ppc64-encoding-ISA31.s

Loading...