This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Add the Power10 LXVKQ instrution.
ClosedPublic

Authored by stefanp on Jan 17 2022, 11:57 AM.

Details

Reviewers
lei
nemanjai
Yi-Hong.Lyu
Group Reviewers
Restricted Project
Commits
rGeb1c5a9862b6: [PowerPC] Add the Power10 LXVKQ instrution.
Summary

Add the Power 10 instruction LXVKQ.

This patch was taken from an original patch by: Yi-Hong Lyu

Diff Detail

Event Timeline

stefanp created this revision.Jan 17 2022, 11:57 AM
stefanp requested review of this revision.Jan 17 2022, 11:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2022, 11:57 AM
stefanp added reviewers: Yi-Hong.Lyu, Restricted Project.Jan 17 2022, 11:58 AM
lei accepted this revision as: lei.Jan 18 2022, 7:15 AM

LGTM, just a minor comment.

llvm/lib/Target/PowerPC/PPCInstrPrefix.td
1697 ↗(On Diff #400614)

Any reason why we don't want this in the existing IsISA3_1 section on line 1898?

This revision is now accepted and ready to land.Jan 18 2022, 7:15 AM
stefanp added inline comments.Jan 24 2022, 12:29 PM
llvm/lib/Target/PowerPC/PPCInstrPrefix.td
1697 ↗(On Diff #400614)

Any reason why we don't want this in the existing IsISA3_1 section on line 1898?

It was separate in the original patch so I just left it where the original patch put it. There is no reason not to move it so I'll move it down.

stefanp updated this revision to Diff 410797.Feb 23 2022, 6:14 AM

Rebased the patch.
Moved the def for LXVKQ lower down.

This revision was landed with ongoing or failed builds.Feb 23 2022, 6:49 AM
This revision was automatically updated to reflect the committed changes.