Page MenuHomePhabricator

[mlir][Linalg] NFC - Cleanup conv1d generators
ClosedPublic

Authored by nicolasvasilache on Jan 14 2022, 9:19 AM.

Diff Detail

Event Timeline

nicolasvasilache requested review of this revision.Jan 14 2022, 9:19 AM
gysit accepted this revision.Jan 17 2022, 9:19 AM
gysit added inline comments.
mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
1303

nit: could the implementation methods go in a detail namespace or get a Impl postfix?

1375

nit: could std::tie(kwSize, cSize, fSize) = std::make_tuple(rhsShape[0], rhsShape[1], rhsShape[2]); be an alternative to get everything on one line?

This revision is now accepted and ready to land.Jan 17 2022, 9:19 AM
nicolasvasilache marked an inline comment as done.

Address and rebase.

mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
1303

made them static as we usually do in such cases.

This revision was landed with ongoing or failed builds.Jan 17 2022, 9:39 AM
This revision was automatically updated to reflect the committed changes.