[clangd] Ignore cvr-qualifiers in selection.

[sammccall]

Summary

The AST doesn't track their locations, and the default behavior of attributing
them to the lexically-enclosing node is sloppy and often inaccurate.

Also add a couple of passing test cases for declarators that weren't obvious.

[sammccall]

Fix tests

[njames93]

clang-tools-extra/clangd/Selection.cpp

192

Just a drive by comment. This looks like it should be refactored to a switch just to make it more readable. Or if syntax::Token supports isOneOf method like clang::Token.

clang-tools-extra/clangd/Selection.cpp

void update(SelectionTree::Selection &Result, SelectionTree::Selection New) {
   else if (Result != New)
     // Can only be completely selected (or unselected) if all tokens are.
     Result = SelectionTree::Partial;
 }
 
 // As well as comments, don't count semicolons as real tokens.
 // They're not properly claimed as expr-statement is missing from the AST.
 bool shouldIgnore(const syntax::Token &Tok) {
-  return Tok.kind() == tok::comment || Tok.kind() == tok::semi;
+  switch (Tok.kind()) {
+    // Even "attached" comments are not considered part of a node's range.
+    case tok::comment:
+    // The AST doesn't directly store locations for terminating semicolons.
+    case tok::semi:
+    // We don't have locations for cvr-qualifiers: see QualifiedTypeLoc.
+    case tok::kw_const:
+    case tok::kw_volatile:
+    case tok::kw_restrict:
+      return true;
+    default:
+      return false;
+  }
 }
 
 // Determine whether 'Target' is the first expansion of the macro
 // argument whose top-level spelling location is 'SpellingLoc'.
 bool isFirstExpansion(FileID Target, SourceLocation SpellingLoc,
                       const SourceManager &SM) {
   SourceLocation Prev = SpellingLoc;
   while (true) {

clang-tools-extra/clangd/unittests/SelectionTests.cpp

Case Cases[] = {
       {"const int x = 1, y = 2; int array[^[[x]]][10][y];", "DeclRefExpr"},
       {"const int x = 1, y = 2; int array[x][10][^[[y]]];", "DeclRefExpr"},
       {"const int x = 1, y = 2; int array[x][^[[10]]][y];", "IntegerLiteral"},
       {"const int x = 1, y = 2; [[i^nt]] array[x][10][y];", "BuiltinTypeLoc"},
       {"void func(int x) { int v_array[^[[x]]][10]; }", "DeclRefExpr"},
 
       {"int (*getFunc([[do^uble]]))(int);", "BuiltinTypeLoc"},
 
+      // Member pointers and pack expansion use declarator syntax, but are
+      // restricted so they don't need special casing.
+      {"class X{}; [[int X::^*]]y[10];", "MemberPointerTypeLoc"},
+      {"template<typename ...T> void foo([[T*^...]]x);",
+       "PackExpansionTypeLoc"},
+      {"template<typename ...T> void foo([[^T]]*...x);",
+       "TemplateTypeParmTypeLoc"},
+
       // FIXME: the AST has no location info for qualifiers.
       {"const [[a^uto]] x = 42;", "AutoTypeLoc"},
-      {"[[co^nst auto x = 42]];", "VarDecl"},
+      {"co^nst auto x = 42;", nullptr},
 
       {"^", nullptr},
       {"void foo() { [[foo^^]] (); }", "DeclRefExpr"},
 
       // FIXME: Ideally we'd get a declstmt or the VarDecl itself here.
       // This doesn't happen now; the RAV doesn't traverse a node containing ;.
       {"int x = 42;^", nullptr},