[DebugInfo][DWARF][NFC] Move DWARFTypePrinter class to its own file.

[avl]

Summary

This patch moves DWARFTypePrinter class to its own file, so that it
might be reused. It will help D96035, which uses DWARFTypePrinter.

[dblaikie]

I don't especially object to moving this to a separate file - but maybe it'd be more suitable to have this exposed as a function on DWARFDie, rather than exposing the whole DWARFTypePrinter API?

[avl]

In D117134#3239412, @dblaikie wrote:

I don't especially object to moving this to a separate file - but maybe it'd be more suitable to have this exposed as a function on DWARFDie, rather than exposing the whole DWARFTypePrinter API?

i.e. something similar to this:

void DWARFDie::dumpTypeQualifiedName(raw_ostream& OS);
void DWARFDie::dumpTypeUnqualifiedName(raw_ostream& OS, std::string *OriginalFullName = nullptr);

If that is a preferred variant - I will change the patch accordingly.

Though, The variant with a separate class has an advantage in that it separates dumping functionality from the DWARFDie class.
That is similar to the "Model-View" pattern. If we would add more dumps(for different programming languages, or for different DWARFDie kinds) then we would be necessary to add more dumping functions into the DWARFDie interface, which is probably not a good thing:

void DWARFDie::dumpSubprogram(raw_ostream& OS);
void DWARFDie::dumpRanges(raw_ostream& OS);

From that point of view, using a separate class for dumping probably looks preferable. It allows keeping the DWARFDie interface simpler.
But if adding specific dumping methods to the DWARFDie looks better for us - I am OK to do this.

[dblaikie]

In D117134#3239597, @avl wrote:

In D117134#3239412, @dblaikie wrote:

I don't especially object to moving this to a separate file - but maybe it'd be more suitable to have this exposed as a function on DWARFDie, rather than exposing the whole DWARFTypePrinter API?

i.e. something similar to this:

void DWARFDie::dumpTypeQualifiedName(raw_ostream& OS);
void DWARFDie::dumpTypeUnqualifiedName(raw_ostream& OS, std::string *OriginalFullName = nullptr);

If that is a preferred variant - I will change the patch accordingly.

Though, The variant with a separate class has an advantage in that it separates dumping functionality from the DWARFDie class.

Oh, fair point - how about free functions, then? void dumpTypeQualifiedName(DWARFDie D, raw_ostream &OS) - that sort of thing?

[avl]

addressed comments(left DWARFTypePrinter inside DWARFDie.cpp, created two functions for type printing)

[dblaikie]

Looks good, thanks!

[avl]

Thank you for the review!

llvm/include/llvm/DebugInfo/DWARF/DWARFDie.h

 inline std::reverse_iterator<DWARFDie::iterator> DWARFDie::rbegin() const {
   return std::make_reverse_iterator(end());
 }
 
 inline std::reverse_iterator<DWARFDie::iterator> DWARFDie::rend() const {
   return std::make_reverse_iterator(begin());
 }
 
+void dumpTypeQualifiedName(const DWARFDie &DIE, raw_ostream &OS);
+void dumpTypeUnqualifiedName(const DWARFDie &DIE, raw_ostream &OS,
+                             std::string *OriginalFullName = nullptr);
+
 } // end namespace llvm
 
 #endif // LLVM_DEBUGINFO_DWARF_DWARFDIE_H

llvm/lib/DebugInfo/DWARF/DWARFDie.cpp

if (Attr == DW_AT_specification || Attr == DW_AT_abstract_origin) {
     if (const char *Name =
             Die.getAttributeValueAsReferencedDie(FormValue).getName(
                 DINameKind::LinkageName))
       OS << Space << "\"" << Name << '\"';
   } else if (Attr == DW_AT_type) {
     DWARFDie D = resolveReferencedType(Die, FormValue);
     if (D && !D.isNULL()) {
       OS << Space << "\"";
-      DWARFTypePrinter(OS).appendQualifiedName(D);
+      dumpTypeQualifiedName(D, OS);
       OS << '"';
     }
   } else if (Attr == DW_AT_APPLE_property_attribute) {
     if (Optional<uint64_t> OptVal = FormValue.getAsUnsignedConstant())
       dumpApplePropertyAttribute(OS, *OptVal);
   } else if (Attr == DW_AT_ranges) {
     const DWARFObject &Obj = Die.getDwarfUnit()->getContext().getDWARFObj();
     // For DW_FORM_rnglistx we need to dump the offset separately, since

 
 void DWARFDie::getFullName(raw_string_ostream &OS,
                            std::string *OriginalFullName) const {
   const char *NamePtr = getShortName();
   if (!NamePtr)
     return;
   if (getTag() == DW_TAG_GNU_template_parameter_pack)
     return;
-  DWARFTypePrinter(OS).appendUnqualifiedName(*this, OriginalFullName);
+  dumpTypeUnqualifiedName(*this, OS, OriginalFullName);
 }
 
 bool DWARFDie::isSubprogramDIE() const { return getTag() == DW_TAG_subprogram; }
 
 bool DWARFDie::isSubroutineDIE() const {
   auto Tag = getTag();
   return Tag == DW_TAG_subprogram || Tag == DW_TAG_inlined_subroutine;
 }
bool DWARFAttribute::mayHaveLocationExpr(dwarf::Attribute Attr) {
   // Extensions.
   case DW_AT_GNU_call_site_value:
   case DW_AT_GNU_call_site_target:
     return true;
   default:
     return false;
   }
 }
+
+namespace llvm {
+
+void dumpTypeQualifiedName(const DWARFDie &DIE, raw_ostream &OS) {
+  DWARFTypePrinter(OS).appendQualifiedName(DIE);
+}
+
+void dumpTypeUnqualifiedName(const DWARFDie &DIE, raw_ostream &OS,
+                             std::string *OriginalFullName) {
+  DWARFTypePrinter(OS).appendUnqualifiedName(DIE, OriginalFullName);
+}
+
+} // namespace llvm