This is an archive of the discontinued LLVM Phabricator instance.

[M68k] Add MC support for bchg, bclr and bset instruction
ClosedPublic

Authored by Jim on Jan 10 2022, 10:01 PM.

Diff Detail

Event Timeline

Jim created this revision.Jan 10 2022, 10:01 PM
Jim requested review of this revision.Jan 10 2022, 10:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 10 2022, 10:01 PM
Jim updated this revision to Diff 398843.Jan 10 2022, 10:06 PM

Fix tests

myhsu added a comment.Jan 13 2022, 5:52 AM

Thanks for the patch.
Have you confirmed that codegen tests are not affected? You used the same isel patterns for all of the bit instructions (btst/bset/bclr etc.) which I don't think that's correct.

It's okay to add only the MC support for certain instructions but please leave the isel pattern empty.

Is this still being worked on? We're still missing the BCHG, BCLR and BSET instructions.

Herald added a project: Restricted Project. · View Herald TranscriptMay 1 2023, 2:25 PM
Jim updated this revision to Diff 541945.Jul 19 2023, 3:58 AM

Leave the isel pattern empty.

Jim updated this revision to Diff 541946.Jul 19 2023, 4:01 AM

Rebase

Jim updated this revision to Diff 541947.Jul 19 2023, 4:02 AM

Clean code style

Jim updated this revision to Diff 541948.Jul 19 2023, 4:04 AM

Fix tab indent

Jim added a reviewer: glaubitz.Aug 7 2023, 8:10 PM
myhsu accepted this revision.Aug 18 2023, 3:53 PM

LGTM with minor issues, thanks!

llvm/lib/Target/M68k/M68kInstrBits.td
51

nit: ISel pattern is initialized to empty list by default so you don't need to put a [] here. Ditto for other places in this patch.

This revision is now accepted and ready to land.Aug 18 2023, 3:53 PM
Jim updated this revision to Diff 551698.Aug 18 2023, 8:44 PM

Address comment.

Jim marked an inline comment as done.Aug 18 2023, 8:44 PM
This revision was landed with ongoing or failed builds.Aug 18 2023, 8:54 PM
This revision was automatically updated to reflect the committed changes.