[flang] Add tests for converting arrays and refs to arrays. NFC

[rovka]

Summary

Cover some of the code paths from LLVMTypeConverter::convertPointerLike
and LLVMTypeConverter::convertSequenceType (specifically related to
whether or not the sequence type has a constant interior).

[awarzynski]

Thanks for adding these! I think that I've identified a couple more cases that are not covered here. Would it make sense to test them as well?

The conversions are not 100% clear to me TBH. For example, !fir.ref<!fir.array<10x?x11xf32>> becomes a plain !llvm.ptr (with no array inside) because the number of rows is unknown, correct?

flang/test/Fir/types-to-llvm.fir

6

How about fir.char? https://github.com/llvm/llvm-project/blob/5eb47961c42cef03d832c646860a1eff6f8b4104/flang/lib/Optimizer/CodeGen/TypeConverter.h#L291

32

How about fir.box inside fir.ref? https://github.com/llvm/llvm-project/blob/5eb47961c42cef03d832c646860a1eff6f8b4104/flang/lib/Optimizer/CodeGen/TypeConverter.h#L282

48

There's a switch from column-major to row-major here, right? (hence 11 and 10 are swapped). Might be worth adding a comment.

[rovka]

• Cover more code paths (dynamic and fixed-length chars, ref<box>).
• Add a comment that we're switching between column-major and row-major, and also modify the first test in the file to show this (was 10x10, is now 10x12 so we can see the difference).

Thanks for the comments, let me know if I missed any other cases :)

[awarzynski]

I think that this covers all cases :)

flang/test/Fir/types-to-llvm.fir

 // Test FIR types conversion.
 
 // RUN: fir-opt --split-input-file --fir-to-llvm-ir="target=x86_64-unknown-linux-gnu" %s | FileCheck %s
 
 
 // Test sequence types `!fir.array`
 
 func private @foo0(%arg0: !fir.array<10x10xi64>)
 // CHECK-LABEL: foo0
 // CHECK-SAME: !llvm.array<10 x array<10 x i64>>
 func private @foo1(%arg0: !fir.array<?xf32>)
 // CHECK-LABEL: foo1
 // CHECK-SAME: !llvm.ptr<f32>
 func private @foo2(%arg0: !fir.array<?x?xf128>)
 // CHECK-LABEL: foo2
 // CHECK-SAME: !llvm.ptr<f128>
 func private @foo3(%arg0: !fir.array<*:i32>)
 // CHECK-LABEL: foo3
 // CHECK-SAME: !llvm.ptr<i32>
+func private @foo4(%arg0: !fir.array<3x?xi32>)
+// CHECK-LABEL: foo4
+// CHECK-SAME: !llvm.ptr<array<3 x i32>>
+func private @foo5(%arg0: !fir.array<?x6xi32>)
+// CHECK-LABEL: foo5
+// CHECK-SAME: !llvm.ptr<i32>
+func private @foo6(%arg0: !fir.array<2x?x3x?x4xi32>)
+// CHECK-LABEL: foo6
+// CHECK-SAME: !llvm.ptr<array<2 x i32>
 
 // -----
 
 // Test reference types `!fir.ref`
 
 func private @foo0(%arg0: !fir.ref<i32>)
 // CHECK-LABEL: foo0
 // CHECK-SAME: !llvm.ptr<i32>
 func private @foo1(%arg0: !fir.ref<!fir.array<10xf32>>)
 // CHECK-LABEL: foo1
 // CHECK-SAME: !llvm.ptr<array<10 x f32>>
 func private @foo2(%arg0: !fir.ref<!fir.box<!fir.heap<!fir.type<_QMs1Ta1{x:i32,y:f32}>>>>)
 // CHECK-LABEL: foo2
 // CHECK-SAME: !llvm.ptr<struct<(ptr<struct<"_QMs1Ta1", (i32, f32)>>, i{{.*}}, i{{.*}}, i{{.*}}, i{{.*}}, i{{.*}}, i{{.*}}, ptr<i{{.*}}>, array<1 x i{{.*}}>)>>
+func private @foo3(%arg0: !fir.ref<!fir.array<10x?x11xf32>>)
+// CHECK-LABEL: foo3
+// CHECK-SAME: !llvm.ptr<f32>
+func private @foo4(%arg0: !fir.ref<!fir.array<10x11x?x?xf32>>)
+// CHECK-LABEL: foo4
+// CHECK-SAME: !llvm.ptr<array<11 x array<10 x f32>>>
 
 // -----
 
 // Test pointer types `!fir.ptr`
 
 func private @foo0(%arg0: !fir.ptr<i32>)
 // CHECK-LABEL: foo0
 // CHECK-SAME: !llvm.ptr<i32>