This is an archive of the discontinued LLVM Phabricator instance.

Revert D109159 : Revert "[amdgpu] Enable selection of `s_cselect_b64`."
ClosedPublic

Authored by david-salinas on Jan 5 2022, 11:58 AM.

Details

Summary

This reverts commit 640beb38e7710b939b3cfb3f4c54accc694b1d30.

That commit caused performance degradtion in Quicksilver test QS:sGPU and a functional test failure in (rocPRIM rocprim.device_segmented_radix_sort).
Reverting until we have a better solution to s_cselect_b64 codegen cleanup

Change-Id: Ifc167b3c2dae7a65920676f22a97ba76485f3456

Diff Detail

Event Timeline

david-salinas created this revision.Jan 5 2022, 11:58 AM
david-salinas requested review of this revision.Jan 5 2022, 11:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2022, 11:58 AM

fix failing LIT tests llvm/test/CodeGen/AMDGPU/indirect-call-known-callees.ll

kzhuravl accepted this revision.Jan 11 2022, 12:15 PM

LGTM, I have looked through the implementation, and it looks like a correct revert of https://reviews.llvm.org/rG640beb38e7710b939b3cfb3f4c54accc694b1d30. I have looked through most tests, but not all. Can you make sure to run lit tests before pushing your change? Thank you

This revision is now accepted and ready to land.Jan 11 2022, 12:15 PM
This revision was landed with ongoing or failed builds.Jan 11 2022, 1:14 PM
This revision was automatically updated to reflect the committed changes.
llvm/test/CodeGen/AMDGPU/addrspacecast.ll