This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Add explicit using getElementType for base class to disambiguate between multiple implementations
ClosedPublic

Authored by lipracer on Dec 29 2021, 7:22 PM.

Details

Summary

Both of DenseElementsAttr and ElementsAttrTrait define the method of getElementType.

Diff Detail

Event Timeline

lipracer created this revision.Dec 29 2021, 7:22 PM
lipracer requested review of this revision.Dec 29 2021, 7:22 PM

Can you please upload patches with full context? (use arc ideally, or git -U99999)

lipracer updated this revision to Diff 396602.Dec 29 2021, 9:32 PM
lipracer added a reviewer: mehdi_amini.
lipracer removed subscribers: shauheen, antiagainst, arpith-jacob and 21 others.

Difference patch with full context.

mehdi_amini accepted this revision.Dec 29 2021, 10:05 PM

Your commit title is confusing to me, you wrote "remove rundant define of getElementType" but wouldn't it be more accurate to say "Add explicit using getElementType for base class to disambiguate between multiple implementations" or something like that?

This revision is now accepted and ready to land.Dec 29 2021, 10:05 PM

Your commit title is confusing to me, you wrote "remove rundant define of getElementType" but wouldn't it be more accurate to say "Add explicit using getElementType for base class to disambiguate between multiple implementations" or something like that?

Yes. You are right.

Do you have commit access or do you need me to land it?

(I'd need the name and email you want to be used for the commit if you need me to land it)

(I'd need the name and email you want to be used for the commit if you need me to land it)

Thanks, Please help me land it and It's my user.name: 'long.chen' and user.email: 'lipracer@gmail.com'.

lipracer retitled this revision from [MLIR] remove rundant define of getElementType to [MLIR] remove redundant define of getElementType.Dec 30 2021, 4:41 AM
lipracer retitled this revision from [MLIR] remove redundant define of getElementType to [MLIR] Add explicit using getElementType for base class to disambiguate between multiple implementations.