Such functionality is used in various places.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/IR/Block.cpp | ||
---|---|---|
263 | Should we name this mightHaveTerminator()? |
mlir/lib/IR/Block.cpp | ||
---|---|---|
263 | What's your reasoning? A block either has a terminator or not. |
mlir/lib/IR/Block.cpp | ||
---|---|---|
263 | I see, to account for unregistered ops. All code locations that I found are actually looking for terminators, not may-be-terminators. |
mlir/lib/IR/Block.cpp | ||
---|---|---|
263 | Yes, it’s tricky because there is no definitive answer for unregistered ops… For example right now !hasTerminator() does not mean no terminator , so I’d name it hasRegisteredTerminator to be exact |
Should we name this mightHaveTerminator()?