Size-1 vectors are converted into scalars in SPIR-V so these ops
go away entirely.
Along the way, update the pass to perform partial conversion
so that we can have more focused tests.
Paths
| Differential D115517
[mlir][spirv] Support size-1 vector.insert during conversion ClosedPublic Authored by antiagainst on Dec 10 2021, 6:37 AM.
Details Summary Size-1 vectors are converted into scalars in SPIR-V so these ops Along the way, update the pass to perform partial conversion
Diff Detail
Event Timelinemravishankar added inline comments.
This revision now requires changes to proceed.Dec 10 2021, 10:03 AM antiagainst added inline comments.
antiagainst added inline comments.
antiagainst added a parent revision: D115756: [mlir][spirv] Perform partial conversion in VectorToSPIRVPass.Dec 14 2021, 1:14 PM mravishankar added inline comments.
This revision is now accepted and ready to land.Jan 20 2022, 9:11 AM Comment Actions I wonder if this will lead to unrealized conversion casts not being able to be eliminated since the uses might actually need a vector. Comment Actions
Size-1 vector are converted to scalars by the SPIR-V type converter globally. So shouldn't be a big problem. If it happens, it's an indication a missing op conversion. This revision was landed with ongoing or failed builds.Jan 21 2022, 10:57 AM Closed by commit rG4710750854ce: [mlir][spirv] Support size-1 vector inserts during conversion (authored by antiagainst). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 393467 mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRVPass.cpp
mlir/test/Conversion/VectorToSPIRV/simple.mlir
|
Nit: type s/Speical/Special