Page MenuHomePhabricator

[mlir][spirv] Support size-1 vector/tensor constant during conversion
ClosedPublic

Authored by antiagainst on Dec 10 2021, 6:39 AM.

Diff Detail

Event Timeline

antiagainst created this revision.Dec 10 2021, 6:39 AM
antiagainst requested review of this revision.Dec 10 2021, 6:39 AM
mravishankar accepted this revision.Dec 10 2021, 10:06 AM

Minor comment. LGTM otherwise.

mlir/lib/Conversion/ArithmeticToSPIRV/ArithmeticToSPIRV.cpp
370

IIUC its part of the constant op verification that the type of attribute and type of the result are the same?

This revision is now accepted and ready to land.Dec 10 2021, 10:06 AM
ThomasRaoux accepted this revision.Dec 10 2021, 10:11 AM
antiagainst marked an inline comment as done.Dec 14 2021, 12:51 PM
antiagainst added inline comments.
mlir/lib/Conversion/ArithmeticToSPIRV/ArithmeticToSPIRV.cpp
370

Yup I think so for arith::ConstantOp.

This revision was automatically updated to reflect the committed changes.
antiagainst marked an inline comment as done.