Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM, but should be merged after https://reviews.llvm.org/D114457 (see inline comment).
llvm/lib/Target/SystemZ/SystemZAsmPrinter.cpp | ||
---|---|---|
807 | Neumann's patch https://reviews.llvm.org/D114457 is now approved, so as soon as this is merged, you should remove the +128 and the FIXME here. |
Comment Actions
The test added in this change fails on build bots that do not build the s390x target. Can you please take a look?
https://lab.llvm.org/buildbot/#/builders/139/builds/15573
******************** TEST 'LLVM :: MC/GOFF/ppa1.ll' FAILED ******************** Script: -- : 'RUN: at line 1'; /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/llc -mtriple s390x-ibm-zos < /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/test/MC/GOFF/ppa1.ll | /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/FileCheck /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/test/MC/GOFF/ppa1.ll -- Exit Code: 2 Command Output (stderr): -- /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/llc: error: : error: unable to get target for 's390x-ibm-zos', see --version and --triple. FileCheck error: '<stdin>' is empty. FileCheck command line: /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/FileCheck /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/test/MC/GOFF/ppa1.ll --
Neumann's patch https://reviews.llvm.org/D114457 is now approved, so as soon as this is merged, you should remove the +128 and the FIXME here.