This is an archive of the discontinued LLVM Phabricator instance.

[SystemZ][z/OS] Add entry point marker to PPA
ClosedPublic

Authored by yusra.syeda on Dec 7 2021, 10:59 AM.

Diff Detail

Event Timeline

yusra.syeda created this revision.Dec 7 2021, 10:59 AM
yusra.syeda requested review of this revision.Dec 7 2021, 10:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2021, 10:59 AM
yusra.syeda edited reviewers, added: Everybody0523; removed: neumannh.
uweigand accepted this revision.Dec 9 2021, 9:35 AM

LGTM, but should be merged after https://reviews.llvm.org/D114457 (see inline comment).

llvm/lib/Target/SystemZ/SystemZAsmPrinter.cpp
807

Neumann's patch https://reviews.llvm.org/D114457 is now approved, so as soon as this is merged, you should remove the +128 and the FIXME here.

This revision is now accepted and ready to land.Dec 9 2021, 9:35 AM

Removed the FIXME

yusra.syeda marked an inline comment as done.Dec 14 2021, 10:54 AM
uweigand accepted this revision.Dec 16 2021, 7:31 AM

LGTM.

Rebasing on latest main

This revision was landed with ongoing or failed builds.Jan 6 2022, 6:29 PM
This revision was automatically updated to reflect the committed changes.
dyung added a subscriber: dyung.Jan 6 2022, 7:58 PM

The test added in this change fails on build bots that do not build the s390x target. Can you please take a look?

https://lab.llvm.org/buildbot/#/builders/139/builds/15573

******************** TEST 'LLVM :: MC/GOFF/ppa1.ll' FAILED ********************
Script:
--
: 'RUN: at line 1';   /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/llc -mtriple s390x-ibm-zos < /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/test/MC/GOFF/ppa1.ll | /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/FileCheck /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/test/MC/GOFF/ppa1.ll
--
Exit Code: 2
Command Output (stderr):
--
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/llc: error: : error: unable to get target for 's390x-ibm-zos', see --version and --triple.
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/FileCheck /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/test/MC/GOFF/ppa1.ll
--
foad added a subscriber: foad.Jan 7 2022, 1:39 AM

The test added in this change fails on build bots that do not build the s390x target. Can you please take a look?

https://lab.llvm.org/buildbot/#/builders/139/builds/15573

******************** TEST 'LLVM :: MC/GOFF/ppa1.ll' FAILED ********************
Script:
--
: 'RUN: at line 1';   /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/llc -mtriple s390x-ibm-zos < /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/test/MC/GOFF/ppa1.ll | /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/FileCheck /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/test/MC/GOFF/ppa1.ll
--
Exit Code: 2
Command Output (stderr):
--
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/llc: error: : error: unable to get target for 's390x-ibm-zos', see --version and --triple.
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/FileCheck /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/test/MC/GOFF/ppa1.ll
--

Should be fixed by 080f372ad36483b7d413e98c3bef5170bdb97631.