This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP][FIX] SPMDzation guarding needs to account for all reaching kernels
ClosedPublic

Authored by jhuber6 on Dec 1 2021, 5:33 AM.

Details

Summary

If two reaching kernels disagree on the execution mode we cannot guard a
function right now. Ensure we do not as we otherwise will cause a
deadlock.

Diff Detail

Event Timeline

jdoerfert created this revision.Dec 1 2021, 5:33 AM
jdoerfert requested review of this revision.Dec 1 2021, 5:33 AM
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
JonChesterfield accepted this revision.Dec 1 2021, 5:46 AM

Makes sense. Sometime later it's probably worth cloning & specialising the function so we can have the faster execution for the corresponding kernels without breaking the others.

This revision is now accepted and ready to land.Dec 1 2021, 5:46 AM
jhuber6 commandeered this revision.Dec 1 2021, 6:55 AM
jhuber6 edited reviewers, added: jdoerfert; removed: jhuber6.

Committing on behalf of @jdoerfert.

jhuber6 updated this revision to Diff 391011.Dec 1 2021, 6:56 AM
jhuber6 edited the summary of this revision. (Show Details)

Fixing tests

This revision was landed with ongoing or failed builds.Dec 1 2021, 8:44 AM
This revision was automatically updated to reflect the committed changes.