Page MenuHomePhabricator

[ARM] Pass subtarget feature "+strict-align" instead of backend option "arm-strict-align"
ClosedPublic

Authored by ahatanak on Jul 23 2015, 12:58 PM.

Details

Summary

This is change is needed for LTO since anything passed via backend-option does not make it to the backend.

The corresponding llvm patch is here: http://reviews.llvm.org/D11470

Diff Detail

Event Timeline

ahatanak updated this revision to Diff 30513.Jul 23 2015, 12:58 PM
ahatanak retitled this revision from to [ARM] Pass subtarget feature "+strict-align" instead of backend option "arm-strict-align".
ahatanak updated this object.
ahatanak added reviewers: echristo, dexonsmith, jfb, dschuff.
ahatanak added a subscriber: cfe-commits.
jfb added inline comments.Jul 23 2015, 1:09 PM
test/Driver/arm-alignment.c
32

aarch64 also has its own option? Should your patch (or a follow-up) fix both?

Yes, fixing aarch64's strict-align was going to be my next patch.

jfb edited edge metadata.Jul 23 2015, 1:12 PM

Yes, fixing aarch64's strict-align was going to be my next patch.

I think you may want to do it in this patch: you're generalizing something ARM does, but only using the new generalism in ARM. Having 2 targets use it would make this better IMO :-)

ahatanak updated this revision to Diff 30553.Jul 23 2015, 6:47 PM
ahatanak edited edge metadata.

Added test cases for clang driver.

jfb accepted this revision.Jul 24 2015, 5:15 PM
jfb edited edge metadata.

This lgtm, considering the comments on D11470.

Please do follow-up with equivalent aarch64 changes!

This revision is now accepted and ready to land.Jul 24 2015, 5:15 PM
Eugene.Zelenko added a subscriber: Eugene.Zelenko.

Committed in rL243489.