Page MenuHomePhabricator

[MC][ELF] Fix accepting abbreviated form with Type change
ClosedPublic

Authored by burnus on Nov 29 2021, 9:21 AM.

Details

Summary

Follow up to D92052 and D94072, exposed due to D107707

Many assemblers to permit that only the first .section contains all
the attributes like '.lds_bss,"w",@nobits' and later section only
use the name ('.lds_bss') inheriting those attributes from the first
section. I turned out that the case that Type changed was missed
when implementing it - and D107707 make it much more likely to hit
that issue. That's fixed by this commit.

Diff Detail

Event Timeline

burnus created this revision.Nov 29 2021, 9:21 AM
burnus requested review of this revision.Nov 29 2021, 9:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2021, 9:21 AM
MaskRay accepted this revision.Nov 29 2021, 4:44 PM

LGTM.

This revision is now accepted and ready to land.Nov 29 2021, 4:44 PM
This revision was automatically updated to reflect the committed changes.