Page MenuHomePhabricator

burnus (Tobias Burnus)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 19 2020, 8:18 AM (19 w, 5 d)

Recent Activity

Jan 28 2021

burnus updated the diff for D94072: [MC][ELF] Fix accepting abbreviated form with sh_flags and sh_entsize.

(New version, only change: Add missing tailing '.')

Jan 28 2021, 2:44 AM · Restricted Project

Jan 27 2021

burnus updated the diff for D94072: [MC][ELF] Fix accepting abbreviated form with sh_flags and sh_entsize.

Change: Add comment line to test/MC/ELF/section-omitted-attributes.s

Jan 27 2021, 6:11 AM · Restricted Project
burnus added a comment to D94072: [MC][ELF] Fix accepting abbreviated form with sh_flags and sh_entsize.

I'm struggling to follow the initial explanation. Could you post an example of what didn't work before, and what the failure mode was, and which now works?

Jan 27 2021, 5:36 AM · Restricted Project

Jan 26 2021

burnus added a comment to D94072: [MC][ELF] Fix accepting abbreviated form with sh_flags and sh_entsize.

*PING**3

Jan 26 2021, 10:50 PM · Restricted Project

Jan 21 2021

burnus added a comment to D94072: [MC][ELF] Fix accepting abbreviated form with sh_flags and sh_entsize.

PING**2

Jan 21 2021, 11:28 PM · Restricted Project

Jan 18 2021

burnus added a comment to D94072: [MC][ELF] Fix accepting abbreviated form with sh_flags and sh_entsize.

*PING*

Jan 18 2021, 12:14 AM · Restricted Project

Jan 11 2021

burnus added a comment to D94072: [MC][ELF] Fix accepting abbreviated form with sh_flags and sh_entsize.

@MaskRay: See previous comment. It is not clear to me which GCC changes you think are required and what you mean by "ifndef BUILTIN" (i.e. why it is needed to test for).

Jan 11 2021, 6:38 AM · Restricted Project

Jan 7 2021

burnus added a comment to D94072: [MC][ELF] Fix accepting abbreviated form with sh_flags and sh_entsize.

This now becomes hazy. While .rodata.cst8 is a built-in section name in MC, it is not in GNU as. i.e. If you specify .section .rdata.cst8, GNU as does not make it SHF_MERGE or set sh_entsize to 8.

Jan 7 2021, 2:30 AM · Restricted Project

Jan 5 2021

burnus requested review of D94072: [MC][ELF] Fix accepting abbreviated form with sh_flags and sh_entsize.
Jan 5 2021, 2:28 AM · Restricted Project

Dec 14 2020

burnus added a comment to D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize.

@burnus Looks like you did not mention https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97827 in the initial review.

Dec 14 2020, 10:36 AM · Restricted Project
burnus added a comment to D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize.

Have any other targets in gcc besides amdgcn run into this problem? If this is something specific to amdgcn, then I'm not sure we should be adding a workaround for it to LLVM.

Dec 14 2020, 10:13 AM · Restricted Project
burnus added a comment to D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize.

This is about assembling GCC's -S output with LLVM's integrated assembler, which isn't an area that I think people frequently use, so I'd also hear from @burnus why this is urgent.

Dec 14 2020, 10:02 AM · Restricted Project

Dec 11 2020

burnus updated subscribers of D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize.

As it is a regression and affects real-world code (https://bugs.llvm.org/show_bug.cgi?id=48201),
I like to backport it to LLVM 11. – Any reasons not to do so?

Dec 11 2020, 9:07 AM · Restricted Project
burnus updated the diff for D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize.

Thanks for the reviews! Only change: added proposed comment string to llvm/test/MC/ELF/section-omitted-attributes.s regarding what the patch does.

Dec 11 2020, 8:36 AM · Restricted Project
burnus added a comment to D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize.

@jhenderson – did I answer your questions - or did I misread them? Are the other issues?

Dec 11 2020, 12:56 AM · Restricted Project

Dec 7 2020

burnus added inline comments to D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize.
Dec 7 2020, 2:06 AM · Restricted Project

Dec 4 2020

burnus updated the diff for D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize.

@MaskRay: Thanks for the review. I hope it now makes sense.

Dec 4 2020, 3:16 AM · Restricted Project

Dec 3 2020

burnus added a comment to D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize.

REVIEW PING

Dec 3 2020, 7:11 AM · Restricted Project

Nov 30 2020

burnus added a comment to D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize.

Review PING – Is there anything else to be changed?

Nov 30 2020, 2:53 AM · Restricted Project

Nov 26 2020

burnus set the repository for D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize to rG LLVM Github Monorepo.
Nov 26 2020, 3:04 PM · Restricted Project

Nov 25 2020

burnus updated the diff for D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize.

Fix review comments (all in the testcases)

Nov 25 2020, 9:35 AM · Restricted Project
burnus updated the diff for D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize.

Fix review nit – two instead of one empty line inside a test case.

Nov 25 2020, 2:25 AM · Restricted Project

Nov 24 2020

burnus updated the diff for D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize.

Address review comments.

Nov 24 2020, 11:41 PM · Restricted Project
burnus added a comment to D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize.

This is known. I'd like it to be an error but it is unfortunate that GCC uses it this way. Can you share a code snippet which can trigger the relevant GCC logic?

Nov 24 2020, 2:28 PM · Restricted Project
burnus added a comment to D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize.

Correction: The previous change (D73999) was done for "LLVM 11" - not as I wrote for "LLVM 10".

Nov 24 2020, 12:05 PM · Restricted Project
burnus requested review of D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize.
Nov 24 2020, 11:58 AM · Restricted Project