Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Dialect/StandardOps/Transforms/TensorConstantBufferize.cpp | ||
---|---|---|
123 | Seems like passes like this one stay in the existing dialect? Looking at these, isn't it hinting at a missing opinterface to hook these into a unique bufferization pass living in the bufferization dialect? |
Looks good to me. What about the actual bufferization passes. Like -tensor-bufferize. Will these stay in their respective dialect or are they also getting moved here?
@mehdi_amini @springerm Yes, the passes like tensor-bufferize will stay in their dialects. It might be possible to reuse BufferizableOpInterface for the "gradual" bufferization instead of using the patterns. I think that this is how these two bufferization approaches will converge in the end.
I am confused by your answer: tensor-buffering isn’t part of the gradual bufferization right now?
It is a part of gradual bufferization. And the passes for gradual bufferization live in their corresponding dialects. You mentioned that it indicates that there might be an interface missing to just have a single bufferization pass. I agree and I think this interface already exists and it is used in comprehensive bufferization. We might want to reuse it.
Seems like passes like this one stay in the existing dialect?
Looking at these, isn't it hinting at a missing opinterface to hook these into a unique bufferization pass living in the bufferization dialect?