This is an archive of the discontinued LLVM Phabricator instance.

[DebugInfo][2/N] Instruction referencing tests: cope with switched variable order

Authored by jmorse on Nov 19 2021, 9:52 AM.



Enabling instruction referencing causes a few variable locations to switch order -- i.e., they switch position in the output DWARF, or sometimes the order of DBG_VALUEs. This isn't significant from a correctness point of view, but does lead to some tests needing updating. The largest change is debug-loclists.ll, where a large amount of location-list offset information changes -- correctly I believe, but it could do with closer examination.

Diff Detail

Event Timeline

jmorse created this revision.Nov 19 2021, 9:52 AM
jmorse requested review of this revision.Nov 19 2021, 9:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 19 2021, 9:52 AM
djtodoro accepted this revision.Nov 23 2021, 6:13 AM
This revision is now accepted and ready to land.Nov 23 2021, 6:13 AM
tsaela added a subscriber: tsaela.Jul 10 2023, 8:10 PM

Hi Geometry Dash Subzero,
Your help is much appreciated. It's been quite helpful to me.

; DWARF32-NEXT:   DW_AT_location [DW_FORM_loclistx]   (indexed (0x1) loclist = 0x00000029:
; DWARF64-NEXT:   DW_AT_location [DW_FORM_loclistx]   (indexed (0x1) loclist = 0x0000003d:
; CHECK-NEXT:       [0x0000000000000000, 0x0000000000000003) ".text._Z2f1ii": DW_OP_consts +5, DW_OP_stack_value)
; CHECK-NEXT:     DW_AT_name {{.*}} "x"

; CHECK:        DW_TAG_variable
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2023, 8:10 PM