- User Since
- May 29 2018, 4:24 AM (250 w, 6 d)
Tue, Mar 14
Fri, Feb 24
Feb 13 2023
Thank you so much, this has been fixed mid-investigation, apologies for the unnecessary ping.
@samparker Good morning/afternoon from the UK :)
Feb 10 2023
There is the potential for further fall out from reverting these additional patches. I strongly feel that the best course of action here is to add the UNSUPPORTED line outlined in this patch and push this issue back onto the original author who's responsible for reverting the patch that causes this to fail.
Going to revert:
@thakis that's a great idea in theory, but this has been caused by the reversion of 4/4 in this series of patches, the test was added in 2/4, so wouldn't there potentially a need to revert at least 2/4, 3/4 and 4/4, which could cause further errors/failures if 1/4 is malformed.
slight confusion on the test name, sorted now
@thakis @ChuanqiXu I have a revision up for review here https://reviews.llvm.org/D143749 that adds back the UNSUPPORTED: system-windows that was reverted in https://reviews.llvm.org/D139168
@ChuanqiXu Hi there, the revert of this patch has caused the following buildbot to start failing:
Feb 6 2023
Jan 13 2023
Nov 24 2022
Oct 20 2022
Oct 19 2022
Fixed pre-merge issues:
updated hidden-reinterpret-test types to long longs to fix windows clang compile error.
ran clang-format over changed lines in SemaCast.cpp
Oct 18 2022
Jun 30 2022
Apr 27 2022
Jun 24 2021
Looks good to this 'not such an expert in this area' (me).
May 25 2021
May 24 2021
Apologies for the missing test, here it is! :)
May 19 2021
re-uploaded new diff with more context
May 18 2021
Addressed feedback and fixed a test failure in the clang-opt-bisect tool test.
May 5 2021
Apr 28 2021
No longer required as of D98699
Apr 23 2021
Apr 19 2021
Mar 31 2021
Mar 23 2021
Hey Orlando! thanks for this. A really nice, solid reimplementation and improvement of the original work. Great code comments too.
Feb 10 2021
Feb 2 2021
this patch (probably) broke the build bot at:
Jan 28 2021
Looks good to me.
Jan 26 2021
Added more context to diff
Jan 20 2021
Jan 5 2021
The "go" method of Debugger classes in Dexter used to be called once, to launch the process. However with the new DebuggerController classes it's now used to set the target process free running until we hit a relevant source line. Alas, I'd baked the former assumption into the DbgEng driver and had the "go" method do nothing. This can lead to an infinite loop where the DebuggerController repeatedly calls "go".
Nov 6 2020
LGTM. thanks for spotting this... <hangs head in shame>
Nov 5 2020
@MaskRay duly noted, thanks for the info.
Nov 4 2020
Nov 3 2020
I'll get this committed for you shortly.
Hey Nabeel, thanks for this.
Oct 29 2020
fix for any builds that don't have lldb available:
Oct 28 2020
Oct 21 2020
Oct 20 2020
Oct 19 2020
Jun 11 2020
First off, thanks for the feedback!
I also wondered where the best place would be for this path mapping. However, I still think DebuggerBase is a good spot as the debuggers currently rely on knowing context.source_files. So whichever tool wants to use the debuggers will also have to fill context.source_files, and therefore also run in the problem of needing to remap paths to the ones used in the compilation unit. Moving this mapping into the test tool would prevent other tools from reusing it.
Also, moving this mapping into the test tool would require to make the source_files be relative paths (to the source_root_dir) before calling the debuggers.
This leads to a future me now needing to remember what kind of path is used where: An absolute file system path (test tool), a path relative to source_root_dir (DebuggerController), or a debug info path (Debugger).
Jun 10 2020
Hey and thanks for this!
Jun 5 2020
Jun 3 2020
Hi Adrian (@aprantl)
seems I've made a more mundane error of committing a diff file as part of my patch. this has been reverted for now.
@aprantl I'll take a look, thanks for pointing them out.
Jun 2 2020
Landed in commit rG81e836a5a675f6a3d9d35560fddbbb87fdf66201
Landed in commit rGbf1cdc2c6c0460b7121ac653c796ef4995b1dfa9
removed and replaced LoadDebuggerException with DebuggerException in LLDB.
May 18 2020
Updated diff to correct revision for easing future historical searches
May 15 2020
@echristo thanks for your interest. do you need any further clarification on what dexter does or how this patch fits in with the existing behaviour?
May 13 2020
missing note, dbgeng does not support the new DexLimitSteps commands as of right now.
May 12 2020
Apr 27 2020
I prefer the current approach for readabilities sake as well as separating the two method calls out.
no, this would cause file path comparisons that are case sensitive to potentially fail on drive letter for windows.