- User Since
- May 29 2018, 4:24 AM (85 w, 6 d)
Tue, Jan 14
Mon, Jan 13
I'll land this tomorrow as I'm off home now and don't want to risk getting buildbot emails all night.
addressed further feedback
thank you all for your valuable time.
Fri, Jan 10
Dec 20 2019
Dec 18 2019
Added isMetaInstruction() Check in place of debug intrinsic and KILL check
Added a new comment explaining why this is safe to do.
Thanks for explaining, this makes sense to me. Any reason to not use MI.isMetaInstruction() as the guard? That would cause CFI/lifetime/EH_LABEL instructions to be skipped in addition to debug/kill instructions - would that be reasonable?
Dec 16 2019
removed unused declarations for stack protection.
removed vendor specific string from debug information
Added a comment to the KILL instruction check.
Apologies for the lack lustre description and vagueness of all this. Also, this is late coming due to sickness. My deepest and humblest apologies. Hope this clear things up though! enjoy.
Dec 10 2019
not a problem gents, I've been summarising my thoughts and triple checking to make sure this is a sound thing to do and have a response with updated patch and (hopefully) additional tests incoming shortly.
Nov 28 2019
A very gentle and polite ping.
Nov 25 2019
thanks for the patch!
Nov 21 2019
removed superflous attributes from function declarations.
Nov 20 2019
Thanks David, it was quickly pointed out to me internally that there's a better place for the check so I rushed to get a quick build and test done before updating.
moved Kill instruction check to a more relevant place
Nov 19 2019
some super nits. Patch is huge and difficult to parse, will require several passes I feel.
Nov 12 2019
Nov 11 2019
Nov 8 2019
updated to use newly added helper function for salvage or undeffing behaviour when dropping instructions in reassociate expressions pass.
Nov 7 2019
Sep 16 2019
Aug 27 2019
Jul 17 2019
Jan 22 2019
Slight fix r351820 seems to have done the trick, many thanks!
and thanks for the patch either way, nice to know we're not in this alone.
seems like the best thing to do here is revert the original commit that broke the bots in the first place?
Jan 21 2019
very gentle and polite ping.
Jan 9 2019
> So GAS does the same thing as Clang's integrated assembler currently (pre-patch) and that behavior is problematic for GDB and LLDB?
Nov 28 2018
No problem's David,
Nov 23 2018
So, I've been poking around in MCObjectStreamer.cpp and have found the area where multiple .loc directives are emitted, however,
Nov 22 2018
I've also taken a look at GAS and tested it's behaviour and have found it mirrors clangs, that is, it will happily output line entries for multiple .loc directives with no interceding instructions - thus leading to line table entries with address delta's of 0.
Hello fellow LLVM contributors.
Nov 2 2018
Oh, I don't have commit access, are you able to commit for me Sam?
I'm happy as is.
The test failed on the following build bot:
Sep 12 2018
couple of nitpicks.
Jul 23 2018
Jul 18 2018
Jul 17 2018
updated test .cpp source description with correct source.