Slight fix r351820 seems to have done the trick, many thanks!

and thanks for the patch either way, nice to know we're not in this alone.

seems like the best thing to do here is revert the original commit that broke the bots in the first place?

Hi there,

very gentle and polite ping.

No problem's David,

So, I've been poking around in MCObjectStreamer.cpp and have found the area where multiple .loc directives are emitted, however,

I've also taken a look at GAS and tested it's behaviour and have found it mirrors clangs, that is, it will happily output line entries for multiple .loc directives with no interceding instructions - thus leading to line table entries with address delta's of 0.

Hello fellow LLVM contributors.

Oh, I don't have commit access, are you able to commit for me Sam?

I'm happy as is.

The test failed on the following build bot:

couple of nitpicks.

In D49426#1166190, @CarlosAlbertoEnciso wrote:

In D49426#1165346, @TWeaver wrote:

In D49426#1165146, @dblaikie wrote:

Could you provide a small example dump of the invalid line table you're addressing?

I fed the resulting .elf into dwarfdump with -l and got the following output:

What is the ouput generated by llvm-dwarfdump?

In D49426#1165555, @dblaikie wrote:

I feel like maybe the solution here should be in the MC integrated
assembler - to not emit zero-length sequences in the line table, regardless
of whether it's in the prologue or anywhere else?

updated test .cpp source description with correct source.

In D49426#1165146, @dblaikie wrote:

Could you provide a small example dump of the invalid line table you're addressing?