Page MenuHomePhabricator

TWeaver (Tom Weaver)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2018, 4:24 AM (120 w, 5 d)

Recent Activity

Jun 11 2020

TWeaver added a comment to D81319: [Dexter] Add --source-dir-root flag.

First off, thanks for the feedback!

I also wondered where the best place would be for this path mapping. However, I still think DebuggerBase is a good spot as the debuggers currently rely on knowing context.source_files. So whichever tool wants to use the debuggers will also have to fill context.source_files, and therefore also run in the problem of needing to remap paths to the ones used in the compilation unit. Moving this mapping into the test tool would prevent other tools from reusing it.

Also, moving this mapping into the test tool would require to make the source_files be relative paths (to the source_root_dir) before calling the debuggers.
This leads to a future me now needing to remember what kind of path is used where: An absolute file system path (test tool), a path relative to source_root_dir (DebuggerController), or a debug info path (Debugger).

WDYT?

Jun 11 2020, 10:27 AM · debug-info, Restricted Project

Jun 10 2020

TWeaver added a comment to D81319: [Dexter] Add --source-dir-root flag.

Hey and thanks for this!

Jun 10 2020, 11:05 AM · debug-info, Restricted Project

Jun 5 2020

TWeaver added a comment to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

recommitted rGc6aa829644f30d5590451b892918298f8117c985

Jun 5 2020, 6:33 AM · debug-info
TWeaver committed rGc6aa829644f3: [Dexter] Add DexLimitSteps command and ConditionalController (authored by TWeaver).
[Dexter] Add DexLimitSteps command and ConditionalController
Jun 5 2020, 4:56 AM

Jun 3 2020

TWeaver added a comment to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

Hi Adrian (@aprantl)

Jun 3 2020, 8:44 AM · debug-info
TWeaver added a reverting change for rG81e836a5a675: [Dexter] Add DexLimitSteps command and ConditionalController: rG05eabb52045f: Revert "[Dexter] Add DexLimitSteps command and ConditionalController".
Jun 3 2020, 4:55 AM
TWeaver committed rG05eabb52045f: Revert "[Dexter] Add DexLimitSteps command and ConditionalController" (authored by TWeaver).
Revert "[Dexter] Add DexLimitSteps command and ConditionalController"
Jun 3 2020, 4:55 AM
TWeaver added a comment to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

seems I've made a more mundane error of committing a diff file as part of my patch. this has been reverted for now.

Jun 3 2020, 4:53 AM · debug-info
TWeaver added a comment to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

@aprantl I'll take a look, thanks for pointing them out.

Jun 3 2020, 4:20 AM · debug-info

Jun 2 2020

TWeaver closed D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

Landed in commit rG81e836a5a675f6a3d9d35560fddbbb87fdf66201

Jun 2 2020, 9:52 AM · debug-info
TWeaver closed D78633: [Dexter] Add os.path.normcase(...) transform to test path early..

Landed in commit rGbf1cdc2c6c0460b7121ac653c796ef4995b1dfa9

Jun 2 2020, 9:52 AM · debug-info
TWeaver committed rG81e836a5a675: [Dexter] Add DexLimitSteps command and ConditionalController (authored by TWeaver).
[Dexter] Add DexLimitSteps command and ConditionalController
Jun 2 2020, 8:47 AM
TWeaver committed rGbf1cdc2c6c04: [Dexter] Add os.path.normcase(...) transform to test path early. (authored by TWeaver).
[Dexter] Add os.path.normcase(...) transform to test path early.
Jun 2 2020, 8:14 AM
TWeaver updated the diff for D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

removed and replaced LoadDebuggerException with DebuggerException in LLDB.

Jun 2 2020, 8:14 AM · debug-info

May 18 2020

TWeaver updated the diff for D69943: Attempt to Salvage Debug Info or undef intrinsics when dropping trivially deletable instructions in reassociate pass.

Updated diff to correct revision for easing future historical searches

May 18 2020, 8:34 AM · Restricted Project
TWeaver added inline comments to D80052: [docs] Sketch outline for HowToUpdateDebugInfo.rst.
May 18 2020, 3:42 AM · debug-info, Restricted Project

May 15 2020

TWeaver added inline comments to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.
May 15 2020, 9:12 AM · debug-info
TWeaver added a comment to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

@echristo thanks for your interest. do you need any further clarification on what dexter does or how this patch fits in with the existing behaviour?

May 15 2020, 7:33 AM · debug-info

May 13 2020

TWeaver added a comment to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

missing note, dbgeng does not support the new DexLimitSteps commands as of right now.

May 13 2020, 7:00 AM · debug-info

May 12 2020

TWeaver created D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.
May 12 2020, 7:29 AM · debug-info

Apr 27 2020

TWeaver added a comment to D78633: [Dexter] Add os.path.normcase(...) transform to test path early..

I prefer the current approach for readabilities sake as well as separating the two method calls out.

Apr 27 2020, 9:39 AM · debug-info
TWeaver added a comment to D78633: [Dexter] Add os.path.normcase(...) transform to test path early..

no, this would cause file path comparisons that are case sensitive to potentially fail on drive letter for windows.

Apr 27 2020, 5:51 AM · debug-info

Apr 22 2020

TWeaver updated the diff for D78633: [Dexter] Add os.path.normcase(...) transform to test path early..

removed accidental new line deletion

Apr 22 2020, 7:00 AM · debug-info
TWeaver created D78633: [Dexter] Add os.path.normcase(...) transform to test path early..
Apr 22 2020, 6:28 AM · debug-info
TWeaver added a comment to D78621: [dexter] Require python >= 3.6.

in ./debuginfo-tests/CMakeLists.txt we have the following on line 27:

Apr 22 2020, 5:55 AM · Restricted Project, debug-info
TWeaver added a comment to D78621: [dexter] Require python >= 3.6.

@jmorse I believe there's already a test in the cmake/config that checks the python version when generating the build.

Apr 22 2020, 5:55 AM · Restricted Project, debug-info
TWeaver accepted D78621: [dexter] Require python >= 3.6.

thanks for this, LGTM.

Apr 22 2020, 5:55 AM · Restricted Project, debug-info

Apr 21 2020

TWeaver added a comment to rGb1097e29d3d0: [Dexter] Fix failing clang-opt-bisect sub tool test.

fix for failing test reported at D76926

Apr 21 2020, 6:27 AM
TWeaver added a comment to D76926: [Dexter] Add Debugger Controller To Dexter.

fix for reported test failure at:

Apr 21 2020, 6:26 AM · Restricted Project, debug-info
TWeaver committed rGb1097e29d3d0: [Dexter] Fix failing clang-opt-bisect sub tool test (authored by TWeaver).
[Dexter] Fix failing clang-opt-bisect sub tool test
Apr 21 2020, 5:54 AM
TWeaver added a comment to D76926: [Dexter] Add Debugger Controller To Dexter.

thanks for reporting. this issue should now be fixed.

Apr 21 2020, 5:54 AM · Restricted Project, debug-info

Apr 20 2020

TWeaver committed rG9cf9710bb0d6: [Dexter][NFC] Add Debugger Controller To Dexter (authored by TWeaver).
[Dexter][NFC] Add Debugger Controller To Dexter
Apr 20 2020, 8:05 AM
TWeaver closed D76926: [Dexter] Add Debugger Controller To Dexter.
Apr 20 2020, 8:05 AM · Restricted Project, debug-info

Apr 1 2020

TWeaver added a comment to D76609: [DEXTER] Add support for windows in regression test suite..

The cdb tests taking longer may be a result of the dexter regression suite running along side them. SFAIK that's not intended behaviour.

Apr 1 2020, 8:27 AM · Restricted Project, debug-info

Mar 31 2020

TWeaver committed rGb6d2212f5276: [Dexter] Add support for Windows to regression test suite. (authored by TWeaver).
[Dexter] Add support for Windows to regression test suite.
Mar 31 2020, 2:46 AM
TWeaver added a comment to D76609: [DEXTER] Add support for windows in regression test suite..

I've also added an internal ticket to add darwin support to the dexter regression suite... I don't think there'll be much appetite in-house for it but if there's a clear need to add it in the future then of course we'll consider putting in the work.

Mar 31 2020, 2:42 AM · Restricted Project, debug-info
TWeaver added a comment to D76609: [DEXTER] Add support for windows in regression test suite..

Hi Davide,

Mar 31 2020, 2:42 AM · Restricted Project, debug-info
TWeaver added a comment to D76609: [DEXTER] Add support for windows in regression test suite..

I've actually mailed these via the mailing list by accident, here's a copy of what I mailed:

Mar 31 2020, 2:42 AM · Restricted Project, debug-info

Mar 27 2020

TWeaver committed rG89025da9f676: [Dexter] Add support for Windows to regression test suite. (authored by TWeaver).
[Dexter] Add support for Windows to regression test suite.
Mar 27 2020, 11:30 AM
TWeaver closed D76609: [DEXTER] Add support for windows in regression test suite..
Mar 27 2020, 11:30 AM · Restricted Project, debug-info
TWeaver added a comment to D75343: [RFC][debuginfo-tests][dexter] Add a test generation tool.

@Pierre-vh and not a problem buddy, I wish you all the best in your future endeavours, don't worry about feedback on the controller patch if it's not related to your current work! :) you get on with what you need to.

Mar 27 2020, 10:55 AM · Restricted Project, debug-info
TWeaver added a comment to D75343: [RFC][debuginfo-tests][dexter] Add a test generation tool.

The debugger controller patch is now live and awaiting review at

Mar 27 2020, 7:37 AM · Restricted Project, debug-info
TWeaver created D76926: [Dexter] Add Debugger Controller To Dexter.
Mar 27 2020, 7:05 AM · Restricted Project, debug-info
TWeaver added a comment to D75343: [RFC][debuginfo-tests][dexter] Add a test generation tool.

I hope you're keeping safe in these unprecedented times!

Mar 27 2020, 4:50 AM · Restricted Project, debug-info

Mar 23 2020

TWeaver added a reviewer for D76609: [DEXTER] Add support for windows in regression test suite.: rnk.
Mar 23 2020, 7:36 AM · Restricted Project, debug-info
TWeaver created D76609: [DEXTER] Add support for windows in regression test suite..
Mar 23 2020, 7:03 AM · Restricted Project, debug-info

Mar 16 2020

TWeaver committed rG09f4bdc03f89: [DexTer] Add step.UNKNOWN check for NoneType line numbers. (authored by TWeaver).
[DexTer] Add step.UNKNOWN check for NoneType line numbers.
Mar 16 2020, 9:49 AM
TWeaver closed D75992: [DEXTER] Add step.UNKNOWN check to DexTer for None valued steps..
Mar 16 2020, 9:49 AM · Restricted Project, debug-info

Mar 11 2020

TWeaver added inline comments to D75992: [DEXTER] Add step.UNKNOWN check to DexTer for None valued steps..
Mar 11 2020, 1:01 PM · Restricted Project, debug-info
TWeaver added inline comments to D75992: [DEXTER] Add step.UNKNOWN check to DexTer for None valued steps..
Mar 11 2020, 10:09 AM · Restricted Project, debug-info
TWeaver added inline comments to D75992: [DEXTER] Add step.UNKNOWN check to DexTer for None valued steps..
Mar 11 2020, 10:09 AM · Restricted Project, debug-info
TWeaver created D75992: [DEXTER] Add step.UNKNOWN check to DexTer for None valued steps..
Mar 11 2020, 7:58 AM · Restricted Project, debug-info

Mar 4 2020

TWeaver added a comment to D75343: [RFC][debuginfo-tests][dexter] Add a test generation tool.

Hi Pierre,

Mar 4 2020, 10:05 AM · Restricted Project, debug-info

Mar 3 2020

TWeaver added a comment to D75343: [RFC][debuginfo-tests][dexter] Add a test generation tool.

I haven't attempted to generalize my work as I entirely rely on the LLDB library for this (and I work on Linux so I can't work with any other debugger supported by Dexter)
Maybe we can try to find something together? Where do you wish to discuss this?

Mar 3 2020, 10:21 AM · Restricted Project, debug-info
TWeaver added inline comments to D75343: [RFC][debuginfo-tests][dexter] Add a test generation tool.
Mar 3 2020, 8:38 AM · Restricted Project, debug-info
TWeaver added a comment to D75343: [RFC][debuginfo-tests][dexter] Add a test generation tool.

Hi Pierre,

Mar 3 2020, 6:02 AM · Restricted Project, debug-info

Feb 12 2020

TWeaver accepted D74409: [debuginfo-tests][Dexter] Fix process creation flake-out on Windows.

LGTM

Feb 12 2020, 7:55 AM · Restricted Project
TWeaver added a comment to D74409: [debuginfo-tests][Dexter] Fix process creation flake-out on Windows.

Hi Reid,

Feb 12 2020, 6:04 AM · Restricted Project

Jan 24 2020

TWeaver committed rGf5147765ba17: [DebugInfo][LiveDebugValues] Teach Live Debug Values About Meta Instructions (authored by TWeaver).
[DebugInfo][LiveDebugValues] Teach Live Debug Values About Meta Instructions
Jan 24 2020, 8:32 AM
TWeaver closed D73210: [OPT_DPG][LIVEDEBUGVALUES] Teach Live Debug Values About Meta Instructions.
Jan 24 2020, 8:32 AM · Restricted Project, debug-info

Jan 23 2020

TWeaver added a comment to D73210: [OPT_DPG][LIVEDEBUGVALUES] Teach Live Debug Values About Meta Instructions.

Hi David,

Jan 23 2020, 10:18 AM · Restricted Project, debug-info
TWeaver added inline comments to D73210: [OPT_DPG][LIVEDEBUGVALUES] Teach Live Debug Values About Meta Instructions.
Jan 23 2020, 10:18 AM · Restricted Project, debug-info
TWeaver updated the diff for D73210: [OPT_DPG][LIVEDEBUGVALUES] Teach Live Debug Values About Meta Instructions.

KILL instruction is no reinstated and failing check line has been removed.

Jan 23 2020, 6:57 AM · Restricted Project, debug-info
TWeaver added a reviewer for D73210: [OPT_DPG][LIVEDEBUGVALUES] Teach Live Debug Values About Meta Instructions: djtodoro.
Jan 23 2020, 6:03 AM · Restricted Project, debug-info
TWeaver added a comment to D73210: [OPT_DPG][LIVEDEBUGVALUES] Teach Live Debug Values About Meta Instructions.

I missed adding you as a reviewer @djtodoro , my apologies. This has been rectified.

Jan 23 2020, 6:03 AM · Restricted Project, debug-info

Jan 22 2020

TWeaver added inline comments to D73210: [OPT_DPG][LIVEDEBUGVALUES] Teach Live Debug Values About Meta Instructions.
Jan 22 2020, 9:55 AM · Restricted Project, debug-info
TWeaver created D73210: [OPT_DPG][LIVEDEBUGVALUES] Teach Live Debug Values About Meta Instructions.
Jan 22 2020, 9:09 AM · Restricted Project, debug-info
TWeaver closed D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

Hello Everyone,

Jan 22 2020, 7:23 AM · Restricted Project, debug-info

Jan 14 2020

TWeaver committed rGe7b2d9f4702c: [DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour Tests. (authored by TWeaver).
[DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour Tests.
Jan 14 2020, 7:54 AM
TWeaver committed rGb10f6b711227: Revert "[DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour… (authored by TWeaver).
Revert "[DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour…
Jan 14 2020, 7:15 AM
TWeaver added a reverting change for rG35787e3a062a: [DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour Tests.: rGb10f6b711227: Revert "[DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour….
Jan 14 2020, 7:15 AM
TWeaver committed rG35787e3a062a: [DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour Tests. (authored by TWeaver).
[DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour Tests.
Jan 14 2020, 6:46 AM
TWeaver closed D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .
Jan 14 2020, 6:46 AM · Restricted Project, debug-info

Jan 13 2020

TWeaver added a comment to D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .

I'll land this tomorrow as I'm off home now and don't want to risk getting buildbot emails all night.

Jan 13 2020, 10:36 AM · Restricted Project, debug-info
TWeaver updated the diff for D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .

updated diff

Jan 13 2020, 10:35 AM · Restricted Project, debug-info
TWeaver added a comment to D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .

addressed further feedback

Jan 13 2020, 10:35 AM · Restricted Project, debug-info
TWeaver updated the diff for D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .

address feedback

Jan 13 2020, 9:28 AM · Restricted Project, debug-info
TWeaver added a comment to D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .

thank you all for your valuable time.

Jan 13 2020, 9:28 AM · Restricted Project, debug-info

Jan 10 2020

TWeaver created D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .
Jan 10 2020, 8:43 AM · Restricted Project, debug-info

Dec 20 2019

TWeaver committed rG453dc4d7ec5a: [OPT-DBG] Teach DbgEntityHistoryCalculator about meta-instructions. (authored by TWeaver).
[OPT-DBG] Teach DbgEntityHistoryCalculator about meta-instructions.
Dec 20 2019, 6:09 AM

Dec 18 2019

TWeaver updated the diff for D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

Added isMetaInstruction() Check in place of debug intrinsic and KILL check
Added a new comment explaining why this is safe to do.

Dec 18 2019, 6:33 AM · Restricted Project, debug-info
TWeaver added a comment to D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

Thanks for explaining, this makes sense to me. Any reason to not use MI.isMetaInstruction() as the guard? That would cause CFI/lifetime/EH_LABEL instructions to be skipped in addition to debug/kill instructions - would that be reasonable?

Dec 18 2019, 5:55 AM · Restricted Project, debug-info

Dec 16 2019

TWeaver added inline comments to D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..
Dec 16 2019, 9:02 AM · Restricted Project, debug-info
TWeaver updated the diff for D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

removed unused declarations for stack protection.

Dec 16 2019, 8:52 AM · Restricted Project, debug-info
TWeaver updated the diff for D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

removed vendor specific string from debug information

Dec 16 2019, 8:34 AM · Restricted Project, debug-info
TWeaver updated the diff for D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

Added a comment to the KILL instruction check.

Dec 16 2019, 7:57 AM · Restricted Project, debug-info
TWeaver updated the summary of D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..
Dec 16 2019, 7:48 AM · Restricted Project, debug-info
TWeaver added a comment to D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

Apologies for the lack lustre description and vagueness of all this. Also, this is late coming due to sickness. My deepest and humblest apologies. Hope this clear things up though! enjoy.

Dec 16 2019, 7:48 AM · Restricted Project, debug-info

Dec 10 2019

TWeaver added a comment to D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

not a problem gents, I've been summarising my thoughts and triple checking to make sure this is a sound thing to do and have a response with updated patch and (hopefully) additional tests incoming shortly.

Dec 10 2019, 2:50 AM · Restricted Project, debug-info

Nov 28 2019

TWeaver added a comment to D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

A very gentle and polite ping.

Nov 28 2019, 4:14 AM · Restricted Project, debug-info

Nov 25 2019

TWeaver added a comment to D70642: [DebugInfo] Support for DW_OP_implicit_pointer (DW_OP_LLVM_argN).

thanks for the patch!

Nov 25 2019, 1:09 AM · debug-info, Restricted Project

Nov 21 2019

TWeaver updated the diff for D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

removed superflous attributes from function declarations.

Nov 21 2019, 8:52 AM · Restricted Project, debug-info
TWeaver added inline comments to D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..
Nov 21 2019, 8:52 AM · Restricted Project, debug-info

Nov 20 2019

TWeaver added a comment to D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

Thanks David, it was quickly pointed out to me internally that there's a better place for the check so I rushed to get a quick build and test done before updating.

Nov 20 2019, 9:08 AM · Restricted Project, debug-info
TWeaver added a reviewer for D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions.: dstenb.
Nov 20 2019, 8:43 AM · Restricted Project, debug-info
TWeaver updated the diff for D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

moved Kill instruction check to a more relevant place

Nov 20 2019, 8:43 AM · Restricted Project, debug-info
TWeaver created D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..
Nov 20 2019, 8:16 AM · Restricted Project, debug-info

Nov 19 2019

TWeaver added a comment to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

some super nits. Patch is huge and difficult to parse, will require several passes I feel.

Nov 19 2019, 6:30 AM · Restricted Project, debug-info

Nov 12 2019

TWeaver committed rG41c3f76dcd0d: [DBG][OPT] Attempt to salvage or undef debug info when removing trivially… (authored by TWeaver).
[DBG][OPT] Attempt to salvage or undef debug info when removing trivially…
Nov 12 2019, 7:22 AM

Nov 11 2019

TWeaver committed rG9f48a160dd3f: Revert "[DBG][OPT] Attempt to salvage or undef debug info when removing… (authored by TWeaver).
Revert "[DBG][OPT] Attempt to salvage or undef debug info when removing…
Nov 11 2019, 6:14 AM