Page MenuHomePhabricator

TWeaver (Tom Weaver)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2018, 4:24 AM (250 w, 6 d)

Recent Activity

Tue, Mar 14

TWeaver added a comment to D145227: [LLVM][OHOS] Clang toolchain and targets.

Good morning,

Tue, Mar 14, 4:41 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Feb 24

TWeaver added a comment to D139902: IR: Add nofpclass parameter attribute.

Hello all,

Fri, Feb 24, 5:27 AM · Restricted Project, Restricted Project

Feb 13 2023

TWeaver added a comment to D140982: [HardwareLoops] NewPM support.

Thank you so much, this has been fixed mid-investigation, apologies for the unnecessary ping.

Feb 13 2023, 4:57 AM · Restricted Project, Restricted Project, Restricted Project
TWeaver added a comment to D140982: [HardwareLoops] NewPM support.

@samparker Good morning/afternoon from the UK :)

Feb 13 2023, 4:55 AM · Restricted Project, Restricted Project, Restricted Project

Feb 10 2023

TWeaver closed D143749: [ClangDepScan] Add UNSUPPORTED: system-windows to failing P1689.cppm test.

Committed in https://reviews.llvm.org/rG79a3803bb2ccdd852436cd1653017a1159a12157

Feb 10 2023, 10:44 AM · Restricted Project, Restricted Project
TWeaver committed rG79a3803bb2cc: [ClangScanDeps] Add UNSUPPORTED: system-windows to test P1689.cppm (authored by TWeaver).
[ClangScanDeps] Add UNSUPPORTED: system-windows to test P1689.cppm
Feb 10 2023, 10:32 AM · Restricted Project, Restricted Project
TWeaver reclaimed D143749: [ClangDepScan] Add UNSUPPORTED: system-windows to failing P1689.cppm test.

There is the potential for further fall out from reverting these additional patches. I strongly feel that the best course of action here is to add the UNSUPPORTED line outlined in this patch and push this issue back onto the original author who's responsible for reverting the patch that causes this to fail.

Feb 10 2023, 10:23 AM · Restricted Project, Restricted Project
TWeaver abandoned D143749: [ClangDepScan] Add UNSUPPORTED: system-windows to failing P1689.cppm test.

Going to revert:

Feb 10 2023, 9:24 AM · Restricted Project, Restricted Project
TWeaver added a comment to D143749: [ClangDepScan] Add UNSUPPORTED: system-windows to failing P1689.cppm test.

@thakis that's a great idea in theory, but this has been caused by the reversion of 4/4 in this series of patches, the test was added in 2/4, so wouldn't there potentially a need to revert at least 2/4, 3/4 and 4/4, which could cause further errors/failures if 1/4 is malformed.

Feb 10 2023, 9:04 AM · Restricted Project, Restricted Project
TWeaver updated the diff for D143749: [ClangDepScan] Add UNSUPPORTED: system-windows to failing P1689.cppm test.

slight confusion on the test name, sorted now

Feb 10 2023, 8:57 AM · Restricted Project, Restricted Project
TWeaver updated the summary of D143749: [ClangDepScan] Add UNSUPPORTED: system-windows to failing P1689.cppm test.
Feb 10 2023, 8:55 AM · Restricted Project, Restricted Project
TWeaver added a comment to D137527: [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4).

@thakis @ChuanqiXu I have a revision up for review here https://reviews.llvm.org/D143749 that adds back the UNSUPPORTED: system-windows that was reverted in https://reviews.llvm.org/D139168

Feb 10 2023, 8:52 AM · Restricted Project, Restricted Project
TWeaver requested review of D143749: [ClangDepScan] Add UNSUPPORTED: system-windows to failing P1689.cppm test.
Feb 10 2023, 8:51 AM · Restricted Project, Restricted Project
TWeaver added a comment to D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4).

@ChuanqiXu Hi there, the revert of this patch has caused the following buildbot to start failing:

Feb 10 2023, 5:22 AM · Restricted Project, Restricted Project

Feb 6 2023

TWeaver added a comment to D142606: Lazyly initialize uncommon toolchain detector.

Hello all,

Feb 6 2023, 6:42 AM · Restricted Project, Restricted Project

Jan 13 2023

TWeaver abandoned D136156: [Clang][Diagnostic] Add hidden-reinterpret-cast diagnostic warning.

Hi all,

Jan 13 2023, 1:30 AM · Restricted Project

Nov 24 2022

TWeaver added a comment to D136156: [Clang][Diagnostic] Add hidden-reinterpret-cast diagnostic warning.

Hello all,

Nov 24 2022, 6:00 AM · Restricted Project

Oct 20 2022

TWeaver updated subscribers of D136156: [Clang][Diagnostic] Add hidden-reinterpret-cast diagnostic warning.
Oct 20 2022, 4:10 AM · Restricted Project

Oct 19 2022

TWeaver updated the diff for D136156: [Clang][Diagnostic] Add hidden-reinterpret-cast diagnostic warning.

Fixed pre-merge issues:
updated hidden-reinterpret-test types to long longs to fix windows clang compile error.
ran clang-format over changed lines in SemaCast.cpp

Oct 19 2022, 6:43 AM · Restricted Project

Oct 18 2022

TWeaver updated subscribers of D136156: [Clang][Diagnostic] Add hidden-reinterpret-cast diagnostic warning.
Oct 18 2022, 3:42 AM · Restricted Project
TWeaver updated the summary of D136156: [Clang][Diagnostic] Add hidden-reinterpret-cast diagnostic warning.
Oct 18 2022, 3:39 AM · Restricted Project
TWeaver updated the summary of D136156: [Clang][Diagnostic] Add hidden-reinterpret-cast diagnostic warning.
Oct 18 2022, 3:35 AM · Restricted Project
TWeaver requested review of D136156: [Clang][Diagnostic] Add hidden-reinterpret-cast diagnostic warning.
Oct 18 2022, 3:33 AM · Restricted Project

Jun 30 2022

Herald added a project to D77752: [llvm] Machine Learned policy for inlining -Oz: Restricted Project.
Jun 30 2022, 6:36 AM · Restricted Project, Restricted Project

Apr 27 2022

TWeaver added a comment to D114115: [Driver] Support for compressed debug info on Fuchsia.

Hello all,

Apr 27 2022, 4:32 AM · Restricted Project, Restricted Project
TWeaver added a reverting change for rG19190cc651ef: [Driver] Support for compressed debug info on Fuchsia: rG31ff40042d05: Revert "[Driver] Support for compressed debug info on Fuchsia".
Apr 27 2022, 4:31 AM · Restricted Project, Restricted Project
TWeaver committed rG31ff40042d05: Revert "[Driver] Support for compressed debug info on Fuchsia" (authored by TWeaver).
Revert "[Driver] Support for compressed debug info on Fuchsia"
Apr 27 2022, 4:31 AM · Restricted Project, Restricted Project
TWeaver added a reverting change for D114115: [Driver] Support for compressed debug info on Fuchsia: rG31ff40042d05: Revert "[Driver] Support for compressed debug info on Fuchsia".
Apr 27 2022, 4:30 AM · Restricted Project, Restricted Project

Jun 24 2021

TWeaver added a comment to D86814: [DebugInstrRef][3/3] Follow DBG_PHI instructions through LiveDebugValues..

Looks good to this 'not such an expert in this area' (me).

Jun 24 2021, 3:06 AM · Restricted Project

May 25 2021

TWeaver committed rGfc0acd10c0ab: [Dexter] Remove erroneously added diff file (authored by TWeaver).
[Dexter] Remove erroneously added diff file
May 25 2021, 5:37 AM
TWeaver committed rGc2c2be44ed64: [Dexter] Add DexDeclareFile command to Dexter (authored by TWeaver).
[Dexter] Add DexDeclareFile command to Dexter
May 25 2021, 4:47 AM
TWeaver closed D99651: [Dexter] Implement DexDeclareFile, a new Dexter command.
May 25 2021, 4:47 AM · Restricted Project, debug-info

May 24 2021

TWeaver added a comment to D99651: [Dexter] Implement DexDeclareFile, a new Dexter command.

Apologies for the missing test, here it is! :)

May 24 2021, 7:41 AM · Restricted Project, debug-info

May 19 2021

TWeaver updated the diff for D99651: [Dexter] Implement DexDeclareFile, a new Dexter command.

re-uploaded new diff with more context

May 19 2021, 3:37 AM · Restricted Project, debug-info

May 18 2021

TWeaver updated the diff for D99651: [Dexter] Implement DexDeclareFile, a new Dexter command.

Addressed feedback and fixed a test failure in the clang-opt-bisect tool test.

May 18 2021, 9:38 AM · Restricted Project, debug-info

May 5 2021

TWeaver added inline comments to D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list.
May 5 2021, 8:26 AM · Restricted Project
TWeaver added a comment to D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list.
May 5 2021, 8:03 AM · Restricted Project
TWeaver added inline comments to D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list.
May 5 2021, 6:06 AM · Restricted Project

Apr 28 2021

TWeaver closed D95045: [Dexter] add normcase conversion to visual studio's 'delete conditional breakpoint' method.

No longer required as of D98699

Apr 28 2021, 7:20 AM · debug-info

Apr 23 2021

TWeaver accepted D101055: [dexter] Add keyword argument 'on_line' to DexLabel.

Nice! LGTM

Apr 23 2021, 3:57 AM · Restricted Project, debug-info

Apr 19 2021

TWeaver added inline comments to D99651: [Dexter] Implement DexDeclareFile, a new Dexter command.
Apr 19 2021, 9:11 AM · Restricted Project, debug-info

Mar 31 2021

TWeaver requested review of D99651: [Dexter] Implement DexDeclareFile, a new Dexter command.
Mar 31 2021, 4:37 AM · Restricted Project, debug-info

Mar 23 2021

TWeaver accepted D98699: [dexter] Fix DexLimitSteps when breakpoint can't be set at requested location.

Hey Orlando! thanks for this. A really nice, solid reimplementation and improvement of the original work. Great code comments too.

Mar 23 2021, 4:01 AM · Restricted Project

Feb 10 2021

TWeaver added a reverting change for rGa743702a1f48: Revert "[clang][driver] Only warn once about invalid library values": rGb86a763afb9a: Revert "Revert "[clang][driver] Only warn once about invalid library values"".
Feb 10 2021, 8:41 AM
TWeaver committed rGb86a763afb9a: Revert "Revert "[clang][driver] Only warn once about invalid library values"" (authored by TWeaver).
Revert "Revert "[clang][driver] Only warn once about invalid library values""
Feb 10 2021, 8:41 AM
TWeaver added a reverting change for rGa6439b52088b: [clang][driver] Only warn once about invalid library values: rGa743702a1f48: Revert "[clang][driver] Only warn once about invalid library values".
Feb 10 2021, 8:38 AM
TWeaver committed rGa743702a1f48: Revert "[clang][driver] Only warn once about invalid library values" (authored by TWeaver).
Revert "[clang][driver] Only warn once about invalid library values"
Feb 10 2021, 8:38 AM
TWeaver added a reverting change for D95915: [clang][driver] Only warn once about invalid -stdlib value: rGa743702a1f48: Revert "[clang][driver] Only warn once about invalid library values".
Feb 10 2021, 8:38 AM · Restricted Project

Feb 2 2021

TWeaver added a reverting change for rGdf3e39f60b35: [InstrProfiling] Use !associated metadata for counters, data and values: rG4f1320b77d17: Revert "[InstrProfiling] Use !associated metadata for counters, data and values".
Feb 2 2021, 6:20 AM
TWeaver added a reverting change for D76802: [InstrProfiling] Use !associated metadata for counters, data and values: rG4f1320b77d17: Revert "[InstrProfiling] Use !associated metadata for counters, data and values".
Feb 2 2021, 6:20 AM · Restricted Project, Restricted Project, Restricted Project
TWeaver committed rG4f1320b77d17: Revert "[InstrProfiling] Use !associated metadata for counters, data and values" (authored by TWeaver).
Revert "[InstrProfiling] Use !associated metadata for counters, data and values"
Feb 2 2021, 6:20 AM
TWeaver added a comment to D76802: [InstrProfiling] Use !associated metadata for counters, data and values.

this patch (probably) broke the build bot at:

Feb 2 2021, 5:23 AM · Restricted Project, Restricted Project, Restricted Project

Jan 28 2021

TWeaver accepted D91737: [Dexter] Avoid potentially infinite loop in dbgeng driver.

Looks good to me.

Jan 28 2021, 9:11 AM · Restricted Project

Jan 26 2021

TWeaver added a comment to D95045: [Dexter] add normcase conversion to visual studio's 'delete conditional breakpoint' method.

This looks good to me - does this need a test case?

Jan 26 2021, 4:19 AM · debug-info
TWeaver updated the diff for D95045: [Dexter] add normcase conversion to visual studio's 'delete conditional breakpoint' method.

Added more context to diff

Jan 26 2021, 4:17 AM · debug-info

Jan 20 2021

TWeaver updated subscribers of D95045: [Dexter] add normcase conversion to visual studio's 'delete conditional breakpoint' method.
Jan 20 2021, 7:09 AM · debug-info
TWeaver requested review of D95045: [Dexter] add normcase conversion to visual studio's 'delete conditional breakpoint' method.
Jan 20 2021, 6:54 AM · debug-info

Jan 5 2021

TWeaver added a comment to D91737: [Dexter] Avoid potentially infinite loop in dbgeng driver.

The "go" method of Debugger classes in Dexter used to be called once, to launch the process. However with the new DebuggerController classes it's now used to set the target process free running until we hit a relevant source line. Alas, I'd baked the former assumption into the DbgEng driver and had the "go" method do nothing. This can lead to an infinite loop where the DebuggerController repeatedly calls "go".

Jan 5 2021, 9:32 AM · Restricted Project

Nov 6 2020

TWeaver accepted D90931: [debuginfo-tests] NFC: Move test that was committed to the wrong location.

LGTM. thanks for spotting this... <hangs head in shame>

Nov 6 2020, 5:22 AM · debug-info, Restricted Project

Nov 5 2020

TWeaver added a comment to D89803: [dexter] Add support for Visual Studio 2019 to Dexter.

@MaskRay duly noted, thanks for the info.

Nov 5 2020, 6:55 AM · Restricted Project, debug-info

Nov 4 2020

TWeaver committed rG3ebcef4b7377: [Dexter] add visual studio 2019 debugger support (authored by n-omer).
[Dexter] add visual studio 2019 debugger support
Nov 4 2020, 8:58 AM
TWeaver closed D89803: [dexter] Add support for Visual Studio 2019 to Dexter.
Nov 4 2020, 8:58 AM · Restricted Project, debug-info
TWeaver committed rG91c3c67c407d: [Dexter] add an optnone attribute debug experience test for loops. (authored by n-omer).
[Dexter] add an optnone attribute debug experience test for loops.
Nov 4 2020, 8:55 AM
TWeaver closed D89873: [debuginfo-tests] [dexter] Add test to check debug experience with __attribute__((optnone)).
Nov 4 2020, 8:55 AM · Restricted Project, debug-info

Nov 3 2020

TWeaver added a comment to D89873: [debuginfo-tests] [dexter] Add test to check debug experience with __attribute__((optnone)).

I'll get this committed for you shortly.

Nov 3 2020, 6:32 AM · Restricted Project, debug-info
TWeaver accepted D89873: [debuginfo-tests] [dexter] Add test to check debug experience with __attribute__((optnone)).

Hey Nabeel, thanks for this.

Nov 3 2020, 6:32 AM · Restricted Project, debug-info

Oct 29 2020

TWeaver added a comment to D89462: [debuginfo-tests] [dexter] Add tests to check debug experience.

fix for any builds that don't have lldb available:

Oct 29 2020, 4:45 AM · Restricted Project, debug-info

Oct 28 2020

TWeaver committed rGf2f4554f8804: [debuginfo-tests][dexter] add requires lldb to two tests (authored by TWeaver).
[debuginfo-tests][dexter] add requires lldb to two tests
Oct 28 2020, 10:34 AM
TWeaver accepted D89803: [dexter] Add support for Visual Studio 2019 to Dexter.

Hi Nabeel,

Oct 28 2020, 8:36 AM · Restricted Project, debug-info
TWeaver committed rGafc44efc262b: [debuginfo-tests][dexter] Add two new debug experience tests (authored by n-omer).
[debuginfo-tests][dexter] Add two new debug experience tests
Oct 28 2020, 7:24 AM
TWeaver closed D89462: [debuginfo-tests] [dexter] Add tests to check debug experience.
Oct 28 2020, 7:23 AM · Restricted Project, debug-info
TWeaver added a comment to D89462: [debuginfo-tests] [dexter] Add tests to check debug experience.

Hi Nabeel,

Oct 28 2020, 7:08 AM · Restricted Project, debug-info

Oct 21 2020

TWeaver closed D89689: [debuginfo-tests] [dexter] Add missing entries to the dexter docs table of contents.
Oct 21 2020, 5:59 AM · debug-info
TWeaver added a project to D89803: [dexter] Add support for Visual Studio 2019 to Dexter: debug-info.
Oct 21 2020, 5:59 AM · Restricted Project, debug-info

Oct 20 2020

TWeaver added a comment to rG7d8c19a4e9ed: [Dexter][NFC] Add Missing Commands to Commands.md Contents.

https://reviews.llvm.org/D89689

Oct 20 2020, 3:21 AM
TWeaver added a comment to D89689: [debuginfo-tests] [dexter] Add missing entries to the dexter docs table of contents.

landed in rG7d8c19a4e9ed8f39eda0f0f383d5ff8f1485471b

Oct 20 2020, 3:21 AM · debug-info

Oct 19 2020

TWeaver committed rG7d8c19a4e9ed: [Dexter][NFC] Add Missing Commands to Commands.md Contents (authored by n-omer).
[Dexter][NFC] Add Missing Commands to Commands.md Contents
Oct 19 2020, 8:39 AM
TWeaver accepted D89689: [debuginfo-tests] [dexter] Add missing entries to the dexter docs table of contents.

Hi Nabeel,

Oct 19 2020, 6:19 AM · debug-info

Jun 11 2020

TWeaver added a comment to D81319: [Dexter] Add --source-dir-root flag.

First off, thanks for the feedback!

I also wondered where the best place would be for this path mapping. However, I still think DebuggerBase is a good spot as the debuggers currently rely on knowing context.source_files. So whichever tool wants to use the debuggers will also have to fill context.source_files, and therefore also run in the problem of needing to remap paths to the ones used in the compilation unit. Moving this mapping into the test tool would prevent other tools from reusing it.

Also, moving this mapping into the test tool would require to make the source_files be relative paths (to the source_root_dir) before calling the debuggers.
This leads to a future me now needing to remember what kind of path is used where: An absolute file system path (test tool), a path relative to source_root_dir (DebuggerController), or a debug info path (Debugger).

WDYT?

Jun 11 2020, 10:27 AM · debug-info, Restricted Project

Jun 10 2020

TWeaver added a comment to D81319: [Dexter] Add --source-dir-root flag.

Hey and thanks for this!

Jun 10 2020, 11:05 AM · debug-info, Restricted Project

Jun 5 2020

TWeaver added a comment to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

recommitted rGc6aa829644f30d5590451b892918298f8117c985

Jun 5 2020, 6:33 AM · debug-info
TWeaver committed rGc6aa829644f3: [Dexter] Add DexLimitSteps command and ConditionalController (authored by TWeaver).
[Dexter] Add DexLimitSteps command and ConditionalController
Jun 5 2020, 4:56 AM

Jun 3 2020

TWeaver added a comment to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

Hi Adrian (@aprantl)

Jun 3 2020, 8:44 AM · debug-info
TWeaver added a reverting change for rG81e836a5a675: [Dexter] Add DexLimitSteps command and ConditionalController: rG05eabb52045f: Revert "[Dexter] Add DexLimitSteps command and ConditionalController".
Jun 3 2020, 4:55 AM
TWeaver committed rG05eabb52045f: Revert "[Dexter] Add DexLimitSteps command and ConditionalController" (authored by TWeaver).
Revert "[Dexter] Add DexLimitSteps command and ConditionalController"
Jun 3 2020, 4:55 AM
TWeaver added a comment to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

seems I've made a more mundane error of committing a diff file as part of my patch. this has been reverted for now.

Jun 3 2020, 4:53 AM · debug-info
TWeaver added a comment to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

@aprantl I'll take a look, thanks for pointing them out.

Jun 3 2020, 4:20 AM · debug-info

Jun 2 2020

TWeaver closed D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

Landed in commit rG81e836a5a675f6a3d9d35560fddbbb87fdf66201

Jun 2 2020, 9:52 AM · debug-info
TWeaver closed D78633: [Dexter] Add os.path.normcase(...) transform to test path early..

Landed in commit rGbf1cdc2c6c0460b7121ac653c796ef4995b1dfa9

Jun 2 2020, 9:52 AM · debug-info
TWeaver committed rG81e836a5a675: [Dexter] Add DexLimitSteps command and ConditionalController (authored by TWeaver).
[Dexter] Add DexLimitSteps command and ConditionalController
Jun 2 2020, 8:47 AM
TWeaver committed rGbf1cdc2c6c04: [Dexter] Add os.path.normcase(...) transform to test path early. (authored by TWeaver).
[Dexter] Add os.path.normcase(...) transform to test path early.
Jun 2 2020, 8:14 AM
TWeaver updated the diff for D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

removed and replaced LoadDebuggerException with DebuggerException in LLDB.

Jun 2 2020, 8:14 AM · debug-info

May 18 2020

TWeaver updated the diff for D69943: Attempt to Salvage Debug Info or undef intrinsics when dropping trivially deletable instructions in reassociate pass.

Updated diff to correct revision for easing future historical searches

May 18 2020, 8:34 AM · Restricted Project
TWeaver added inline comments to D80052: [docs] Sketch outline for HowToUpdateDebugInfo.rst.
May 18 2020, 3:42 AM · debug-info, Restricted Project

May 15 2020

TWeaver added inline comments to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.
May 15 2020, 9:12 AM · debug-info
TWeaver added a comment to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

@echristo thanks for your interest. do you need any further clarification on what dexter does or how this patch fits in with the existing behaviour?

May 15 2020, 7:33 AM · debug-info

May 13 2020

TWeaver added a comment to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

missing note, dbgeng does not support the new DexLimitSteps commands as of right now.

May 13 2020, 7:00 AM · debug-info

May 12 2020

TWeaver created D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.
May 12 2020, 7:29 AM · debug-info

Apr 27 2020

TWeaver added a comment to D78633: [Dexter] Add os.path.normcase(...) transform to test path early..

I prefer the current approach for readabilities sake as well as separating the two method calls out.

Apr 27 2020, 9:39 AM · debug-info
TWeaver added a comment to D78633: [Dexter] Add os.path.normcase(...) transform to test path early..

no, this would cause file path comparisons that are case sensitive to potentially fail on drive letter for windows.

Apr 27 2020, 5:51 AM · debug-info