Page MenuHomePhabricator

TWeaver (Tom Weaver)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2018, 4:24 AM (85 w, 6 d)

Recent Activity

Tue, Jan 14

TWeaver committed rGe7b2d9f4702c: [DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour Tests. (authored by TWeaver).
[DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour Tests.
Tue, Jan 14, 7:54 AM
TWeaver committed rGb10f6b711227: Revert "[DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour… (authored by TWeaver).
Revert "[DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour…
Tue, Jan 14, 7:15 AM
TWeaver added a reverting change for rG35787e3a062a: [DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour Tests.: rGb10f6b711227: Revert "[DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour….
Tue, Jan 14, 7:15 AM
TWeaver committed rG35787e3a062a: [DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour Tests. (authored by TWeaver).
[DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour Tests.
Tue, Jan 14, 6:46 AM
TWeaver closed D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .
Tue, Jan 14, 6:46 AM · Restricted Project, debug-info

Mon, Jan 13

TWeaver added a comment to D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .

I'll land this tomorrow as I'm off home now and don't want to risk getting buildbot emails all night.

Mon, Jan 13, 10:36 AM · Restricted Project, debug-info
TWeaver updated the diff for D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .

updated diff

Mon, Jan 13, 10:35 AM · Restricted Project, debug-info
TWeaver added a comment to D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .

addressed further feedback

Mon, Jan 13, 10:35 AM · Restricted Project, debug-info
TWeaver updated the diff for D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .

address feedback

Mon, Jan 13, 9:28 AM · Restricted Project, debug-info
TWeaver added a comment to D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .

thank you all for your valuable time.

Mon, Jan 13, 9:28 AM · Restricted Project, debug-info

Fri, Jan 10

TWeaver created D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .
Fri, Jan 10, 8:43 AM · Restricted Project, debug-info

Dec 20 2019

TWeaver committed rG453dc4d7ec5a: [OPT-DBG] Teach DbgEntityHistoryCalculator about meta-instructions. (authored by TWeaver).
[OPT-DBG] Teach DbgEntityHistoryCalculator about meta-instructions.
Dec 20 2019, 6:09 AM

Dec 18 2019

TWeaver updated the diff for D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

Added isMetaInstruction() Check in place of debug intrinsic and KILL check
Added a new comment explaining why this is safe to do.

Dec 18 2019, 6:33 AM · Restricted Project, debug-info
TWeaver added a comment to D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

Thanks for explaining, this makes sense to me. Any reason to not use MI.isMetaInstruction() as the guard? That would cause CFI/lifetime/EH_LABEL instructions to be skipped in addition to debug/kill instructions - would that be reasonable?

Dec 18 2019, 5:55 AM · Restricted Project, debug-info

Dec 16 2019

TWeaver added inline comments to D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..
Dec 16 2019, 9:02 AM · Restricted Project, debug-info
TWeaver updated the diff for D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

removed unused declarations for stack protection.

Dec 16 2019, 8:52 AM · Restricted Project, debug-info
TWeaver updated the diff for D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

removed vendor specific string from debug information

Dec 16 2019, 8:34 AM · Restricted Project, debug-info
TWeaver updated the diff for D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

Added a comment to the KILL instruction check.

Dec 16 2019, 7:57 AM · Restricted Project, debug-info
TWeaver updated the summary of D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..
Dec 16 2019, 7:48 AM · Restricted Project, debug-info
TWeaver added a comment to D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

Apologies for the lack lustre description and vagueness of all this. Also, this is late coming due to sickness. My deepest and humblest apologies. Hope this clear things up though! enjoy.

Dec 16 2019, 7:48 AM · Restricted Project, debug-info

Dec 10 2019

TWeaver added a comment to D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

not a problem gents, I've been summarising my thoughts and triple checking to make sure this is a sound thing to do and have a response with updated patch and (hopefully) additional tests incoming shortly.

Dec 10 2019, 2:50 AM · Restricted Project, debug-info

Nov 28 2019

TWeaver added a comment to D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

A very gentle and polite ping.

Nov 28 2019, 4:14 AM · Restricted Project, debug-info

Nov 25 2019

TWeaver added a comment to D70642: [DebugInfo] Support for DW_OP_implicit_pointer (DW_OP_LLVM_argN).

thanks for the patch!

Nov 25 2019, 1:09 AM · debug-info, Restricted Project

Nov 21 2019

TWeaver updated the diff for D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

removed superflous attributes from function declarations.

Nov 21 2019, 8:52 AM · Restricted Project, debug-info
TWeaver added inline comments to D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..
Nov 21 2019, 8:52 AM · Restricted Project, debug-info

Nov 20 2019

TWeaver added a comment to D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

Thanks David, it was quickly pointed out to me internally that there's a better place for the check so I rushed to get a quick build and test done before updating.

Nov 20 2019, 9:08 AM · Restricted Project, debug-info
TWeaver added a reviewer for D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions.: dstenb.
Nov 20 2019, 8:43 AM · Restricted Project, debug-info
TWeaver updated the diff for D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

moved Kill instruction check to a more relevant place

Nov 20 2019, 8:43 AM · Restricted Project, debug-info
TWeaver created D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..
Nov 20 2019, 8:16 AM · Restricted Project, debug-info

Nov 19 2019

TWeaver added a comment to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

some super nits. Patch is huge and difficult to parse, will require several passes I feel.

Nov 19 2019, 6:30 AM · Restricted Project, debug-info

Nov 12 2019

TWeaver committed rG41c3f76dcd0d: [DBG][OPT] Attempt to salvage or undef debug info when removing trivially… (authored by TWeaver).
[DBG][OPT] Attempt to salvage or undef debug info when removing trivially…
Nov 12 2019, 7:22 AM

Nov 11 2019

TWeaver committed rG9f48a160dd3f: Revert "[DBG][OPT] Attempt to salvage or undef debug info when removing… (authored by TWeaver).
Revert "[DBG][OPT] Attempt to salvage or undef debug info when removing…
Nov 11 2019, 6:14 AM
TWeaver added a reverting change for rG1984a27db58e: [DBG][OPT] Attempt to salvage or undef debug info when removing trivially…: rG9f48a160dd3f: Revert "[DBG][OPT] Attempt to salvage or undef debug info when removing….
Nov 11 2019, 6:14 AM
TWeaver committed rG1984a27db58e: [DBG][OPT] Attempt to salvage or undef debug info when removing trivially… (authored by TWeaver).
[DBG][OPT] Attempt to salvage or undef debug info when removing trivially…
Nov 11 2019, 6:05 AM
TWeaver closed D69943: Attempt to Salvage Debug Info or undef intrinsics when dropping trivially deletable instructions in reassociate pass.
Nov 11 2019, 6:05 AM · Restricted Project
TWeaver committed rG75af15d81ef3: [NFC][TEST_COMMIT] Add fullstop to comment. (authored by TWeaver).
[NFC][TEST_COMMIT] Add fullstop to comment.
Nov 11 2019, 5:47 AM

Nov 8 2019

TWeaver updated the diff for D69943: Attempt to Salvage Debug Info or undef intrinsics when dropping trivially deletable instructions in reassociate pass.

updated to use newly added helper function for salvage or undeffing behaviour when dropping instructions in reassociate expressions pass.

Nov 8 2019, 6:06 AM · Restricted Project

Nov 7 2019

TWeaver added a comment to D69943: Attempt to Salvage Debug Info or undef intrinsics when dropping trivially deletable instructions in reassociate pass.

If D69809 lands before this patch, then you can use the helper function salvageDebugInfoOrMarkUndef() which the former introduces.

Nov 7 2019, 7:04 AM · Restricted Project
TWeaver updated the diff for D69943: Attempt to Salvage Debug Info or undef intrinsics when dropping trivially deletable instructions in reassociate pass.
Nov 7 2019, 5:05 AM · Restricted Project
TWeaver added reviewers for D69943: Attempt to Salvage Debug Info or undef intrinsics when dropping trivially deletable instructions in reassociate pass: dblaikie, aprantl, vsk.
Nov 7 2019, 5:05 AM · Restricted Project
TWeaver updated subscribers of D69943: Attempt to Salvage Debug Info or undef intrinsics when dropping trivially deletable instructions in reassociate pass.
Nov 7 2019, 5:05 AM · Restricted Project
TWeaver created D69943: Attempt to Salvage Debug Info or undef intrinsics when dropping trivially deletable instructions in reassociate pass.
Nov 7 2019, 4:55 AM · Restricted Project

Sep 16 2019

TWeaver added a comment to D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction.

Hi there,

Sep 16 2019, 4:06 AM · Restricted Project, Restricted Project

Aug 27 2019

TWeaver added a comment to D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction.

Hi there!

Aug 27 2019, 7:46 AM · Restricted Project, Restricted Project

Jul 17 2019

TWeaver added inline comments to D64853: Fix CommandInterpreter for _regex-break with options.
Jul 17 2019, 3:05 AM · Restricted Project

Jan 22 2019

TWeaver added a comment to D57018: Fix lvm::is_trivially_copyable portability issues.

Slight fix r351820 seems to have done the trick, many thanks!

Jan 22 2019, 6:26 AM
TWeaver added a comment to D57018: Fix lvm::is_trivially_copyable portability issues.

and thanks for the patch either way, nice to know we're not in this alone.

Jan 22 2019, 6:20 AM
TWeaver added a comment to D57018: Fix lvm::is_trivially_copyable portability issues.

seems like the best thing to do here is revert the original commit that broke the bots in the first place?

Jan 22 2019, 6:19 AM
TWeaver added a comment to D57018: Fix lvm::is_trivially_copyable portability issues.

Hi there,

Jan 22 2019, 3:44 AM

Jan 21 2019

TWeaver added inline comments to D56151: [DebugInfo] PR40010: Avoid register coalesing altering DBG_VALUE valuations.
Jan 21 2019, 9:35 AM · Restricted Project
TWeaver added a comment to D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.

very gentle and polite ping.

Jan 21 2019, 4:18 AM

Jan 9 2019

TWeaver added a comment to D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.
> So GAS does the same thing as Clang's integrated assembler currently (pre-patch) and that behavior is problematic for GDB and LLDB?
Jan 9 2019, 8:40 AM

Nov 28 2018

TWeaver abandoned D55004: [ARM, AArch64] [FIX] add missing header causing build issues for r347741.
Nov 28 2018, 7:20 AM
TWeaver added a comment to D55004: [ARM, AArch64] [FIX] add missing header causing build issues for r347741.

No problem's David,

Nov 28 2018, 7:14 AM
TWeaver created D55004: [ARM, AArch64] [FIX] add missing header causing build issues for r347741.
Nov 28 2018, 7:09 AM

Nov 23 2018

TWeaver added a comment to D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.

So, I've been poking around in MCObjectStreamer.cpp and have found the area where multiple .loc directives are emitted, however,

Nov 23 2018, 7:30 AM

Nov 22 2018

TWeaver added a comment to D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.

I've also taken a look at GAS and tested it's behaviour and have found it mirrors clangs, that is, it will happily output line entries for multiple .loc directives with no interceding instructions - thus leading to line table entries with address delta's of 0.

Nov 22 2018, 8:14 AM
TWeaver added a comment to D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.

Hello fellow LLVM contributors.

Nov 22 2018, 8:10 AM

Nov 2 2018

TWeaver added a comment to D54036: [fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds.

Oh, I don't have commit access, are you able to commit for me Sam?

Nov 2 2018, 8:39 AM
TWeaver added a comment to D54036: [fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds.

I'm happy as is.

Nov 2 2018, 8:37 AM
TWeaver added a comment to D54036: [fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds.

The test failed on the following build bot:

Nov 2 2018, 8:29 AM
TWeaver created D54036: [fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds.
Nov 2 2018, 8:21 AM

Sep 12 2018

TWeaver added a comment to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.

couple of nitpicks.

Sep 12 2018, 6:11 AM · debug-info

Jul 23 2018

TWeaver added a comment to D49559: [XRay] Remove scheduling dependency in fork_basic_logging.cc.
Jul 23 2018, 3:12 AM

Jul 18 2018

TWeaver added a comment to D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.

Could you provide a small example dump of the invalid line table you're addressing?

I fed the resulting .elf into dwarfdump with -l and got the following output:

What is the ouput generated by llvm-dwarfdump?

Jul 18 2018, 6:24 AM
TWeaver added a comment to D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.

I feel like maybe the solution here should be in the MC integrated
assembler - to not emit zero-length sequences in the line table, regardless
of whether it's in the prologue or anywhere else?

Jul 18 2018, 3:21 AM

Jul 17 2018

TWeaver updated the diff for D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.

updated test .cpp source description with correct source.

Jul 17 2018, 10:37 AM
TWeaver added a comment to D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.

Could you provide a small example dump of the invalid line table you're addressing?

Jul 17 2018, 10:27 AM
TWeaver updated the summary of D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.
Jul 17 2018, 10:05 AM
TWeaver added reviewers for D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues: probinson, CarlosAlbertoEnciso.
Jul 17 2018, 7:58 AM
TWeaver created D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.
Jul 17 2018, 7:54 AM

Jul 12 2018

TWeaver added a watcher for debug-info: TWeaver.
Jul 12 2018, 3:21 AM