Page MenuHomePhabricator

TWeaver (Tom Weaver)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2018, 4:24 AM (64 w, 14 m)

Recent Activity

Jul 17 2019

TWeaver added inline comments to D64853: Fix CommandInterpreter for _regex-break with options.
Jul 17 2019, 3:05 AM · Restricted Project

Jan 22 2019

TWeaver added a comment to D57018: Fix lvm::is_trivially_copyable portability issues.

Slight fix r351820 seems to have done the trick, many thanks!

Jan 22 2019, 6:26 AM
TWeaver added a comment to D57018: Fix lvm::is_trivially_copyable portability issues.

and thanks for the patch either way, nice to know we're not in this alone.

Jan 22 2019, 6:20 AM
TWeaver added a comment to D57018: Fix lvm::is_trivially_copyable portability issues.

seems like the best thing to do here is revert the original commit that broke the bots in the first place?

Jan 22 2019, 6:19 AM
TWeaver added a comment to D57018: Fix lvm::is_trivially_copyable portability issues.

Hi there,

Jan 22 2019, 3:44 AM

Jan 21 2019

TWeaver added inline comments to D56151: [DebugInfo] PR40010: Avoid register coalesing altering DBG_VALUE valuations.
Jan 21 2019, 9:35 AM · Restricted Project
TWeaver added a comment to D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.

very gentle and polite ping.

Jan 21 2019, 4:18 AM

Jan 9 2019

TWeaver added a comment to D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.
> So GAS does the same thing as Clang's integrated assembler currently (pre-patch) and that behavior is problematic for GDB and LLDB?
Jan 9 2019, 8:40 AM

Nov 28 2018

TWeaver abandoned D55004: [ARM, AArch64] [FIX] add missing header causing build issues for r347741.
Nov 28 2018, 7:20 AM
TWeaver added a comment to D55004: [ARM, AArch64] [FIX] add missing header causing build issues for r347741.

No problem's David,

Nov 28 2018, 7:14 AM
TWeaver created D55004: [ARM, AArch64] [FIX] add missing header causing build issues for r347741.
Nov 28 2018, 7:09 AM

Nov 23 2018

TWeaver added a comment to D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.

So, I've been poking around in MCObjectStreamer.cpp and have found the area where multiple .loc directives are emitted, however,

Nov 23 2018, 7:30 AM

Nov 22 2018

TWeaver added a comment to D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.

I've also taken a look at GAS and tested it's behaviour and have found it mirrors clangs, that is, it will happily output line entries for multiple .loc directives with no interceding instructions - thus leading to line table entries with address delta's of 0.

Nov 22 2018, 8:14 AM
TWeaver added a comment to D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.

Hello fellow LLVM contributors.

Nov 22 2018, 8:10 AM

Nov 2 2018

TWeaver added a comment to D54036: [fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds.

Oh, I don't have commit access, are you able to commit for me Sam?

Nov 2 2018, 8:39 AM
TWeaver added a comment to D54036: [fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds.

I'm happy as is.

Nov 2 2018, 8:37 AM
TWeaver added a comment to D54036: [fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds.

The test failed on the following build bot:

Nov 2 2018, 8:29 AM
TWeaver created D54036: [fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds.
Nov 2 2018, 8:21 AM

Sep 12 2018

TWeaver added a comment to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.

couple of nitpicks.

Sep 12 2018, 6:11 AM · debug-info

Jul 23 2018

TWeaver added a comment to D49559: [XRay] Remove scheduling dependency in fork_basic_logging.cc.
Jul 23 2018, 3:12 AM

Jul 18 2018

TWeaver added a comment to D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.

Could you provide a small example dump of the invalid line table you're addressing?

I fed the resulting .elf into dwarfdump with -l and got the following output:

What is the ouput generated by llvm-dwarfdump?

Jul 18 2018, 6:24 AM
TWeaver added a comment to D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.

I feel like maybe the solution here should be in the MC integrated
assembler - to not emit zero-length sequences in the line table, regardless
of whether it's in the prologue or anywhere else?

Jul 18 2018, 3:21 AM

Jul 17 2018

TWeaver updated the diff for D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.

updated test .cpp source description with correct source.

Jul 17 2018, 10:37 AM
TWeaver added a comment to D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.

Could you provide a small example dump of the invalid line table you're addressing?

Jul 17 2018, 10:27 AM
TWeaver updated the summary of D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.
Jul 17 2018, 10:05 AM
TWeaver added reviewers for D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues: probinson, CarlosAlbertoEnciso.
Jul 17 2018, 7:58 AM
TWeaver created D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.
Jul 17 2018, 7:54 AM

Jul 12 2018

TWeaver added a watcher for debug-info: TWeaver.
Jul 12 2018, 3:21 AM