Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
I think we need a little more than just moving the file. Don't we need to set up some dependences to make this work?
Also, we have asan leak detection disabled (for now) for these kinds of tests that use exec engine, with something like
config.environment['ASAN_OPTIONS'] = 'detect_leaks=0'
In the first time set-up in any build directory, pass the following:
cmake -G Ninja ../llvm \ -DLLVM_ENABLE_PROJECTS=mlir \ .... -DMLIR_INCLUDE_INTEGRATION_TESTS=ON \ ...
after that one-time setup, make sure to always test with
cmake --build . --target check-mlir
or for just integration
cmake --build . --target check-mlir-integration
mlir/test/Integration/Dialect/SparseTensor/python/lit.local.cfg | ||
---|---|---|
2 | can you please add comments for each section (as we do in the other lit.local.cfg files in Integration) explaining what every part does. For example Disable ASAN's leak detection for python OpsDSL tests.config.environment['ASAN_OPTIONS'] = 'detect_leaks=0' Only run when python bindings are enabled.if not config.enable_bindings_python: config.unsupported = True
|
Adding comments
mlir/test/Integration/Dialect/SparseTensor/python/lit.local.cfg | ||
---|---|---|
2 | Re the last part ::shrug:: I just copied the file from another place with python tests, as mentioned in the only documentation I could find |
mlir/test/Integration/Dialect/SparseTensor/python/lit.local.cfg | ||
---|---|---|
2 | I think that was only needed in the mlir test/python context |
can you please add comments for each section (as we do in the other lit.local.cfg files in Integration) explaining what every part does.
For example
Disable ASAN's leak detection for python OpsDSL tests.
config.environment['ASAN_OPTIONS'] = 'detect_leaks=0'
Only run when python bindings are enabled.
if not config.enable_bindings_python: