Page MenuHomePhabricator

[analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances
AcceptedPublic

Authored by ASDenysPetrov on Tue, Nov 16, 8:45 AM.

Details

Summary

Passed a CodeGenOptions reference from CompilerInstance to AnalysisConsumer and then to AnalysisManager to enable access to the options for CSA instances such as StoreManager, ConstraintManager and others, This patch is a preliminary one for D110927.

NOTE: The half of the changes is just formatting.

Diff Detail

Event Timeline

ASDenysPetrov created this revision.Tue, Nov 16, 8:45 AM
ASDenysPetrov requested review of this revision.Tue, Nov 16, 8:45 AM
ASDenysPetrov retitled this revision from [analyzer]{NFC} Enable access to CodeGenOptions from analyzer's instances. to [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances..Tue, Nov 16, 10:09 AM
steakhal accepted this revision.Tue, Nov 16, 11:03 AM

Sweet!
I think commit titles are not punctuated, even though they start with an uppercase letter.

This revision is now accepted and ready to land.Tue, Nov 16, 11:03 AM
ASDenysPetrov updated this revision to Diff 387773.EditedTue, Nov 16, 3:17 PM

Fixed failed unittest (Syntax error).

ASDenysPetrov retitled this revision from [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances. to [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances.Tue, Nov 16, 3:20 PM

Sweet!
I think commit titles are not punctuated, even though they start with an uppercase letter.

Thanks! That depends on the mood at the particular moment :) But seriously, it's an automatic typo. I do it every other time :) Fixed.

martong accepted this revision.Fri, Nov 19, 2:13 AM

LGTM!

LGTM!

Thanks, guys!
I'll load it as soon as D110927 also be ready for load(I'm working on it), as this patch is just a preparatory one.