Page MenuHomePhabricator

[clangd] Fix assertion crashes on unmatched NOLINTBEGIN comments.
ClosedPublic

Authored by hokein on Tue, Nov 16, 7:05 AM.

Details

Summary

The overload shouldSuppressDiagnostic seems unnecessary, and it is only
used in clangd.

This patch removes it and use the real one (suppression diagnostics are
discarded in clangd at the moment).

Fixes https://github.com/clangd/clangd/issues/929

Diff Detail

Event Timeline

hokein created this revision.Tue, Nov 16, 7:05 AM
hokein requested review of this revision.Tue, Nov 16, 7:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Nov 16, 7:05 AM
kadircet accepted this revision.Wed, Nov 17, 2:51 AM

thanks, lgtm!

This revision is now accepted and ready to land.Wed, Nov 17, 2:51 AM